From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDye6-00029M-0T
	for guix-patches@gnu.org; Thu, 25 May 2017 15:42:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDye2-0003R5-TW
	for guix-patches@gnu.org; Thu, 25 May 2017 15:42:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35467)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dDye2-0003Qf-Qc
	for guix-patches@gnu.org; Thu, 25 May 2017 15:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDye2-0001r0-Fy
	for guix-patches@gnu.org; Thu, 25 May 2017 15:42:02 -0400
Subject: bug#27073: [PATCH] gnu: Add cpuid.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.27073.D27073.14957412637050.done@debbugs.gnu.org>
References: <20170525182349.22612-1-clement@lassieur.org>
	<87o9ugvkav.fsf@fastmail.com>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <87o9ugvkav.fsf@fastmail.com>
Date: Thu, 25 May 2017 21:41:00 +0200
Message-ID: <87o9ugragj.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27073-done@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> writes:

> Clément Lassieur <clement@lassieur.org> writes:
>
>> * gnu/packages/linux.scm (cpuid): New variable.
>
> [...]
>
>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)
>> +                  (add-before 'install 'fix-makefile
>> +                    (lambda* (#:key outputs #:allow-other-keys)
>> +                      (substitute* "Makefile"
>> +                        (("\\$\\(BUILDROOT\\)/usr") (assoc-ref outputs "out")))
>> +                      (substitute* "Makefile"
>> +                        (("-m 444") "-m 644"))
>
> Why is this necessary? Perhaps you can add a comment?

I added:

;; Make the compressed manpages writable so that the
;; reset-gzip-timestamps phase does not error out.

> LGTM otherwise.

Thanks for the review :-) Pushed.