all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27073-done@debbugs.gnu.org
Subject: bug#27073: [PATCH] gnu: Add cpuid.
Date: Thu, 25 May 2017 21:41:00 +0200	[thread overview]
Message-ID: <87o9ugragj.fsf@lassieur.org> (raw)
In-Reply-To: <87o9ugvkav.fsf@fastmail.com>

Marius Bakke <mbakke@fastmail.com> writes:

> Clément Lassieur <clement@lassieur.org> writes:
>
>> * gnu/packages/linux.scm (cpuid): New variable.
>
> [...]
>
>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)
>> +                  (add-before 'install 'fix-makefile
>> +                    (lambda* (#:key outputs #:allow-other-keys)
>> +                      (substitute* "Makefile"
>> +                        (("\\$\\(BUILDROOT\\)/usr") (assoc-ref outputs "out")))
>> +                      (substitute* "Makefile"
>> +                        (("-m 444") "-m 644"))
>
> Why is this necessary? Perhaps you can add a comment?

I added:

;; Make the compressed manpages writable so that the
;; reset-gzip-timestamps phase does not error out.

> LGTM otherwise.

Thanks for the review :-) Pushed.

      reply	other threads:[~2017-05-25 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 18:23 bug#27073: [PATCH] gnu: Add cpuid Clément Lassieur
2017-05-25 18:36 ` Clément Lassieur
2017-05-25 18:41   ` ng0
2017-05-25 19:13     ` Clément Lassieur
2017-05-25 18:54 ` Marius Bakke
2017-05-25 19:41   ` Clément Lassieur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9ugragj.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=27073-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.