From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dGP0L-0004tG-7i
	for guix-patches@gnu.org; Thu, 01 Jun 2017 08:15:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dGP0H-0005iV-UO
	for guix-patches@gnu.org; Thu, 01 Jun 2017 08:15:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46024)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dGP0H-0005iK-S3
	for guix-patches@gnu.org; Thu, 01 Jun 2017 08:15:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dGP0H-0002TC-Kb
	for guix-patches@gnu.org; Thu, 01 Jun 2017 08:15:01 -0400
Subject: bug#27173: [PATCH] import: pypi: Always use pypi.io URL with
	downcased package name.
Resent-Message-ID: <handler.27173.B27173.14963192719442@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170531200415.21780-1-dannym@scratchpost.org>
	<87zidrzzcd.fsf@gnu.org>
Date: Thu, 01 Jun 2017 14:14:18 +0200
In-Reply-To: <87zidrzzcd.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Thu, 01 Jun 2017 14:06:42 +0200")
Message-ID: <87o9u7zyzp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27173@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Hi Danny,
>
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * guix/import/pypi.scm (make-pypi-sexp): Always use pypi.io URL with
>> downcased package name.
>> ---
>>  guix/import/pypi.scm | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
>> index 9c72e7331..90dbe5612 100644
>> --- a/guix/import/pypi.scm
>> +++ b/guix/import/pypi.scm
>> @@ -258,11 +258,7 @@ VERSION, SOURCE-URL, HOME-PAGE, SYNOPSIS, DESCRIPTI=
ON, and LICENSE."
>>                         ;; Sometimes 'pypi-uri' doesn't quite work due t=
o mixed
>>                         ;; cases in NAME, for instance, as is the case w=
ith
>>                         ;; "uwsgi".  In that case, fall back to a full U=
RL.
>> -                       (uri ,(if (equal? (pypi-uri name version) source=
-url)
>> -                                 `(pypi-uri ,name version)
>> -                                 `(string-append
>> -                                   ,@(factorize-uri source-url version)=
)))
>> -
>> +                       (uri (pypi-uri ,(string-downcase name) version))
>
> So is the command above outdated?
            ^------
Should read: =E2=80=9Cthe comment.=E2=80=9D

Ludo=E2=80=99.