From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27173@debbugs.gnu.org
Subject: bug#27173: [PATCH] import: pypi: Always use pypi.io URL with downcased package name.
Date: Thu, 01 Jun 2017 14:14:18 +0200 [thread overview]
Message-ID: <87o9u7zyzp.fsf@gnu.org> (raw)
In-Reply-To: <87zidrzzcd.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 01 Jun 2017 14:06:42 +0200")
ludo@gnu.org (Ludovic Courtès) skribis:
> Hi Danny,
>
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * guix/import/pypi.scm (make-pypi-sexp): Always use pypi.io URL with
>> downcased package name.
>> ---
>> guix/import/pypi.scm | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
>> index 9c72e7331..90dbe5612 100644
>> --- a/guix/import/pypi.scm
>> +++ b/guix/import/pypi.scm
>> @@ -258,11 +258,7 @@ VERSION, SOURCE-URL, HOME-PAGE, SYNOPSIS, DESCRIPTION, and LICENSE."
>> ;; Sometimes 'pypi-uri' doesn't quite work due to mixed
>> ;; cases in NAME, for instance, as is the case with
>> ;; "uwsgi". In that case, fall back to a full URL.
>> - (uri ,(if (equal? (pypi-uri name version) source-url)
>> - `(pypi-uri ,name version)
>> - `(string-append
>> - ,@(factorize-uri source-url version))))
>> -
>> + (uri (pypi-uri ,(string-downcase name) version))
>
> So is the command above outdated?
^------
Should read: “the comment.”
Ludo’.
prev parent reply other threads:[~2017-06-01 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 20:04 bug#27173: [PATCH] import: pypi: Always use pypi.io URL with downcased package name Danny Milosavljevic
2017-06-01 12:06 ` Ludovic Courtès
2017-06-01 12:14 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9u7zyzp.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27173@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.