From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] git-download: Speed up 'git-predicate'. Date: Tue, 25 Jul 2017 23:26:15 +0200 Message-ID: <87o9s8b43s.fsf@gnu.org> References: <87zidk2c4g.fsf@gnu.org> <20170619071443.23122-1-mail@cbaines.net> <87fuetggn9.fsf@gnu.org> <20170716114220.55d845e9@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da7LR-00024H-BI for guix-devel@gnu.org; Tue, 25 Jul 2017 17:26:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da7LO-0002xk-7H for guix-devel@gnu.org; Tue, 25 Jul 2017 17:26:21 -0400 In-Reply-To: <20170716114220.55d845e9@cbaines.net> (Christopher Baines's message of "Sun, 16 Jul 2017 11:42:20 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Hi! Christopher Baines skribis: > I've had a little look at the performance, and I think this approach of > using a vhash might be slower, but not by much. The biggest difference > I saw for the guix repository was 0.008 seconds, and for smart-answers > was 0.6 seconds. > > I'm happy to go ahead with either though, obviously these performance > differences don't matter compared to the current performance for large > repositories. I=E2=80=99ve finally pushed the patch with my changes as f135b4ae8397d2c501150d3ead3e0603e770ce3f. Seems to work well but let me know if you encounter any issues. Thanks, and sorry for the delay! Ludo=E2=80=99.