From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dptM1-0005uI-L2
	for guix-patches@gnu.org; Thu, 07 Sep 2017 05:44:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dptLu-0001cf-3R
	for guix-patches@gnu.org; Thu, 07 Sep 2017 05:44:09 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45146)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dptLt-0001cb-VH
	for guix-patches@gnu.org; Thu, 07 Sep 2017 05:44:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dptLt-0007Cf-Nx
	for guix-patches@gnu.org; Thu, 07 Sep 2017 05:44:01 -0400
Subject: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere.
Resent-Message-ID: <handler.28262.D28262.150477740027628@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170828134610.30984-1-me@tobias.gr> <871snrsx1n.fsf@gnu.org>
	<59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr>
Date: Thu, 07 Sep 2017 11:43:07 +0200
In-Reply-To: <59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr> (Tobias
	Geerinckx-Rice's message of "Tue, 5 Sep 2017 18:21:36 +0200")
Message-ID: <87o9qmyhck.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 28262-done@debbugs.gnu.org

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

>> As a followup, we should look into merging the two =E2=80=98http-fetch=
=E2=80=99
>> procedures.  I don=E2=80=99t think the initial motivation for having two
>> separate implementations still holds.
>
> I'll push this fix and close this bug, but if you have the time I'd love
> to know more about that initial motivation. The two have grown quite apar=
t.

Initially (guix http-client) existed simply to paper over API changes in
Guile=E2=80=99s (web client) and to work around bugs in older Guile version.
This is because (guix http-client) is used on the =E2=80=9Chost=E2=80=9D si=
de, where we
support(ed) older releases of Guile 2.0.

(guix build download) didn=E2=80=99t really have this constraint because the
Guile used on the =E2=80=9Cbuild=E2=80=9D side was known, and known to be r=
ecent enough
in most cases.  So all it did was to add a higher-level API above what
Guile provides, which follows redirects, etc.

Since 36626c556ed75219bce196ac93d148f6b9af984c we require Guile >=3D
2.0.9, so some of the bugs/workarounds we had no longer apply and the
separation probably no longer makes sense.

HTH!

Ludo=E2=80=99.