From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dvp09-0005DJ-Nf
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:18:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dvp06-0006cJ-IR
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:18:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46177)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dvp06-0006cD-Em
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:18:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dvp06-0003ix-3l
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:18:02 -0400
Subject: [bug#28558] [PATCH] gnu: Add atool.
Resent-Message-ID: <handler.28558.B.150619062414246@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan@xsteve.at>) id 1dvoz1-0004qW-K6
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:16:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefan@xsteve.at>) id 1dvoyy-00067w-G3
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:16:55 -0400
Received: from dd5424.kasserver.com ([85.13.138.252]:44816)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <stefan@xsteve.at>) id 1dvoyy-00067h-8m
	for guix-patches@gnu.org; Sat, 23 Sep 2017 14:16:52 -0400
Received: from localhost (unknown [149.154.152.222])
	by dd5424.kasserver.com (Postfix) with ESMTPA id 7AAEFB5839CA
	for <guix-patches@gnu.org>; Sat, 23 Sep 2017 20:16:50 +0200 (CEST)
From: Stefan =?UTF-8?Q?Reich=C3=B6r?= <stefan@xsteve.at>
In-Reply-To: <bb546080-8a63-824e-43a6-24d62abc9c07@uq.edu.au> (Ben Woodcroft's
	message of "Sat, 23 Sep 2017 18:43:10 +1000")
References: <150611695436.21286.7179341499419388884.stgit@sandburg>
	<bb546080-8a63-824e-43a6-24d62abc9c07@uq.edu.au>
Date: Sat, 23 Sep 2017 20:16:48 +0200
Message-ID: <87o9q12sbz.fsf@xsteve.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 28558@debbugs.gnu.org

Hi Ben,

> On 23/09/17 07:49, Stefan Reich=C3=B6r wrote:
>> * gnu/packages/compression.scm (atool): New variable.
> Thanks for the patch. While adding all compression programs supported
> (e.g. tar) as inputs is probably too much given their large number, I
> think it would be good to add "file" and patch in the path to "file"
> in bin/atool. WDYT?

Thanks for your feedback. I don't think that file is an important tool
for atool. At least I use only archives with the correct file extension.
And all the archives that I remember that I downloaded from some site
also provided the correct file extension. In that case file is not needed to
detect the archive type.

However, if you think that hard coding the full path to file is a good
thing I will update my patch. It should be doable for me...

> Otherwise LGTM.
> ben


Stefan.