From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7aZO-0001Uc-Im
	for guix-patches@gnu.org; Thu, 26 Oct 2017 01:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7aZK-0008OO-2t
	for guix-patches@gnu.org; Thu, 26 Oct 2017 01:19:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53431)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e7aZJ-0008OC-VB
	for guix-patches@gnu.org; Thu, 26 Oct 2017 01:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e7aZJ-00020f-Pz
	for guix-patches@gnu.org; Thu, 26 Oct 2017 01:19:01 -0400
Subject: [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and
	glib modules support.
Resent-Message-ID: <handler.28853.B28853.15089950907665@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171015151545.024a589f@uwaterloo.ca>
	<20171015200328.4830-1-ajpatter@uwaterloo.ca>
	<87mv4rkywx.fsf@member.fsf.org> <20171018221906.7f76610a@uwaterloo.ca>
Date: Wed, 25 Oct 2017 22:18:01 -0700
In-Reply-To: <20171018221906.7f76610a@uwaterloo.ca> (Andy Patterson's message
	of "Wed, 18 Oct 2017 22:19:06 -0400")
Message-ID: <87o9ouij1y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 28853@debbugs.gnu.org

Hello,

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> On Mon, 16 Oct 2017 21:25:18 +0800
> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote:
>
>> Andy Patterson <ajpatter@uwaterloo.ca> writes:
>>=20
>> > virt-manager: Enable gtk schemas and glib modules support.=20=20
>>=20
>> How about: Wrap with GSettings schema and GIO modules search paths.
>>=20
>> Otherwise, this patch series look good to me, thanks!
>
> Sounds good, updated patch appened:
>
> --
> Andy
>
> From f504ccc9e961e7657261a478e278c142b9006e6b Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter@uwaterloo.ca>
> Date: Sun, 15 Oct 2017 11:47:16 -0400
> Subject: [PATCH] gnu: virt-manager: Wrap with GSettings schema and GIO mo=
dules
>  search paths.
>
> Fixes a crash when opening the file chooser dialog.
>
> * gnu/packages/virtualization.scm (virt-manager)[arguments]
> <#:imported-modules>: Add (guix build glib-or-gtk-build-system).
> <#:modules>: Import (guix build glib-or-gtk-build-system) as glib-or-gtk:.
> <#:arguments>: Add 'glib-or-gtk-compile-schemas and 'glib-or-gtk-wrap.

Since we haven=E2=80=99t heard from =E5=AE=8B=E6=96=87=E6=AD=A6, I went ahe=
ad and committed it.

Thanks!

Ludo=E2=80=99.