all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 29100@debbugs.gnu.org
Subject: [bug#29100] [PATCH 2/3] install: Use overlayfs instead of unionfs.
Date: Sun, 05 Nov 2017 22:05:52 +0100	[thread overview]
Message-ID: <87o9ogmo5r.fsf@gnu.org> (raw)
In-Reply-To: <bc0178ad-d45c-1eb3-ae41-79ff7fca97f9@crazy-compilers.com> (Hartmut Goebel's message of "Thu, 2 Nov 2017 19:20:51 +0100")

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 02.11.2017 um 18:44 schrieb Danny Milosavljevic:
>> [...]
>>> -      (let ((rw-dir (string-append target #$%backing-directory)))
>>> +      (let* ((rw-dir (string-append target #$%backing-directory))
>>> +             ;; FIXME: calculate work-dir from backing-directory:
>>> +             ;; normpath(backing-directory + "../.overlayfs-workdir")
>>> +             (work-dir (string-append target "/tmp/.overlayfs-workdir")))
>> What about the FIXME?
>
> I'll change it into a TODO. Somebody with more knowledge in scheme as to
> implement this.

What does this comment mean exactly?  The “has to” suggests that it’s
important.  :-)

Perhaps you mean:

  (canonicalize-path (string-append rw-dir "/../.overlayfs-workdir"))

?

Ludo’.

  reply	other threads:[~2017-11-05 21:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01  8:33 [bug#29100] [PATCH 0/3] Use overlayfs instead of unionfs Hartmut Goebel
2017-11-01  8:39 ` [bug#29100] [PATCH 1/3] build: " Hartmut Goebel
2017-11-01  8:39   ` [bug#29100] [PATCH 2/3] install: " Hartmut Goebel
2017-11-02 17:44     ` Danny Milosavljevic
2017-11-02 18:20       ` Hartmut Goebel
2017-11-05 21:05         ` Ludovic Courtès [this message]
2017-11-06  9:33           ` Hartmut Goebel
2017-11-01  8:39   ` [bug#29100] [PATCH 3/3] gnu: service: Update comment Hartmut Goebel
2017-11-05 21:09     ` Ludovic Courtès
2017-11-05 21:08   ` [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs Ludovic Courtès
2017-11-06  9:40     ` Hartmut Goebel
2017-11-06 10:30       ` Ludovic Courtès
2017-11-08 17:26 ` bug#29100: Updated, tested again and merged Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9ogmo5r.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=29100@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.