all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 29079@debbugs.gnu.org
Subject: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Thu, 09 Nov 2017 17:53:24 -0500	[thread overview]
Message-ID: <87o9obysgr.fsf@posteo.net> (raw)
In-Reply-To: <877ev2cvnm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 07 Nov 2017 09:58:37 +0100")


[-- Attachment #1.1: Type: text/plain, Size: 1441 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Hi Kei,
>>>
>>> Kei Kebreau <kkebreau@posteo.net> skribis:
>>>
>>>> * gnu/packages/dictionaries.scm (hunspell-en-US): New variable.
>>>
>>> On the same day I added this one and a couple of other dictionaries:
>>>
>>>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=085bcca313c3827f7c56e7c345d4606588db9085
>>>
>>> The package I committed builds the Hunspell list “from source”.
>>>
>>> Let me know whether we should adjust things and what you think of it.
>>>
>>> Thanks!
>>>
>>> Ludo’.
>>
>> I definitely like the generality and flexibility of this patch
>> better. To get the dictionary to work in LibreOffice I had to install
>> the .dic file as well [0], but once I did that everything seemed to work
>> as expected.
>>
>> [0]:
>>   (mkdir-p myspell)
>> + (install-file ,(string-append "speller/" language ".dic")
>> +               hunspell)
>>   (install-file ,(string-append "speller/" language ".aff")
>>                 hunspell)
>
> Nice (I thought Hunspell used exclusively the .aff files.)
> OK for this patch!
>
> The hunspell-dict-fr* packages include both .aff and .dic, so that
> should be fine.
>
> Thanks,
> Ludo’.

Is this log message okay? I'm not sure how we handle changes to package
template functions.

[-- Attachment #1.2: 0001-gnu-Fix-hunspell-dict-en-dictionary-installation.patch --]
[-- Type: text/plain, Size: 1105 bytes --]

From c143bad02ebcb7d94ad6e2582b6831c5d107e2a8 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Thu, 9 Nov 2017 17:49:02 -0500
Subject: [PATCH] gnu: Fix hunspell-dict-en-* dictionary installation.

* gnu/packages/aspell.scm (aspell-word-list)[arguments]: Install the .dic file
for all hunspell dictionaries.
---
 gnu/packages/aspell.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 3eeeee64f..86e059834 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -270,6 +270,8 @@ dictionaries, including personal ones.")
                     (doc      (string-append out "/share/doc/"
                                              ,name)))
                (mkdir-p myspell)
+               (install-file ,(string-append "speller/" language ".dic")
+                             hunspell)
                (install-file ,(string-append "speller/" language ".aff")
                              hunspell)
                (symlink hunspell (string-append myspell "/dicts"))
-- 
2.14.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-11-09 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 14:47 [bug#29079] [PATCH] gnu: Add hunspell-en-US Kei Kebreau
2017-11-05 21:02 ` Ludovic Courtès
2017-11-07  3:45   ` Kei Kebreau
2017-11-07  8:58     ` Ludovic Courtès
2017-11-09 22:53       ` Kei Kebreau [this message]
2017-11-10 10:22         ` Ludovic Courtès
2017-11-10 17:00           ` bug#29079: " Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9obysgr.fsf@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=29079@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.