From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRV37-0000Ej-E8 for guix-patches@gnu.org; Tue, 19 Dec 2017 22:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRV34-0007o7-3O for guix-patches@gnu.org; Tue, 19 Dec 2017 22:28:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRV33-0007nq-Ui for guix-patches@gnu.org; Tue, 19 Dec 2017 22:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRV33-0007Xu-Ir for guix-patches@gnu.org; Tue, 19 Dec 2017 22:28:01 -0500 Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-Message-ID: From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> Date: Wed, 20 Dec 2017 06:26:54 +0300 In-Reply-To: <878tdy1lmq.fsf@gmail.com> (Alex Kost's message of "Tue, 19 Dec 2017 23:57:33 +0300") Message-ID: <87o9muxeo1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Kost Cc: 28832@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Kost writes: > and I would make it more robust: there is a > problem with this code: (string-drop "geiser" 6) does not return what > you mean Yes, because "geiser" differs from most of Emacs packages: ls /gnu/store/7rl2k8ismmyq9ic6ha6vzv38a3hrrni2-emacs-dash-2.13.0/share/= emacs/site-lisp/guix.d/dash-2.13.0/ dash-autoloads.el dash.el dash.elc dash-functional.el dash-function= al.elc ls /gnu/store/7lh77fmapmjjv3kj2q69dy58kjniw9am-geiser-0.9/share/emacs/s= ite-lisp/ geiser-autodoc.el geiser-chibi.elc =E2=80=A6 Maybe we just need to fix "geiser"? > , and (string-drop "dash" 6) errors! Do you really mean emacs-dash or dash? For me both succeeded. As I see emacs-dash is OK, except "emacs-minimal" in EMACSLOADPATH. Here is a log-file with DEBUG-INPUTS: --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=vggdk813p8c82h7bjgwm5ghrl6r42a-emacs-dash-2.13.0.drv.bz2 Content-Transfer-Encoding: base64 Content-Description: emacs-dash build log-file QlpoOTFBWSZTWZiCLtoAG2FfgEAQcP//+b/n3uT////wYBIM74N1969S1nfG8nn2A1aqm27fJ6ni hS6YioUEhUUXppOtddBwAJJJoU/UCeE09RlTaJppoeoaGnqPU02kaPRih6Q4CN/+qqTIMEMCYmjT TAIyDBGRpkMNNCAQnpNTaUGgGgAAAA0Bp6gEp6SlT8pP1GU9EPU0GmRoDQNAAAA0AIpIBDCNBMEy YTJJlPUaaGjQaNAAEURACAAmRDSntSNpihoGmmRoNNGnqYiRBN2wPHbyLPs1u4b5Bqme9w8afbuk fg73cJ8LnNNvdhShNoYmghiiq0fotDIucDE1qx5rQdTF1OEcVeWOECrQLEMUMqQkXH2OaSUiAvR3 JOU1cn95TkL7Gjd1b4SayJXBox/W1qvkd2ZYYUPJjDpZmpAmhhv0kHrByFI7qOCgO0EQ94IhSgkQ JECRAkQhCiLfvFMM4Dlqy0RPvxp8uWZrYAENBT5BiG0U9h6WojFdVB/KABMbwLDqPqYSSqg6xTPX +ZqwCkh4hfTiHvwx17u1A2AiGAp14B8IHGBL/shPhApwC48gjAEkAGo97Z7T2sNm19Ow7f52k41o qq99tyMNFZdPXLK7Tpdpokf15AEwJmEWWWV3LzSW4/690xmTpczwd141z584vYU50wlMjMxMrKuK wkoetspMBHC6DICFwhE+08WdBSUW53gUTVX0nE6PBJOh9DQGuIoVVFVSqQHPWCNJVmRgVWNYVzyt lLaFnZEO5J0sSZ/VfE8gj9wfvxNxQkqCIC+q3bSR/c3bJo370zLaGJI/mw1B+dhTa9ybiYKSC4nJ QMiChr1Aa0Li+6IpWbUQVh2YlkSxDF0GQXD7Uk81vbixjR2HxzxbCdP333Zaq1rhtxN2S2FCUviJ bqfWfCc5meb6NwNY1no2nBKKIYgggLkM60XxuvpDCBNpIrmLCIiIVR00hMwRRhW4wSszGFemseVt Yk2TKrMqCmKD1acs5KeiU+l5pS/aECkB92lmDEE88OHdKKUpIpBAszPrkYCFgVLIlPpSRfBgbmgJ ZZSiSpIREPsLrKMyEWlj1Bq20z13kO5ICIqrfrKnJvdozPVUqKxhHzwEOQgnLZfomTps64AAAAAA AAAAAAAAAAAAAAAAA5OaBAgjieJicCD/xXVeYZVyiNV9KxpSNVPDusgOtA1m3RKO74xR2ycYS7BZ UgdUtVwwwFFWhEUGwhEFKWhRVFkhwVVbhzTWZm03m4obzUKWFLLLrrN/pvTBEw4SSzEW8AuqsJST jjq0muqNWow5g6PzBB4JdQYLjWCeIrgzp809BSZG2qm3Rhnz6LrLLLMjKC6BIYBkQRCBSUwfgfYk 1ZFxEjVLmwWp5fkzP6ebQ4EVJ6qVxoR7UTnvRyopx5iIDhMvjRZlzT21Yaa4YYYZhpZCkQJOhNKD IkCpEwpEAegIhCTsMx+KVr9g5lKRH0Mz0Ww7Pde78c9rV9iHJO72NN/aNcpBoBROIqQkCHavTTp2 06du3XDDDCgZxDGZrn9p4FKRHNJmIuS4uXvC2WVAmdbiVvQssozMjMybDQ0TJ8Wr7xwf1r+lPkB1 S5PauY7dQkQoERD0nVt1693Tp04YYYYZicbJCZ2Mz6EzLMxERyXJpTE7DSmp6gUpL0dqdhzJ7AXp asnFnaE6poei38nPpcX2ZJtGFgQhh68OmW7fz3ZddMMMMM16WRER4J6mlLkmb2UqmUqpSkQqISiK k7vZOqbjK6jB2jrdyyoGLxQYoockmERokrqjHFGMYQhDBIBHQMMczLOkBqSNI8Sxm1uxC07vB0tj inZaR3J0c6CVD0c6LChJlc/JGu7juv3XQhCF8USZDdKaZMdGKlhzLJwSp5sniBM6k3pzbx9UOAlC cgHGVjVzjkFZGSSiWNUY3qYQhBzDWcia0TFiaxgMiRwNzkKmB9k6jqAhCSEnQkNyohpvsDo6tE+W qzVqz6NVlllkrYCMbkpfYmeDWyO6aJJmkFQPU8W1JTo9DFfUyB04j4j60lOYUFIuhKlFluN1Mb1u S2NsIQYyxTC5xs6aRDX0s5glpc6wOrxW0dzY73IPoupKUuTaB8w3Bw8a8M4i4QkVSGm4Wly2y5CS 2y7tYZznZQ1H26TUwzI4IO/Z46m8t+yY3gavDdCcgbxox+q9TMB7j3cAwfmHAaY5+CoxYbLZUqQh PLLcIUk/LrC8pmo1yA3bNQGAwEAeFBG2+yWJsNuVxvvqOJ2nxEkHiHRpL3hiMT68IWR/X39Xcugd WZtvCw8n9PKAcaZCF14l8Ey1gdi2FKDqA3aQG7F1IgGRfI7UgI0KD+x+1fvXcKX25GAEHBdCaIlA +17v9wK8AaOIZhr/FPrsCYyeeiGoMoMJxQBUnOKkQTlyvBdabQPmFhaKQOdoKZp2AYWEQ87ARDgh y1xGkFIKoHKCMtsRhcQFxRvqCkkQzlbVS/gP4LicSHY6vVjgYP8E/J1O1pG4T7/uNpoXZSprHCf8 V5yK1GyQ/2Rnb3omhL+Nr7P3mQLiB2tsk7Z7JELJIf6pc4JtbQMng4Aa/Xyobx2D+Qp87pzyJPXQ liklDaKUD1T1SmikOiE0KRaGwm1nGgjcbGXgfrTgIXp2ZgzRmPlKwUxkHGA5PMwFNrCNuNiSCAJ0 q6MTFN3EmURKomITqye6TGYfyaWh/wDUnJD2dj2H5vRlgGlYAhDYsQREQLATHt7B+Pm4vuTwOhAB yFPEonbMzXkkRT8UJBPxh4sHICL3s+HLOlEIeicB8TPFzClTimpPZ0gaKQxfgqal+E809b74PpNR PNEiLYo6xI430AvBSEssm3eSs1SUkwswmwwJKBdNkikEgHkXk4CLcAghQVkTGcYiYAAAYACtm95p Zn5SY1RqKS1moH0kgiGOIpNlstTQUuV0FNJqchQzNUt7QyLHE8KonFGwaAvCP7zdTQrSdAKzPSFs JYSi2BTQxgR8RoigIpy5sQo0I5SRD2oKxmoawIYGCCQUiVhBQceHY9E1vdpC5OS2YDns7XrILQ3b FJhCYQ4876XMrbQO6ZbbuFNaYil/IdHxTauTmFWgpIaBTyHAQOn1IdU6IeKcxtA5ZD1ZlPRgsTzb Q9lRLh1aOYIPTehaZoDRkUpV7nJah1p1KW7Q5TKnLdHrKGUkkkkKkkQEBDCwBEBAIdBwX3ricl+E 9GoPcCwJAvYFPmw8G5JxKD6XBpYGxkwknI2LO05U0vzA0GDg9UMXuVlha1KfJtPdORWvNmAtNCUC mwCG4NiSDYTJO6WeqdnW3wlb3ALoSGNq1qEqUSTs8cpQXEKPn5iFt7YhAR7KwRLCOPba5+wK4ClA zImWz7AhtWxqKoAJaXWQjm0vB1ieRMUgzMcH1A/YGZWqA0GINY1OnAcu5WA3vh926d6JzLea1Aya FvaV2Odw+iGhdHUIH2SxfhaSgtAhyN6clMvnSPuNaULwbL8GhLXy9V1NbUeEzIZh2W4xFfws00gi FGSJDJhkN4FNbR4h04d4AmhBV9+ScrTktD3RAFsrBBEJMGejMEVgIcQuGpTe9DiBl6hLnXYVhGRn b4BrgnDFyLVVA9WS53zZYWwmikE9pCFRycz74k5FMiRMl7zQwHU/DSoF1yeS9EkDc4+Cx+Dc4UQx wlnE0JlcR9E5tzsSFZzJwdTyuHuNxxAuNjrIeTe0hMZgkEFGmtPJK4j6h2Abi7d3yrXhSkRbNYrh JMJuWoZpiCKCCIkYBAHXivl4udejSoWSWwNdqXNtbZUMQ0kCICopAQ+NhQUs9coBaEBAnVOrzObg ppcid6BjnySBJy2jflDz8pxuDUlj70x6x5prLqSE7xKQlG4EGBJFDAnZdDDvz2jneOMKfiEhkTxI XczdCRIAnme6y11FQ6JL9TAbekRCOEBRUy/Ctl4lgRgQTjkFtgINQtyoHCA7lpqPwnKhhN71A7Wd dvh4cyl4RSBhq2FLCYJImb20G5Jh0DvzNLTaaM0XQOIIh5kdx+oQNRMYZ7PGoM+Wqqqqqqqqqqqq qrK4qYLg8pUEhvJ4D3es+fVc936kvkPUkY1sFpIqTMnx4Xe8fRKULmzQOJUnzTohz8AUPNPoPNCg +LyPMdjreaU2HPtIpwSLIIeZcW0ofF3LkTczORNrsW91mH0b7Yfd6M3Nx4G9kAs6MJCsKhZ3NYGu qCIciykOW0JJ2J3tkTJG84PB8QMuDxZ4vcDAMy0NgnZ2bYwyQzAlLU1yYiu8LjB0QwQuQl63uhBM WigwzDW7m45kPK82BFVLO7kVqySQCaEJcVATjJlCCxm2cKUiCso5JgnBKtqZJXt1d/D4vgwOo0gp G0U04giHiwDMULvNRAey733DM1xEEEAgSEguAnFfLSoNBtyyLuQGNSq0pdAJWujMMTYCigXmOpyk VY4NIqFD6BS8txBB2lg5iNkxond5pqfR26oyv0WFodNmKNvgrAgjQqCYIBMAMQqB9sUkHFt0FlCC 2DWXw3Wjwo8aClSxMBXAvBkMYCW8jxLzy6ClTB4lwZmwLHENZNFDVaZWCmltyQkEhQbubfipg1fW Ygg3gVMoWjqhMjYagQaCnACAiwQnunkrJilTYG4Mj6+xU27rI4ky95OJlvo7s926Bllo7t7Y8oL3 elK+XWQB6uxPzJyer7JwStdwbgMNoH1TOjM5mZ8v1TFClZAeGvscGxNJ5SE2nhsNvLla7ErbErXU NY8g0jD6vhkbJ1mQx5DQ2vlKzkhlStOb4ywx4fhmByb04IeXe3dk7ITtb1QtDFzpI7JRIsWxcx9i +g5mnBqcXohg48zKhgPy2p4ydQ2IQbNabjmnV9k2vuv2G9OqFw8vfo3uD4b3cNQ+Oi3ewHJa03pm X0TJlhJ0wLHF7Gxm8NyZUyodxqdrazvCSRBGoehqe4GBpSTxTK//F3JFOFCQmIIu2g== --=-=-= Content-Type: text/plain > I think we shouldn't rely on the assumption that all emacs inputs have > "emacs-" prefix Then, how to determine that a package is Emacs package? > , so I think > this procedure should check whether the input name begins with "emacs-" > before trying to remove this substring. >> + "-" version)) >> + name+version) >> + input))))) >> + (fold alist-delete (emacs-inputs inputs) '("emacs" "source"))) > > Since you already take only emacs inputs, is it really needed to remove > "emacs" and "source"? I mean emacs inputs do not contain "emacs" and > "source" anyway, right? emacs inputs contain "emacs-minimal" and "source". So we actually need to remove "emacs-minimal" instead "emacs". (emacs-inputs '(("emacs" . "/gnu/store/g1ldcr600kmdf2n1gsphk04hm30jr4bn-emacs-25.3") ("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-emacs-minimal-25.3") ("emacs-dash" . "/gnu/store/dn7mygbi0pm985lz6qc64fsaz9f8zmfi-emacs-dash-2.13.0") ("emacs-shut-up" . "/gnu/store/k0zddbwfwpdgj1ih2ypl50n09dfxhq1f-emacs-shut-up-0.3.2") ("emacs-undercover" . "/gnu/store/ypcyxb3wpqlnf962k8ygp5csr6cmi6w3-emacs-undercover-0.6.0") ("source" . "/gnu/store/gyxjrmhk4xqd8r78blxb92f9xc1z92fr-emacs-pos-tip-0.4.6.tar.gz"))) (("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-emacs-minimal-25.3") ("emacs-dash" . "/gnu/store/dn7mygbi0pm985lz6qc64fsaz9f8zmfi-emacs-dash-2.13.0") ("emacs-shut-up" . "/gnu/store/k0zddbwfwpdgj1ih2ypl50n09dfxhq1f-emacs-shut-up-0.3.2") ("emacs-undercover" . "/gnu/store/ypcyxb3wpqlnf962k8ygp5csr6cmi6w3-emacs-undercover-0.6.0") ("source" . "/gnu/store/gyxjrmhk4xqd8r78blxb92f9xc1z92fr-emacs-pos-tip-0.4.6.tar.gz")) Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo52H4ACgkQckbhHGm3 lWn5exAAzPKsSjsTpr6GAUSH772uDY5QzaDJjqe5BKap66JkFswNy4rVFT1ZN+iS mqvC05/nWe4QVRud3gb4fptssIV49iUT/Edsd7SEKW3gvf+1fumA9/iJDwIE2x5t a4fkP8bMpbVSelWoPEvVH1GNJoeRwq0Tb8jbG1lVeg1SzIdCT6AiJ9mVc3Zv8w1a 2jBMLLUqA27yXQsob6JuKVOn/98UHTQPZb5VzL9FRQ6CDGshR58XQCWzzvU2PMFc z/OBHTzDgV2xY+JWhZhrFsfU7doMOa+cEwpgUeFtqZ6eV5My+zGLCXfqfrpfEdv8 bowA+bZUDVALSeis2jZApkb7YRAOq1EqpZpkS9JU6EnuVj3PUno4sJGaXzqzyZa2 /4TsHqTO82P2m4vv1IYSB/zmvk96PdrKyFFQKQusNLKDhZpmDHAyFziojxRfuOmi A2hZZ8l1H9on//wk7Va6XKAKWBDX8Pji9adiSOKtoM1a891LoCGwh5eM3zRhG38v /u2S32L35UjC5MbtLZrERuJrmL2Rvf696PbLcm1oAcz9QR3pKQNRfF9x/5LuNQww 81djRF+EqHMEVgpUCu0dy2f/oimGL1PSiMS5zsDVzgzD9pmqn9uH/Xou/NKpgT4L df40asgV8BeuJl03cvdLlNmYyhISkp2iXGK/uraTNw/30C3L0nA= =KB90 -----END PGP SIGNATURE----- --==-=-=--