From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 30003@debbugs.gnu.org
Subject: [bug#30003] [PATCH 2/2] gnu: services: Add darkstat service.
Date: Sun, 07 Jan 2018 14:21:22 +0100 [thread overview]
Message-ID: <87o9m5rei5.fsf@gnu.org> (raw)
In-Reply-To: <20180106084523.29095-2-iyzsong@member.fsf.org> ("宋文武"'s message of "Sat, 6 Jan 2018 16:45:23 +0800")
Hello,
宋文武 <iyzsong@member.fsf.org> skribis:
> * gnu/services/monitoring.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Monitoring Services): Document it.
Nice!
I only have minor suggestions:
> +@subsubheading Darkstat Service
> +@cindex darkstat
> +@command{darkstat} is a packet sniffer that captures network traffic,
I think you can remove @command since you’re referring to the software,
not to the command.
> +@example
> +(service darkstat-service-type
> + (darkstat-configuration
> + (interface "eth0")))
This should be aligned to the right. Also perhaps s/eth0/eno1/ to match
common names.
> +@item @code{package} (default: @code{darstat})
^
Typo.
> +@item @code{bindaddr} (default: @code{"127.0.0.1"})
I’d prefer “address” or “listen-address” or “bind-address” (likewise in
the code.)
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2018-01-07 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 8:45 [bug#30002] [PATCH 1/2] gnu: Add darkstat 宋文武
2018-01-06 8:45 ` [bug#30003] [PATCH 2/2] gnu: services: Add darkstat service 宋文武
2018-01-07 13:21 ` Ludovic Courtès [this message]
2018-01-08 12:59 ` bug#30003: " 宋文武
2018-01-07 11:52 ` [bug#30002] [PATCH 1/2] gnu: Add darkstat Ludovic Courtès
2018-01-08 12:59 ` bug#30002: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9m5rei5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30003@debbugs.gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.