From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] gnu: linux-libre: Full retpoline support on x86
	[spectre mitigation]
Date: Sat, 27 Jan 2018 16:33:34 +0100
Message-ID: <87o9lf2u5t.fsf@gnu.org>
References: <87po648e2n.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1efSUA-0003pd-VT
	for guix-devel@gnu.org; Sat, 27 Jan 2018 10:33:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1efSU6-0004kM-1o
	for guix-devel@gnu.org; Sat, 27 Jan 2018 10:33:42 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:57672)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1efSU5-0004js-RH
	for guix-devel@gnu.org; Sat, 27 Jan 2018 10:33:37 -0500
In-Reply-To: <87po648e2n.fsf@netris.org> (Mark H. Weaver's message of "Sat, 20
	Jan 2018 15:34:08 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> Here are two patches that:
>
> * Add gcc-7.3.0-RC-20180117, which includes support for retpoline.
> * Use gcc-7.3 to build linux-libre on x86 systems.

With GCC 7.3.0 now out, I think you can go ahead.

> From 387a02c3f9e157bdf40b2b5ad0e53e5b209f3aa5 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Sat, 20 Jan 2018 15:15:19 -0500
> Subject: [PATCH 1/2] gnu: gcc: Add gcc 7.3.0-RC-20180117 [includes retpol=
ine
>  support].
>
> * gnu/packages/gcc.scm (gcc-7.3): New variable.

I think we can upgrade =E2=80=98gcc-7=E2=80=99 directly instead of introduc=
ing a new
=E2=80=98gcc-7.3=E2=80=99 variable.  Thoughts?

> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -283,6 +283,12 @@ for ARCH and optionally VARIANT, or #f if there is n=
o such configuration."
>         ("bc" ,bc)
>         ("openssl" ,openssl)
>         ("kmod" ,kmod)
> +       ,@(match (system->linux-architecture
> +                 (or (%current-target-system) (%current-system)))
> +           ((or "x86_64" "i386")
> +            `(("gcc" ,gcc-7.3)))

Perhaps add a comment that this is for the retpoline mitigation.

Otherwise LGTM, thank you!

Ludo=E2=80=99.