all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#30940] [PATCH] gnu: Add twitchy.
@ 2018-03-25 18:41 Oleg Pykhalov
  2018-03-26 18:06 ` Marius Bakke
  0 siblings, 1 reply; 3+ messages in thread
From: Oleg Pykhalov @ 2018-03-25 18:41 UTC (permalink / raw)
  To: 30940

* gnu/packages/video.scm (twitchy): New public variable.
---
 gnu/packages/video.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index f7f82df07..1d073f328 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1782,6 +1782,38 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
 (define-public livestreamer
   (deprecated-package "livestreamer" streamlink))
 
+(define-public twitchy
+  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
+    (package
+      (name "twitchy")
+      (version (git-version "3.2" "1" commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/BasioMeusPuga/twitchy.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))
+      (build-system python-build-system)
+      (arguments
+       '(#:phases
+         (modify-phases %standard-phases
+           (add-before 'check 'check-setup
+             (lambda _
+               (setenv "HOME" (getcwd)) ;Needs to write to ‘$HOME’.
+               #t)))))
+      (inputs
+       `(("python-requests" ,python-requests)
+         ("streamlink" ,streamlink)))
+      (home-page "https://github.com/BasioMeusPuga/twitchy")
+      (synopsis "Command-line interface for Twitch.tv")
+      (description
+       "This package provides a command-line interface for Twitch.tv")
+      (license license:gpl3+))))
+
 (define-public mlt
   (package
     (name "mlt")
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#30940] [PATCH] gnu: Add twitchy.
  2018-03-25 18:41 [bug#30940] [PATCH] gnu: Add twitchy Oleg Pykhalov
@ 2018-03-26 18:06 ` Marius Bakke
  2018-03-26 19:50   ` Oleg Pykhalov
  0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2018-03-26 18:06 UTC (permalink / raw)
  To: Oleg Pykhalov, 30940

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> * gnu/packages/video.scm (twitchy): New public variable.

[...]
  
> +(define-public twitchy
> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
> +    (package
> +      (name "twitchy")
> +      (version (git-version "3.2" "1" commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))

Can you add a comment about why a git checkout is necessary?

Apart from that LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#30940] [PATCH] gnu: Add twitchy.
  2018-03-26 18:06 ` Marius Bakke
@ 2018-03-26 19:50   ` Oleg Pykhalov
  0 siblings, 0 replies; 3+ messages in thread
From: Oleg Pykhalov @ 2018-03-26 19:50 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 30940, 30940-done

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> * gnu/packages/video.scm (twitchy): New public variable.
>
> [...]
>   
>> +(define-public twitchy
>> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
>> +    (package
>> +      (name "twitchy")
>> +      (version (git-version "3.2" "1" commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
>> +               (commit commit)))
>> +         (file-name (git-file-name name version))
>> +         (sha256
>> +          (base32
>> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))
>
> Can you add a comment about why a git checkout is necessary?

OK.  Thank you for a review.

Pushed as e5e5eb1fcf4c0aab10e2d6ed7fa34257a3c87e58

I'll close the bug report.

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-26 19:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-25 18:41 [bug#30940] [PATCH] gnu: Add twitchy Oleg Pykhalov
2018-03-26 18:06 ` Marius Bakke
2018-03-26 19:50   ` Oleg Pykhalov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.