From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdhxZ-0000wZ-Ti for guix-patches@gnu.org; Thu, 12 Jul 2018 16:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdhxW-0003HP-NT for guix-patches@gnu.org; Thu, 12 Jul 2018 16:13:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdhxW-0003Gy-H8 for guix-patches@gnu.org; Thu, 12 Jul 2018 16:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdhxW-0004qu-B3 for guix-patches@gnu.org; Thu, 12 Jul 2018 16:13:02 -0400 Subject: [bug#31999] [PATCH 2/7] gnu: Add ndctl. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180628213527.23318-1-ambrevar@gmail.com> References: <20180628213237.21625-1-ambrevar@gmail.com> <20180628213527.23318-1-ambrevar@gmail.com> Date: Thu, 12 Jul 2018 22:12:36 +0200 Message-ID: <87o9fc6wnf.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > * gnu/package/disk.scm (ndctl): New variable. [...] > + (native-inputs > + `(("asciidoc" ,asciidoc) > + ("automake" ,automake) > + ("autocont" ,autoconf) > + ("libtool" ,libtool) > + ("xmlto" ,xmlto) > + ("which" ,which) > + ("pkg-config" ,pkg-config) > + ("docbook-xsl" ,docbook-xsl) > + ("libxml2" ,libxml2) ; Required for offline docbook generation. > + ("bash-completion" ,bash-completion))) > + (inputs > + `(("json-c" ,json-c) > + ("eudev" ,eudev) > + ("util-linux" ,util-linux) > + ("kmod" ,kmod))) Nit-pick: please try to keep inputs sorted. In addition to cosmetics, it makes it easier to find out whether a particular input is present. > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (substitute* "autogen.sh" > + (("/bin/sh") (which "sh"))) > + (substitute* "git-version-gen" > + (("/bin/sh") (which "sh"))) > + (substitute* "git-version" > + (("/bin/bash") (which "bash"))) > + (invoke "sh" "autogen.sh")))) > + #:make-flags > + (let ((out (assoc-ref %outputs "out"))) > + (list (string-append "BASH_COMPLETION_DIR=" out > + "/share/bash-completion/completions"))))) > + (home-page "https://github.com/pmem/ndctl") > + (synopsis "Manage the non-volatile memory device sub-system in the Linux kernel") > + (description > + "Utility library for managing the libnvdimm (non-volatile memory device) > +sub-system in the Linux kernel.") > + (license license:lgpl2.1+))) Most of the source files say GPL version 2 (only), except for the library files which are LGPL2.1 only. So I think we need to list both. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltHtjQACgkQoqBt8qM6 VPpWGAf8DMF41/2yRhg18TUTq+kU540paBBDSvhsQUTXfnG1I1mOsJfckYlEhubU lF0zXn5KY1pZgMb2vN7KqtE6COZD3vb1tm7+Z62hTMqdoSTXkozrC25DVFHzlVpL vBbGcA+BZ0V6xxMrEEwqWgsFHML1FcG/FLNr0WqV0Go4MvQ7B/gw0wa9LNDu7T5q 3NnVSwgkEkbv5k1oWMyRBHozI4H6r8p6dtBs3yIjyGIXbp8SDzuiXSlp62ZK5pFA IRFct7AMum12MKgQwpLbTK+LZeNumbqpfzMzs+XG+bWkEMEBlhvOYVekCTwG1z94 NeGWRgaJ5ZWLEQJlO1MCsidjeTa+jw== =CPfy -----END PGP SIGNATURE----- --=-=-=--