From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fhsrV-0004j0-3o
	for guix-patches@gnu.org; Tue, 24 Jul 2018 04:40:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fhsrS-0005Qs-0K
	for guix-patches@gnu.org; Tue, 24 Jul 2018 04:40:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49552)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fhsrR-0005Qj-TD
	for guix-patches@gnu.org; Tue, 24 Jul 2018 04:40:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fhsrR-0001Dx-N6
	for guix-patches@gnu.org; Tue, 24 Jul 2018 04:40:01 -0400
Subject: [bug#32165] [PATCH] gnu: Add cdrkit-libre.
Resent-Message-ID: <handler.32165.B32165.15324215504642@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180715170748.4853-1-go.wigust@gmail.com>
Date: Tue, 24 Jul 2018 10:38:57 +0200
In-Reply-To: <20180715170748.4853-1-go.wigust@gmail.com> (Oleg Pykhalov's
	message of "Sun, 15 Jul 2018 20:07:48 +0300")
Message-ID: <87o9ex58pq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 32165@debbugs.gnu.org

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/packages/cdrom.scm (cdrkit-libre): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://repo.parabola.nu/other/cdrkit-libre/cdrkit-=
libre-"
> +                    version ".tar.gz"))

Like Nils I wonder: can you explain how it differs from cdrkit?  Could
we use upstream cdrkit + snippet/patches instead of taking the source
from Parabola=E2=80=99s repo?

> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("bzip2" ,bzip2)
> +       ("libcap" ,libcap)
> +       ("perl" ,perl)
> +       ("zlib" ,zlib)))

It may be that all of these should be =E2=80=98inputs=E2=80=99.  Could you =
check:

  guix gc --references $(guix build cdrkit-libre)

?  If they show up here, then =E2=80=98inputs=E2=80=99.

> +    (arguments
> +     `(#:tests? #f ;no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'old-cdrecord
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (with-directory-excursion (string-append (assoc-ref outputs=
 "out")
> +                                                      "/bin")
> +               (symlink "genisoimage" "mkisofs")
> +               (symlink "wodim" "cdrecord")))))))

Please return #t.

> +    (home-page "http://cdrkit.org/")

Like Nils wrote, is this the right URL?

> +    (synopsis "Portable command-line CD/DVD recorder software, mostly
> +compatible with cdrtools")

=E2=80=9CCommand-line CD/DVD recorder=E2=80=9D is enough IMO.

> +    (description "Cdrkit is a suite of programs for recording CDs and DV=
Ds,
> +blanking CD-RW media, creating ISO-9660 filesystem images, extracting au=
dio CD
> +data, and more.")

Here you can mention that it=E2=80=99s =E2=80=9Cmostly compatible =E2=80=A6=
=E2=80=9D.
Note: =E2=80=9Cfile system=E2=80=9D (two words).  :-)

Thanks,
Ludo=E2=80=99.