From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gF3y9-0003PD-CP
	for guix-patches@gnu.org; Tue, 23 Oct 2018 17:12:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gF3y8-00013f-2R
	for guix-patches@gnu.org; Tue, 23 Oct 2018 17:12:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34322)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gF3y6-00011a-PQ
	for guix-patches@gnu.org; Tue, 23 Oct 2018 17:12:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gF3y6-000361-H7
	for guix-patches@gnu.org; Tue, 23 Oct 2018 17:12:02 -0400
Subject: [bug#33079] [PATCH 01/34] gnu: ocaml: Update to 4.07.0.
Resent-Message-ID: <handler.33079.B33079.154032912111894@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181017223130.775b25fc@lepiller.eu>
	<20181017203442.7075-1-julien@lepiller.eu>
Date: Tue, 23 Oct 2018 23:11:36 +0200
In-Reply-To: <20181017203442.7075-1-julien@lepiller.eu> (Julien Lepiller's
	message of "Wed, 17 Oct 2018 22:34:09 +0200")
Message-ID: <87o9bkbc6v.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 33079@debbugs.gnu.org

Hello!

Julien Lepiller <julien@lepiller.eu> skribis:

> * gnu/packages/ocaml.scm (ocaml): Update to 4.07.0.
> (ocaml-4.02): New variable.

[...]

> -(define-public ocaml
> +(define-public ocaml-4.02

[...]

> +(define-public ocaml ocaml-4.07)

The patch LGTM.  However, in general I think we should arrange for
patches to be self-contained, such that packages build at any point in
the commit history.  If we do it this way (first upgrade ocaml, then
adjust packages that depend on it), we leave whole commit ranges where
packages fail to build.

Thus I would suggest squashing into one commit the ocaml upgrade and the
package adjustments that ensue (typically the =E2=80=9CFix =E2=80=A6=E2=80=
=9D commits.)  WDYT?

Also, do you think OCaml users typically need the =E2=80=9Cocaml4.02-=E2=80=
=9D packages?

I had a quick look at the other patches and they look innocuous, =E2=80=9Cu=
nless
otherwise stated.=E2=80=9D  ;-)

Thank you!

Ludo=E2=80=99.