From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZwAT-0007Dj-E5 for guix-patches@gnu.org; Thu, 20 Dec 2018 06:07:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZwAS-0008Cl-Ht for guix-patches@gnu.org; Thu, 20 Dec 2018 06:07:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZwAS-0008CR-4M for guix-patches@gnu.org; Thu, 20 Dec 2018 06:07:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZwAR-0004KC-SN for guix-patches@gnu.org; Thu, 20 Dec 2018 06:07:03 -0500 Subject: [bug#33549] [PATCH 6/6] services: monitoring: Add 'zabbix-front-end'. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20181129185042.6050-1-go.wigust@gmail.com> <20181129185042.6050-6-go.wigust@gmail.com> <87efadv8nq.fsf@gnu.org> <878t0lpe27.fsf@gmail.com> Date: Thu, 20 Dec 2018 12:06:08 +0100 In-Reply-To: <878t0lpe27.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 19 Dec 2018 21:27:28 +0300") Message-ID: <87o99gqwyn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 33549-done@debbugs.gnu.org Hi Oleg, Oleg Pykhalov skribis: > Ludovic Court=C3=A8s writes: > > [=E2=80=A6] > >>> +$DB['PASSWORD'] =3D '" (if (string-null? db-password) >>> + (if (string-null? db-secret-file) >>> + (display "Provide a `db-secret-file' \ >>> +or `db-password' field. >>> +" >>> + (current-error-port)) >>> + (string-trim-both >>> + (with-input-from-file db-secret-file >>> + read-string))) >>> + (begin >>> + (display " >>> +Hint: Consider use `db-secret-file' instead of `db-password' and unset >>> +`db-password' in `zabbix-front-end-configuration' for security. >>> +") >>> + db-password)) "'; >>> + >>> +// Schema name. Used for IBM DB2 and PostgreSQL. >>> +$DB['SCHEMA'] =3D ''; >>> + >>> +$ZBX_SERVER =3D '" zabbix-host "'; >>> +$ZBX_SERVER_PORT =3D '" (number->string zabbix-port) "'; >>> +$ZBX_SERVER_NAME =3D ''; >>> + >>> +$IMAGE_FORMAT_DEFAULT =3D IMAGE_FORMAT_PNG; >>> +")))) >> >> I saw these =E2=80=9Chints=E2=80=9D in the build log of Cuirass and that= got me curious. >> :-) > > Do you mean =E2=80=9Chints=E2=80=9D during =E2=80=98zabbix=E2=80=99 tests? Yes, in the output of the =E2=80=9Cevaluation=E2=80=9D of the =E2=80=98guix= -master=E2=80=99 jobset. >> Third, it would be nice to report source location info along with hints >> and errors. To do that, you could add an innate =E2=80=98location=E2=80= =99 field to >> as done for . Then, along >> with the &message condition above, you could raise an &error-location as >> is done in a few places. >> >> Does that make sense? > > Sure. I see innate location field in , but unfortunately I'm > not sure how to implement it, because we use define-configuration for > . So the implementation of that feature > may take a time. ;-) We could probably change =E2=80=98define-configuration=E2=80=99 to add a = =E2=80=98location=E2=80=99 field unconditionally. But yeah, we=E2=80=99ll see! Thanks, Ludo=E2=80=99.