From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaO9f-0006rE-P9
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:00:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaO9c-0002Td-Qh
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:00:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54485)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gaO9b-0002S2-2h
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:00:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaO9a-0000bp-OH
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:00:02 -0500
Subject: [bug#33770] [PATCH] gnu: Add nip2.
Resent-Message-ID: <handler.33770.B33770.15454115572262@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <cucr2eh1r1r.fsf@lprndn.info>
	<handler.33770.B.154496785312397.ack@debbugs.gnu.org>
	<cucy38puru6.fsf_-_@lprndn.info>
Date: Fri, 21 Dec 2018 17:59:04 +0100
In-Reply-To: <cucy38puru6.fsf_-_@lprndn.info> (L. p. R. n. d. n.'s message of
	"Sun, 16 Dec 2018 21:41:53 +0100")
Message-ID: <87o99eolyf.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: L p R n d n <guix@lprndn.info>
Cc: 33770@debbugs.gnu.org

Hello!

L  p R n  d n    <guix@lprndn.info> skribis:

>>>From e90b425484ed84b87333a168447a7128a53a8434 Mon Sep 17 00:00:00 2001
> From: Lprndn <guix@lprndn.info>
> Date: Wed, 5 Dec 2018 19:03:13 +0100
> Subject: [PATCH] gnu: Add nip2.
>
> * gnu/packages/image-processing.scm (nip2): New variable.

Could you run =E2=80=98guix lint=E2=80=99 on this package and address any i=
ssues it
reports?

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/libvips/nip2/releases/download/v"
> +             version "/nip2-" version ".tar.gz"))

We now try to avoid GitHub-generated tarballs and instead use
=E2=80=98git-fetch=E2=80=99 to retrieve software from GitHub.  Could you ma=
ke this
change?

> +    (arguments
> +     `(#:tests? #f))                    ;; tests need $HOME/.nip2-8.7.0

Could you try adding a phase that sets the =E2=80=9CHOME=E2=80=9D environme=
nt variable
right before the =E2=80=98check=E2=80=99 phase?  See for example =E2=80=98p=
ython-biopython=E2=80=99 on
how to do it.

> +    (home-page "https://github.com/libvips/nip2")
> +    (synopsis "A spreadsheet-like GUI for libvips")
> +    (description "nip2 is a GUI for the VIPS image processing library.
> +It's a little like a spreadsheet: you create a set of formula connecting=
 your
> +objects together, and on a change nip2 recalculates")
> +    (license license:gpl2)))

Source file headers contain the =E2=80=9Cor any later version=E2=80=9D word=
ing so it
should be =E2=80=98license:gpl2+=E2=80=99.

Apart from that it LGTM!

Thanks in advance,
Ludo=E2=80=99.