From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggsout.gnu.org ([209.51.188.92]:58301 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfvDf-0002Rx-3Y
	for guix-patches@gnu.org; Sat, 05 Jan 2019 18:19:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfvDa-00046M-6c
	for guix-patches@gnu.org; Sat, 05 Jan 2019 18:19:07 -0500
Received: from debbugsout.gnu.org ([209.51.188.43]:44167)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfvDa-00046H-3D
	for guix-patches@gnu.org; Sat, 05 Jan 2019 18:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfvDZ-0005Pu-OY
	for guix-patches@gnu.org; Sat, 05 Jan 2019 18:19:01 -0500
Subject: [bug#33801] import: github: Support source URIs that redirect to
	GitHub
Resent-Message-ID: <handler.33801.B33801.154673033820814@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <cu7imzpokxn.fsf@systemreboot.net> <87d0pxtciz.fsf@gnu.org>
	<cu7mup04rfp.fsf@systemreboot.net> <87woo4qxg7.fsf@gnu.org>
	<cu77eg44a9f.fsf@systemreboot.net> <87k1k4p3gl.fsf@gnu.org>
	<cu7h8f8b0vc.fsf@systemreboot.net> <cu77eg3awvc.fsf@systemreboot.net>
	<877eg2q56k.fsf@gnu.org> <cu7y38han6g.fsf@systemreboot.net>
Date: Sun, 06 Jan 2019 00:18:53 +0100
In-Reply-To: <cu7y38han6g.fsf@systemreboot.net> (Arun Isaac's message of "Sat,
	22 Dec 2018 15:38:39 +0530")
Message-ID: <87o98uzo9u.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33801@debbugs.gnu.org

Hello,

Arun Isaac <arunisaac@systemreboot.net> skribis:

>>>From de88021c9a73d28f11bc2e060098484bd414da62 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Fri, 21 Dec 2018 17:48:55 +0530
> Subject: [PATCH] guix: lint: Check for source URIs redirecting to GitHub.
>
> * guix/scripts/lint.scm (check-github-uri): New procedure.
> (%checkers): Add it.
> * doc/guix.texi (Invoking guix lint): Document it.
> * tests/lint.scm ("github-url", "github-url: one suggestion"): New tests.

I just realized that the warning also triggers when the URL is already a
github.com URL:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix lint -c github-uri stellarium
gnu/packages/astronomy.scm:135:12: stellarium@0.18.1: URL should be 'https:=
//github.com/Stellarium/stellarium/releases/download/v0.18.1/stellarium-0.1=
8.1.tar.gz'
--8<---------------cut here---------------end--------------->8---

I think that=E2=80=99s because the above URL redirects to
<https://github-production-release-asset-2e65be.s3.amazonaws.com/18719856/7=
aec3148-7d35-11e8-9ad9-0a369f8ccc41?X-Amz-Algorithm=3DAWS4-HMAC-SHA256&X-Am=
z-Credential=3DAKIAIWNJYAX4CSVEH53A%2F20190105%2Fus-east-1%2Fs3%2Faws4_requ=
est&X-Amz-Date=3D20190105T231113Z&X-Amz-Expires=3D300&X-Amz-Signature=3Dfc2=
594a6b3dbfd2e841317adaec1ca71482bf20f2c53e8eb7e7c343f950f74ce&X-Amz-SignedH=
eaders=3Dhost&actor_id=3D0&response-content-disposition=3Dattachment%3B%20f=
ilename%3Dstellarium-0.18.1.tar.gz&response-content-type=3Dapplication%2Foc=
tet-stream>.

Any idea how we could avoid that?

Thanks,
Ludo=E2=80=99.