From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:39034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glHXo-0003Qo-Jx
	for guix-patches@gnu.org; Sun, 20 Jan 2019 13:10:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glHXm-0006kp-SS
	for guix-patches@gnu.org; Sun, 20 Jan 2019 13:10:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39898)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1glHXm-0006kg-OU
	for guix-patches@gnu.org; Sun, 20 Jan 2019 13:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glHXm-0000Oe-I4
	for guix-patches@gnu.org; Sun, 20 Jan 2019 13:10:02 -0500
Subject: [bug#34086] [PATCH] Add StepMania
Resent-Message-ID: <handler.34086.B34086.15480077751474@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <875zuprduu.fsf@nicolasgoaziou.fr>
Date: Sun, 20 Jan 2019 19:09:26 +0100
In-Reply-To: <875zuprduu.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Tue, 15 Jan 2019 19:10:33 +0100")
Message-ID: <87o98bnquh.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 34086@debbugs.gnu.org

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Note that I had to remove all bundled songs due to a non-commercial
> clause, so it's not really usable right out of the box. I also had to
> package a dedicated FFmpeg package, since StepMania is very picky about
> it.

Apparently you also tried using ffmpeg=C2=A02.8, but that didn=E2=80=99t wo=
rk either?
Do you have an idea how different their own ffmpeg variant is?

>>>From bfefd4b4217d67f9628682cb76ce2b9015285612 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 11 Nov 2018 00:43:34 +0100
> Subject: [PATCH] gnu: Add stepmania.
>
> * gnu/packages/games.scm (ffmpeg-for-stepmania):
> (stepmania): New variables.

[...]

> +(define ffmpeg-for-stepmania
> +  (package
> +    (name "ffmpeg-for-stepmania")

Could you move to video.scm, inherit from =E2=80=98ffmpeg=E2=80=99, and arr=
ange to
reduce duplication as much as possible?

(Even better would be to avoid it altogether but I=E2=80=99m assuming it wo=
n=E2=80=99t
be that simple=E2=80=A6)

The rest LGTM, thanks!

Ludo=E2=80=99.