From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in
	master?
Date: Mon, 21 Jan 2019 09:33:24 +0100
Message-ID: <87o98apfzf.fsf@gmail.com>
References: <87lg6sejwa.fsf@gmail.com> <87sgzw5ylb.fsf@gmail.com>
	<87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com>
	<87lg5j6h00.fsf@gnu.org> <87pnuv26jv.fsf@gmail.com>
	<87efbb4xpt.fsf@gnu.org> <871s7bm8k5.fsf@gmail.com>
	<8736rl6049.fsf@gmail.com> <874lc15opg.fsf@gnu.org>
	<87r2f4smlk.fsf@gmail.com> <8736rk6ui1.fsf@gnu.org>
	<87d0qgt8ej.fsf@gmail.com> <871s5q1zyv.fsf@gnu.org>
	<874ladwudb.fsf@gmail.com> <87zhs0tq7s.fsf@gnu.org>
	<87va2ov15l.fsf@gmail.com> <87won4rvye.fsf@gnu.org>
	<87va2npt44.fsf@gmail.com> <87lg3jv33o.fsf@gnu.org>
	<8736po8qy0.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:44599)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1glV1b-0003ln-Gh
	for guix-devel@gnu.org; Mon, 21 Jan 2019 03:33:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1glV1a-00024Z-UG
	for guix-devel@gnu.org; Mon, 21 Jan 2019 03:33:43 -0500
In-reply-to: <8736po8qy0.fsf@ambrevar.xyz>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: Guix-devel <guix-devel@gnu.org>


Hey!

> I've had a quick go and I must say I like it a lot!  Great job, Mathieu!

Thanks Pierre :)

> - Add and extra warning before partitioning!  I did it wrong at first but I did
>   not expect the installer to proceed straight away, I thought I would have a
>   second chance at reviewing the changes before proceeding.
>
> - More generally, I like the idea of a two-stage process: first collect the
>   details from the user (without actually performing any change), then show a
>   summary of the changes, ask for confirmation and only then apply all the
>   changes in one go.

I added both of your suggestions to the "Installer" section of the TODO
file!

Thanks for your feedback,

Mathieu