From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33647)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i54zo-0008P2-RG
 for guix-patches@gnu.org; Tue, 03 Sep 2019 05:21:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i54zn-0002j6-PL
 for guix-patches@gnu.org; Tue, 03 Sep 2019 05:21:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:50491)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i54zn-0002j1-MA
 for guix-patches@gnu.org; Tue, 03 Sep 2019 05:21:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i54zl-0002Pr-U9
 for guix-patches@gnu.org; Tue, 03 Sep 2019 05:21:03 -0400
Subject: [bug#36352] [PATCH] gnu: Add solvespace.
Resent-Message-ID: <handler.36352.B36352.15675024049193@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org>
 <87v9ua96h9.fsf@gnu.org>
 <CAO=Do-y9429YgXeuPvC9gza+-J9QRhbRTAsEO_aoYpvpwwD-0A@mail.gmail.com>
Date: Tue, 03 Sep 2019 11:19:54 +0200
In-Reply-To: <CAO=Do-y9429YgXeuPvC9gza+-J9QRhbRTAsEO_aoYpvpwwD-0A@mail.gmail.com>
 (Myles English's message of "Tue, 3 Sep 2019 01:28:28 +0100")
Message-ID: <87o901ybwl.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Myles English <mylesenglish@gmail.com>
Cc: 36352@debbugs.gnu.org, Myles English <myles@tdma.co>

Hi Myles,

Myles English <mylesenglish@gmail.com> skribis:

> It looks as though a longawaited v3.0 release may be imminent, hence my
> delay in replying to your advice.  I'll wait another week or two before
> asking if it is going to drop 'soon'.  (I would have tried to justify my
> choice by referencing the unofficial Debian package, mentioned on the
> project's github page, using the master branch and calling itself v3.0.)

Sounds good!

>>> +         (uri (git-reference
>>
>>> +               (url "https://github.com/solvespace/solvespace.git")
>> >> +               (commit commit)
>> >> +               (recursive? #t)))
>> >
>> > Is =E2=80=98recursive?=E2=80=99 needed?  If it=E2=80=99s just for the =
bundled dependencies under
>> > extlib/ that are not used anyway, perhaps we can omit it?
>>
>
> Some of them are still used (sorry I can't check which ones just now).  I
> have trivially modified the build system so that if :recursive? is a list
> it only clones those submodules listed. I can find the patch later but its
> just a couple of lines.  If this is adopted should may be rename
> :recursive? or add another parameter?

At first sight I think I=E2=80=99d keep it simple and just keep =E2=80=98re=
cursive?=E2=80=99 as
it is.  After all, if that fetches too many submodules in this specific
case, that=E2=80=99s not the end of the world and we can always delete them
explicitly afterwards.  I think it=E2=80=99s quite unusual to need some but=
 not
all of the submodules.

Thanks,
Ludo=E2=80=99.