From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 36785@debbugs.gnu.org
Subject: bug#36785: Impossible to pull on foreign distro
Date: Wed, 18 Sep 2019 20:35:19 +0200 [thread overview]
Message-ID: <87o8zho3ko.fsf@elephly.net> (raw)
In-Reply-To: <87woe6fune.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Digging further, I fetched the source from
> <https://packages.ubuntu.com/bionic/sudo>, and boom! I found the
> culprit: it’s called ‘debian/patches/keep_home_by_default.patch’.
>
> --8<---------------cut here---------------start------------->8---
> Description: Set HOME in initial_keepenv_table
> Set HOME in initial_keepenv_table; without this, $HOME will never be
> preserved unless added to keep_env. There's appropriate logic to handle
> resetting the home for -H and -i options, so this is the only part that's
> missing.
> Author: Steve Langasek <steve.langasek@canonical.com>
> --- a/plugins/sudoers/env.c
> +++ b/plugins/sudoers/env.c
> @@ -189,6 +189,7 @@
> "COLORS",
> "DISPLAY",
> "DPKG_COLORS",
> + "HOME",
> "HOSTNAME",
> "KRB5CCNAME",
> "LS_COLORS",
> --8<---------------cut here---------------end--------------->8---
>
> (This patch is playing with fire IMO. If you’re an Ubuntu user,
> consider reporting a bug!)
Wow. Changing fundamental behaviour like that is bad.
> We could apply the patch I posted earlier, which simply disables profile
> migration when SUDO_USER is set. That won’t address the fact that root
> writes to the user’s ~/.cache, but there’s not much we can do here.
This sounds fine to me.
--
Ricardo
next prev parent reply other threads:[~2019-09-18 18:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 14:40 bug#36785: Impossible to pull on foreign distro Julien Lepiller
2019-07-25 23:03 ` Ludovic Courtès
2019-07-26 6:22 ` Julien Lepiller
2019-07-26 8:09 ` Ludovic Courtès
2019-09-17 22:03 ` Ludovic Courtès
2019-09-17 23:33 ` Gábor Boskovits
2019-09-18 8:48 ` Ludovic Courtès
2019-09-20 8:47 ` Maxim Cournoyer
2019-09-20 15:44 ` Ludovic Courtès
2019-09-21 12:31 ` Maxim Cournoyer
2019-09-23 8:29 ` Ludovic Courtès
2019-09-23 9:00 ` Gábor Boskovits
2019-09-23 12:48 ` Ludovic Courtès
2019-09-23 14:09 ` Maxim Cournoyer
2019-09-24 12:37 ` Ludovic Courtès
2019-09-27 15:23 ` Maxim Cournoyer
2019-09-28 17:49 ` Ludovic Courtès
2019-09-29 1:36 ` Maxim Cournoyer
2019-09-21 12:32 ` Maxim Cournoyer
2019-09-18 18:35 ` Ricardo Wurmus [this message]
2019-09-19 8:24 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8zho3ko.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=36785@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.