From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56753) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC0ma-0006lp-IE for guix-patches@gnu.org; Sun, 22 Sep 2019 08:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iC0mY-0004PL-IH for guix-patches@gnu.org; Sun, 22 Sep 2019 08:16:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iC0mY-0004Oi-1k for guix-patches@gnu.org; Sun, 22 Sep 2019 08:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iC0mX-0002e3-Pz for guix-patches@gnu.org; Sun, 22 Sep 2019 08:16:01 -0400 Subject: [bug#37412] [PATCH 2/2] services: Add the Guix Data Service. Resent-Message-ID: References: <20190915182127.10525-1-mail@cbaines.net> <20190915182127.10525-2-mail@cbaines.net> <87lfuofzi4.fsf@gnu.org> From: Christopher Baines In-reply-to: <87lfuofzi4.fsf@gnu.org> Date: Sun, 22 Sep 2019 13:15:42 +0100 Message-ID: <87o8zc4jdd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37412@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> +(define (guix-data-service-shepherd-services config) >> + (match config >> + (($ package user group >> + port host) > > Perhaps use =E2=80=98match-record=E2=80=99 here and elsewhere, to avoid m= istakes when > the record type changes. Yeah, I've switched a couple of the match statements across to match-record, but I've left one, as it has a couple of clauses. >> +(define %test-guix-data-service >> + (system-test >> + (name "guix-data-service") >> + (description "Connect to a running Guix Data Service.") >> + (value (run-guix-data-service-test)))) > > Nice. > > Could you add a bit to guix.texi, maybe under =E2=80=9CContinuous Integra= tion=E2=80=9D? > You don=E2=80=99t have to go into too much detail if you think some of the > configuration elements are subject to change. I forgot you mentioned the "Continuous Integration" section, so I actually added something under a new "Guix" section, but regardless, I've now sent some new patches, which includes some documentation. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl2HZe5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xf+9w/9FzPu+FWqxm4VBz2xUov+Fiy4BOcz8C8P83iIP49FhOviwZ04kYAF4D1m r9GkpzWZ9ATZyuTkZFF+WHpkJTNw+47kpF43IM0g8rDICYxhzmT/06519oEzAogV FrLUnmmvcvauIMao/4q2uVszOEfvC4blEkvsKyO9AyFxjrdox0sB47Exzy6LiG2O b94qotSYG5Gi1og6l2afSuNwkTl7HZ82ylOnZ4p7hIle9Lfq2Hkb2c+5//1LVof8 bMmkDJboa2w1egIH/3gYTP1+kXnWy6HLYFaUFh4l9b4TLwZ5DoevKdQBsv139qSp eOCCG5EUbTssdQaqvKt4NE4UVwXsBL4CUBuVGr+K7WBU2at1qFKq3+fr6SJFZfTv JLaeV2Mx07CXcROSm0B2eG6Ilo4whj4EWIF2ZW0J5gr5EJSBOvKoNu4W01yf2eO+ OkR9HyC8HWVwhGcYOUpXvkX4eCIstcwLE0Ye4VWKkBk5TsqW7KHzOWO2mGizNNcO qfsH9t/U/a4f/EIBCdKAYPL+Nu5ExH8TNbF0zHFD5+3nEiVPeBGjgiGAe/jTgEsl 29vh4Ww4Z6W3FOnqL3tqBmeHAiNp8zLFuU+UYL784cgsUCXuN0gV2IofEYzv1Gur ysroOkip+j8QmO3b0gU+roEbEhniLZYYaRdkj7fzmuRL/eu07FI= =45ss -----END PGP SIGNATURE----- --=-=-=--