From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54275)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iuoWt-0000CV-0W
 for guix-patches@gnu.org; Thu, 23 Jan 2020 21:17:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iuoWs-0008D3-1F
 for guix-patches@gnu.org; Thu, 23 Jan 2020 21:17:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47409)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iuoWr-0008Cv-ST
 for guix-patches@gnu.org; Thu, 23 Jan 2020 21:17:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iuoWr-00084A-PI
 for guix-patches@gnu.org; Thu, 23 Jan 2020 21:17:01 -0500
Subject: [bug#39155] [PATCH] gnu: tuxguitar: Build and install alsa plugin.
Resent-Message-ID: <handler.39155.D39155.157983217630946@debbugs.gnu.org>
References: <20200116194826.9330-1-mike.rosset@gmail.com>
 <87muada9xq.fsf@posteo.net>
From: Mike Rosset <mike.rosset@gmail.com>
In-reply-to: <87muada9xq.fsf@posteo.net>
Date: Thu, 23 Jan 2020 18:16:06 -0800
Message-ID: <87o8uteh09.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 39155-done@debbugs.gnu.org


>> ---
>>  gnu/packages/music.scm | 90 +++++++++++++++++++++++++++---------------
>>  1 file changed, 59 insertions(+), 31 deletions(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index ad369bd3a8..15594ab0ba 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -1746,60 +1746,86 @@ is subjective.")
>>      (arguments
>>       `(#:build-target "build"
>>         #:jdk ,icedtea-8
>> -       #:tests? #f                      ; no tests
>> +       #:tests? #f
>
> I left this comment in since it notes that TuxGuitar actually doesn't
> have a test suite, and that we haven't just disabled it for another reason.

Hello Kei,

Apologies for removing this comment. I had not thought of this when I
removed it, thanks for reviewing this and merging.

Mike