From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46055) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivzT9-0005TE-Ck for guix-patches@gnu.org; Mon, 27 Jan 2020 03:10:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivzT8-0003zs-7Y for guix-patches@gnu.org; Mon, 27 Jan 2020 03:10:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivzT8-0003zZ-3b for guix-patches@gnu.org; Mon, 27 Jan 2020 03:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivzT7-0005sQ-V5 for guix-patches@gnu.org; Mon, 27 Jan 2020 03:10:01 -0500 Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-Message-ID: References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> <87r1zmikj6.fsf@cbaines.net> <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> From: Christopher Baines In-reply-to: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> Date: Mon, 27 Jan 2020 08:09:48 +0000 Message-ID: <87o8upialv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jesse Gibbons Cc: Danny Milosavljevic , 39275@debbugs.gnu.org --=-=-= Content-Type: text/plain Jesse Gibbons writes: > On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote: >> Error verifying signature: Failed to execute gpg. >> Danny Milosavljevic writes: >> >> > Hi, >> > >> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". >> > >> > > It would be good to put something in the commit message about why >> > > this >> > > is happening, as it's not obvious to me at least. >> > >> > I disagree in general because I've seen before what that leads to: >> > Half the source code (the comments) end up in the commit messages >> > instead. >> > Eventually (because of some merge or something) those get lost, or >> > (because of a new commit) those get hidden. >> > Now someone is going to overlook it. >> >> I'm not suggesting documenting code in commit messages, just saying >> something about the motivation/intention with the change is useful. >> The >> message you suggest meets this criteria perfectly. >> >> > So I'd put documentation into comments, except when it's ephemeral >> > ("news"). >> > >> > Also, in the special case of Guix the reason why we add an input >> > later is >> > "we forgot to add it earlier and it was optional to the package and >> > thus the >> > package built" most of the time. So the commit message would >> > always be >> > "we forgot earlier". >> >> So I would say that "we forgot earlier" isn't a motivation, or >> descriptive of intent (although maybe it meets the "why this is >> happening" I mentioned earlier, but that was maybe poorly >> explained).. >> >> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and >> > nobody >> > noticed. >> > >> > We could have the subject say "Add MIDI support" because it >> > communicates more >> > clearly what this commit does for users. And that's the news :) >> >> Yeah, I think that's good. At least in the context I was looking at >> this, trying to review the change, knowing what the intent is allows >> me >> to check if that's been satisfied (trying to play some MIDI content >> with >> VLC before and after). >> >> Chris > > Sorry for not explaining the intention. Do you want me to send a new > patch mentioning the added MIDI support? Should I put that in the > commit title, or in a comment? Sending a new patch would be great. Adding something anywhere in the commit message is fine by me. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4umsxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xe6Vw/3UBcW3H6i1pLsnSrmqUYyJqcPi4cYF4RoI+MytogkvoWNAdocSyFwS26V /d486+3WVgTH+iBQjAeFGBBOWk4qaHPqhxbo5ri+xrrlcKH3G4Qm4t4okMai1Y4I uRcTAQ8ktZzOf0/f7p0pxopTBgf4Hh2no7N8Qa59jRieWc8QDzRr2sC/DPiyC9QE 0iurU4zJGG2NjHx5tUDt/5zuAlhR9HO74ZZHBQx7QPAoafmqJSAhex9pClMYjkEV irRJCKeI+ylbi+uXtg9LN9yX8HbG6TcFhgSRWp8FFva4i+bV737BQXlcE0sm7p87 5F7cUvE/c2BbbngTqpQ0mxmmz80C1iLvjHUS2iJTjsYXd4k7D5MwnyRIvEKh63Vp VQPSV0jq0WAwmdXOB816nTjejUZWwBQyJ1y3w4wM2bH2Oc1g0gCNpFhg7pka/Ewk 4yfSQB2OcN927XMRYniKZU5lQ1GdHY8iNO8IQVtFiMDthACMOqqNCYlJjT2pdWW6 PvzXC2ZxWd2ihdPlGZ0CNqHu6BsFkGqUEqanOKBib4mW4NqqobClB7G0qBlA2clr niGGbdct+W/GoaYocnN7cplW6B5cQmjrszRIDUPm6uYqYt1+U1vV994Oh2gxiPqV IMv1sK7RW+ksgHV+R88dbv92ByVx7aYJMfQoENlLLycjzqO8NQ== =yV0R -----END PGP SIGNATURE----- --=-=-=--