From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41733) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDaml-000516-55 for guix-patches@gnu.org; Sun, 15 Mar 2020 17:27:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDamj-0001bq-Vq for guix-patches@gnu.org; Sun, 15 Mar 2020 17:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDamj-0001Z6-QO for guix-patches@gnu.org; Sun, 15 Mar 2020 17:27:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDamj-0000hL-Km for guix-patches@gnu.org; Sun, 15 Mar 2020 17:27:01 -0400 Subject: [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo Resent-Message-ID: References: <160809722.12896.1580033265330@office.mailbox.org> <20200307151146.2581-1-sschott@mailbox.org> <20200315184728.GG5561@jasmine.lan> From: Christopher Baines In-reply-to: <20200315184728.GG5561@jasmine.lan> Date: Sun, 15 Mar 2020 21:26:46 +0000 Message-ID: <87o8sxcns9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: leo@famulari.name Cc: 39292@debbugs.gnu.org, Sebastian Schott --=-=-= Content-Type: text/plain Leo Famulari writes: > On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote: >> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable. > > Thanks for this patch series Sebastian! Overall it looks good... > > I only have one nitpick: > >> + ;; Skip the only failing test "test_parse_url" >> + (invoke "pytest" "-vv" "-k" "not test_parse_url") >> + #t))))) > > How does the test fail? We should add comments explaining why tests are > skipped, not just that they are fail so we skip them :) I did see this when reviewing the patches, but I didn't think to look at it like this. It's the proper question to ask though. Out of interest, I built the package without skipping that test, and that failure looks related to the test trying to access the network, so disabling it is probably justified. > And while you are adding that comment or fixing the test, can you rebase > the patches on the current master branch? They no longer apply due to > other changes in python-xyz.scm. If you have an up to date copy of master, this could be because I merged the patches a few hours ago. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl5unZZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XedCA/+MUC/IRAycvejXz5WIjtbqJm9HjdP2782lX5JZ22i1qbR5ohmnfD1I7dX sKEw0seckn9JG3bsUrfAii4m0msw+SEUOtiy/GB7hxzLVFVIl4bsfA4cOs4e3E0Q 9awk90NcJDTn87IHFkUgsCzkKCT4xPVt7DMMupd5qM+XUuG3bgBWu5QnTc+8i97Q WyNgSgfO4lF7ZM0H0XOYaGlNMkdDNASsgs3ahOvjp4GBOTFnIRQHFtePrwTb8JDK iX7OSnkbiqJFwEug3XAyO1v5Dv9xYp/PpZ8xbhtkXixvwKluZil3PGUOJtJP0SwG WMvWoGxIss/jz/Fftd4amzVJFEUM+bUYdpl6TJiZw3mEn9xHdIa1dK2WCEeiAHzs HxgLwgCL2YotiTFQ42p0sefEsU3sh/tC7e4vQJyJxGeWOAhqJz1MWbTrPCef8dvc 6fjHp6vXl2WnnjG7TIQrT2eyCoYa6u/8T+RVDXjCsEQJP6+TLDVT215VkbWKB9df 7Z+bZ2ItqrVIXXWFj78BWtPI+2rcBxi9wn76ZxpDimJN6X24STUxUuKj/Qi4hy61 lKS1wVldQHV3j/w1c8x0Jaq8Ezra70C5Ki/uezwZ66pVX1Mx5R3EZrXZhsmg3CKF GIRkmD/6c/VIVWTSz/KryX9+LGKtHYgXCF3eGVs7aeckXaS9ip8= =1dEr -----END PGP SIGNATURE----- --=-=-=--