From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KWL+GPzU+V7uOwAA0tVLHw (envelope-from ) for ; Mon, 29 Jun 2020 11:48:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id INS/FPzU+V5NIQAAbx9fmQ (envelope-from ) for ; Mon, 29 Jun 2020 11:48:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA8F39403CB for ; Mon, 29 Jun 2020 11:48:11 +0000 (UTC) Received: from localhost ([::1]:52252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpsGf-0005W6-CP for larch@yhetil.org; Mon, 29 Jun 2020 07:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpsGY-0005Ue-A4 for guix-patches@gnu.org; Mon, 29 Jun 2020 07:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpsGY-0006Ms-14 for guix-patches@gnu.org; Mon, 29 Jun 2020 07:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpsGX-0006bF-Tk for guix-patches@gnu.org; Mon, 29 Jun 2020 07:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Jun 2020 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42030 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42030@debbugs.gnu.org Received: via spool by 42030-submit@debbugs.gnu.org id=B42030.159343128025360 (code B ref 42030); Mon, 29 Jun 2020 11:48:01 +0000 Received: (at 42030) by debbugs.gnu.org; 29 Jun 2020 11:48:00 +0000 Received: from localhost ([127.0.0.1]:48183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpsGW-0006ay-H4 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 07:48:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpsGT-0006ai-Ku for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 07:47:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpsGO-0006Gd-Ay; Mon, 29 Jun 2020 07:47:52 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:41002 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpsGM-0001hH-UG; Mon, 29 Jun 2020 07:47:51 -0400 From: Marius Bakke In-Reply-To: <87r1u3trx8.fsf@gnu.org> References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> Date: Mon, 29 Jun 2020 13:47:48 +0200 Message-ID: <87o8p2ayaj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: Q71jFXyGAdsb --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! Sorry for the late reply. Ludovic Court=C3=A8s writes: >> I think we should export %guix-channel-introduction, or alternatively >> add a %default-guix-channel that can be inherited, for easy access in >> custom channels.scm files. WDYT? > > The idea was to expose only =E2=80=98%default-channels=E2=80=99, which le= aves room for > the possibility of having multiple channels by default. I=E2=80=99d rath= er > avoid exposing the individual bits as that=E2=80=99s a bit of an addition= al > committment. > > But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix cha= nnel is > automatically added anyway (commit > c3f6f564e909ebefe752d24b325871a4e3a02d40). It is only added for people using the default channel URL, and not for local mirrors that may well be authenticated. E.g. (url "/some/dir") or (url "https://github.com/guix-mirror/guix"). Would it make sense to remove the %default-channel-url check from ensure-default-introductions? I think we can safely assume that a channel named 'guix is _the_ Guix channel regardless of where it came from, and if users need to override the introduction they can just do that. Currently I do this to access the channel introduction, which seems needlessly complicated: =2D-8<---------------cut here---------------start------------->8--- (use-modules (srfi srfi-1)) (let ((guix-channel (find (lambda (channel) (eq? 'guix (channel-name channel))) %default-channels))) (list [other channels omitted] (channel (inherit guix-channel) (url "/home/marius/src/guix")))) =2D-8<---------------cut here---------------end--------------->8--- --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl751OQACgkQoqBt8qM6 VPoNGwf9FZQX5ao1Vaw389waMK6k1MS+D0Xul+QSEROrPuzOp1gsIP0oXDamkGR4 Fj+ycbAyBsnyVhH8rb34iTEvRaDDQRAwdzuji/stSoGhs7BfiwiVFyjLlIyK1uFQ 3a9WPRz9ZV+4cSPn1FQRNYJ5lZcz0a+5QzwjUBjnMM0YP5q56RcEWERsqxDt/xho T0d8YTZPy1NEymISSG4CKPCCwU2ZfmimNNRBoT098h/uQOyZGEYYu/Gj03/oJmo0 jczK44Q4b6wEmzuTGUg11cA091GEbG2cHlkknZTQ98tBt41cSV963RN4dQ69x03u gVXoPJLvvP3oGLojQJlUttS4ECyYmA== =V1uG -----END PGP SIGNATURE----- --=-=-=--