From: Brett Gilio <brettg@gnu.org>
To: Jack Hill <jackhill@jackhill.us>
Cc: 42736@debbugs.gnu.org
Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5.
Date: Fri, 07 Aug 2020 21:27:58 -0500 [thread overview]
Message-ID: <87o8nlc1n5.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2008072148480.4809@marsh.hcoop.net> (Jack Hill's message of "Fri, 7 Aug 2020 22:09:39 -0400 (EDT)")
Jack Hill <jackhill@jackhill.us> writes:
>>> On Thu, 6 Aug 2020, Brett Gilio wrote:
>>>
>>>>
>>>> Hey Jack,
>>>>
>>>> Thanks for taking time to revise this package. When I originally wrote
>>>> it I made notice to the fact that some elisp bytecompilations were
>>>> failing or not behaving appropriately. Since then I am pretty sure
>>>> hlissner has disabled the bytecompilation completely? Could you review
>>>> this for me, and if true please revise the appropriate arguments. If you
>>>> aren't sure what I am talking about, please let me know.
>
> Brett,
>
> I think the way forward is to follow upstream's choices and not enable
> or disable byte compilation in Guix.
>
> After upstream introduced commit 9cd6872 [0], our trick to selectively
> leave batch compilation enabled for some files didn't work because
> they already had `-*- no-byte-compile: t; -*-` at the top of the
> file. In my testing, I added a phase to substitute this away. Indeed,
> this allowed our trick to work again. However, the material, snazzy,
> and tomorrow-day themes now have problems with byte compilation.
>
> Therefore, I removed the disable-breaking-compilation phase
> entirely. With it removed, doom-themes-autoloads.el,
> doom-themes-base.el, doom-themes.el, doom-themes-ext-org.el, and
> doom-themes-ext-visual-bell.el do get byte compiled. From this
> evidence I concluded that upstream is aware of this issue and is only
> disabling byte compilation where necessary.
>
> I'll send a version 2 of the patch with the phase removed shortly.
>
> [0] https://github.com/hlissner/emacs-doom-themes/commit/9cd6872b1af88165834230abd45743036861f925
>
> Best,
> Jack
Jack,
Thank you for investigating this issue. I agree with your solution, and
I will apply your patch removing the phase.
Brett
next prev parent reply other threads:[~2020-08-08 2:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 3:17 [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5 Jack Hill
2020-08-07 3:37 ` Brett Gilio
2020-08-07 4:28 ` Jack Hill
2020-08-07 18:10 ` Brett Gilio
2020-08-08 2:09 ` Jack Hill
2020-08-08 2:27 ` Brett Gilio [this message]
2020-08-08 2:40 ` Jack Hill
2020-08-08 2:11 ` [bug#42736] [PATCH v2] " Jack Hill
2020-08-08 2:29 ` bug#42736: " Brett Gilio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8nlc1n5.fsf@gnu.org \
--to=brettg@gnu.org \
--cc=42736@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.