From: Marius Bakke <marius@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>,
Ricardo Wurmus <rekado@elephly.net>
Cc: 43539@debbugs.gnu.org
Subject: [bug#43539] [PATCH] gnu: vim: Automatically find vim plugins.
Date: Fri, 25 Sep 2020 19:48:34 +0200 [thread overview]
Message-ID: <87o8lt4uj1.fsf@gnu.org> (raw)
In-Reply-To: <20200922093734.GF1007@E5400>
[-- Attachment #1: Type: text/plain, Size: 3369 bytes --]
Efraim Flashner <efraim@flashner.co.il> writes:
> On Sun, Sep 20, 2020 at 11:57:58PM +0300, Efraim Flashner wrote:
>> On Sun, Sep 20, 2020 at 09:50:12PM +0200, Ricardo Wurmus wrote:
>> >
>> > Efraim Flashner <efraim@flashner.co.il> writes:
>> >
>> > > On Sun, Sep 20, 2020 at 09:29:27PM +0200, Ricardo Wurmus wrote:
>> > >>
>> > >> Efraim Flashner <efraim@flashner.co.il> writes:
>> > >>
>> > >> > diff --git a/gnu/packages/aux-files/guix.vim b/gnu/packages/aux-files/guix.vim
>> > >> > new file mode 100644
>> > >> > index 0000000000..ca97f451d8
>> > >> > --- /dev/null
>> > >> > +++ b/gnu/packages/aux-files/guix.vim
>> > >> > @@ -0,0 +1,7 @@
>> > >> > +" This appends all of the vim plugins to the end of Vim's runtimepath.
>> > >> > +for directory in ["/run/current-system/profile", $HOME . "/.guix-profile", $GUIX_ENVIRONMENT]
>> > >>
>> > >> How about using $GUIX_PROFILE as well or instead of $HOME/.guix-profile?
>> > >> This would allow users to keep a separate profile for Vim things.
>> > >
>> > > That was the one part I didn't really like about my patch. Unfortunately
>> > > I don't seem to have $GUIX_PROFILE set on my machine.
>> > >
>> > > (ins)efraim@E5400 ~$ echo $GUIX_PROFILE
>> > >
>> > > (ins)efraim@E5400 ~$
>> >
>> > Me neither! But when loading profiles we suggest this approach:
>> >
>> > export GUIX_PROFILE=/the/location/of/the/.guix-profile
>> > source $GUIX_PROFILE/etc/profile
>> >
>> > The variable is set in that case, because that affects whether absolute
>> > store file names are used or the symlink
>> > “/the/location/of/the/.guix-profile”.
>>
>> It seems to be the case for the default profile. And in Guix System. I
>> could also just add $GUIX_PROFILE as another location in the list of
>> directories to search.
>
> The more I think about it the more I see $HOME/.guix-profile as a
> "special profile" which is nearly always included in $PATH and other
> variables, similar to /run/current-system/profile. With that in mind I
> like the attached patch which keeps that path but adds a search for
> $GUIX_PROFILE.
>
> I could use environment variables to override vim's builtin search for
> $VIM and $VIMRUNTIME, but then we would have to decide to support vim
> installed by the user or system-wide.
So vim only expects a single vimfiles directory in those variables?
[...]
> +++ b/gnu/packages/aux-files/guix.vim
> @@ -0,0 +1,7 @@
> +" This appends all of the vim plugins to the end of Vim's runtimepath.
> +for directory in ["/run/current-system/profile", $HOME . "/.guix-profile", $GUIX_PROFILE, $GUIX_ENVIRONMENT]
> + let vimplugins = directory . "/share/vim/vimfiles"
> + if isdirectory(vimplugins)
> + let &rtp = join([&rtp,vimplugins], ',')
> + endif
> +endfor
I wonder if we could generalize this to a proper search path with
something like (pseudo code):
for directory in getenv("VIM_PLUGIN_PATH").split(":")
let vimplugins = directory . "share/vim/vimfiles"
...
And then in the vim package:
(native-search-paths
(list
(search-path-specification
(variable "VIM_PLUGIN_PATH")
(files '("share/vim/vimfiles")))))
...which makes Guix populate VIM_PLUGIN_PATH automatically as plugins
are added to a profile/environment (as long as it contains the 'vim'
package).
WDYT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-09-25 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 19:15 [bug#43539] [PATCH] gnu: vim: Automatically find vim plugins Efraim Flashner
2020-09-20 19:29 ` Ricardo Wurmus
2020-09-20 19:32 ` Efraim Flashner
2020-09-20 19:50 ` Ricardo Wurmus
2020-09-20 20:57 ` Efraim Flashner
2020-09-22 9:37 ` Efraim Flashner
2020-09-25 17:48 ` Marius Bakke [this message]
2020-09-27 8:49 ` Efraim Flashner
2020-09-27 9:41 ` Efraim Flashner
2020-12-20 11:10 ` bug#43539: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8lt4uj1.fsf@gnu.org \
--to=marius@gnu.org \
--cc=43539@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.