From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GFlQOf/myF8JXwAA0tVLHw (envelope-from ) for ; Thu, 03 Dec 2020 13:24:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qD4qNf/myF+BagAA1q6Kng (envelope-from ) for ; Thu, 03 Dec 2020 13:24:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53ED89404C9 for ; Thu, 3 Dec 2020 13:24:15 +0000 (UTC) Received: from localhost ([::1]:50010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkoaj-0007iN-H5 for larch@yhetil.org; Thu, 03 Dec 2020 08:24:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkoaY-0007hN-Pu for bug-guix@gnu.org; Thu, 03 Dec 2020 08:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkoaY-000237-IX for bug-guix@gnu.org; Thu, 03 Dec 2020 08:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kkoaY-0007JE-EN for bug-guix@gnu.org; Thu, 03 Dec 2020 08:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44835: gnu/ci.go: Embeds build path, breaking reproducible builds Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 03 Dec 2020 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44835 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 44835-submit@debbugs.gnu.org id=B44835.160700184228094 (code B ref 44835); Thu, 03 Dec 2020 13:24:02 +0000 Received: (at 44835) by debbugs.gnu.org; 3 Dec 2020 13:24:02 +0000 Received: from localhost ([127.0.0.1]:38947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkoaX-0007J0-If for submit@debbugs.gnu.org; Thu, 03 Dec 2020 08:24:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkoaW-0007Im-9o for 44835@debbugs.gnu.org; Thu, 03 Dec 2020 08:24:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43264) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkoaQ-0001zo-LI; Thu, 03 Dec 2020 08:23:54 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50062 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkoaP-0006Ef-TZ; Thu, 03 Dec 2020 08:23:54 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r1ojgzdh.fsf@yucca> <87blfj23yb.fsf@gnu.org> <87wny13lub.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Frimaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 03 Dec 2020 14:23:52 +0100 In-Reply-To: <87wny13lub.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 01 Dec 2020 10:41:00 +0100") Message-ID: <87o8jbdnvb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44835@debbugs.gnu.org, Vagrant Cascadian Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.78 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 53ED89404C9 X-Spam-Score: -2.78 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: HKQ7HqUTovVU Hi, Mathieu Othacehe skribis: >> =E2=80=A6 but I don=E2=80=99t think we can assume that the checkout is i= n the >> =E2=80=98%load-path=E2=80=99 when this code is executed. WDYT, Mathieu? > > Cuirass happens to add checkouts to the %load-path just before loading > this file. Is that systematic? Isn=E2=80=99t it only when =E2=80=98load_path_inputs= =E2=80=99 is non-empty? > I tested your path, it works fine. I think it is acceptable as this (gnu > ci) interface needs a big rework anyway. > > I can apply your patch if it's ok for you. Sure if you=E2=80=99re confident you can go ahead. :-) Thanks, Ludo=E2=80=99.