From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aDYGKf418l/FDAAA0tVLHw (envelope-from ) for ; Sun, 03 Jan 2021 21:24:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uDz/JP418l9WcwAAB5/wlQ (envelope-from ) for ; Sun, 03 Jan 2021 21:24:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 67DE894038E for ; Sun, 3 Jan 2021 21:24:14 +0000 (UTC) Received: from localhost ([::1]:45914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwArF-00007F-DH for larch@yhetil.org; Sun, 03 Jan 2021 16:24:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwAmE-0003G7-Id for guix-patches@gnu.org; Sun, 03 Jan 2021 16:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwAmE-0006Eo-2c for guix-patches@gnu.org; Sun, 03 Jan 2021 16:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwAmD-0006cU-TM for guix-patches@gnu.org; Sun, 03 Jan 2021 16:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 1/1] gnu: Add pinentry-rofi. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Jan 2021 21:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.160970869125385 (code B ref 45190); Sun, 03 Jan 2021 21:19:01 +0000 Received: (at 45190) by debbugs.gnu.org; 3 Jan 2021 21:18:11 +0000 Received: from localhost ([127.0.0.1]:38718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwAlO-0006bM-S1 for submit@debbugs.gnu.org; Sun, 03 Jan 2021 16:18:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwAlN-0006b5-6p for 45190@debbugs.gnu.org; Sun, 03 Jan 2021 16:18:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49700) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwAlH-0005w6-9L; Sun, 03 Jan 2021 16:18:03 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33848 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwAlG-0005uQ-KT; Sun, 03 Jan 2021 16:18:03 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> Date: Sun, 03 Jan 2021 22:18:01 +0100 In-Reply-To: <20201212023103.79992-1-plattfot@posteo.net> (Fredrik Salomonsson's message of "Fri, 11 Dec 2020 18:31:03 -0800") Message-ID: <87o8i5zpme.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45190@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 67DE894038E X-Spam-Score: -2.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: hDbfUS5UnmgX Hi Fredrik, Fredrik Salomonsson skribis: > * gnu/packages/gnupg.scm (pinentry-rofi): New variable. Overall LGTM, with some minor issues highlighted below: > +(define-public pinentry-rofi > + (package > + (name "pinentry-rofi") Indentation is off here (should be offset by two). > + (arguments > + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is fai= ling Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure this i= s necessary? > + #:phases > + (modify-phases > + %standard-phases > + (add-after > + 'install > + 'hall-wrap-binaries Nitpick: please indent as in other files. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((compiled-dir > + (lambda (out version) > + (string-append out "/lib/guile/" version "/site-c= cache"))) > + (uncompiled-dir > + (lambda (out version) > + (string-append > + out > + "/share/guile/site" > + (if (string-null? version) "" "/") > + version))) > + (dep-path > + (lambda (env modules path) > + (list env > + ":" > + 'prefix > + (cons modules > + (map (lambda (input) > + (string-append > + (assoc-ref inputs input) > + path)) > + ,''("rofi")))))) > + (out (assoc-ref outputs "out")) > + (bin (string-append out "/bin/")) > + (site (uncompiled-dir out ""))) > + (match (scandir site) > + (("." ".." version) > + (for-each > + (lambda (file) > + (wrap-program > + (string-append bin file) > + (dep-path > + "GUILE_LOAD_PATH" > + (uncompiled-dir out version) > + (uncompiled-dir "" version)) > + (dep-path > + "GUILE_LOAD_COMPILED_PATH" > + (compiled-dir out version) > + (compiled-dir "" version)))) > + ,''("pinentry-rofi")) > + #t)))))))) Since I think you=E2=80=99re also upstream :-), how about adding something = like that at the top of the installed executable: (eval-when (load expand eval) (set! %load-path (cons "@moddir@" %load-path)) (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) ? > + (propagated-inputs `(("rofi" ,rofi))) It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2=80= =9Crofi=E2=80=9D string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80=A6/= bin/rofi=E2=80=9D in a post-install phase? > + (synopsis "Rofi GUI for GnuPG's passphrase input") > + (description "Simple pinentry GUI using rofi that allows users to ente= r a > +passphrase when required by @code{gpg} or other software.") Please make it a full sentence. Also, to give context, perhaps replace =E2=80=9Crofi=E2=80=9D by =E2=80=9Cthe Rofi application launcher=E2=80=9D. Could you send an updated patch? Thanks in advance and sorry for the delay! Ludo=E2=80=99.