From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 48233-done@debbugs.gnu.org
Subject: bug#48233: [PATCH 1/3] guix-install.sh: Please the shellcheck linter.
Date: Wed, 05 May 2021 11:00:42 -0400 [thread overview]
Message-ID: <87o8dpjkdh.fsf@gmail.com> (raw)
In-Reply-To: <2F845AA8-1309-4834-92FE-BBFFB0197093@lepiller.eu> (Julien Lepiller's message of "Wed, 05 May 2021 06:50:09 -0400")
Hi Julien,
Julien Lepiller <julien@lepiller.eu> writes:
> Le 5 mai 2021 00:32:00 GMT-04:00, Maxim Cournoyer <maxim.cournoyer@gmail.com> a écrit :
>>
>> wget --help | grep -q '\--show-progress' && \
>> _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
>>- wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz"
>>"${url}/${bin_ver}.tar.xz.sig"
>>
>>- if [[ "$?" -eq 0 ]]; then
>>- _msg "${PAS}download completed."
>>+ if wget "$_PROGRESS_OPT" -P "$dl_path" \
>>+ "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig";
>
> "$_PROGRESS_OPT" gets expanded to a single "-q --show-progress", which I doubt exists in wget :). The previous version didn't have quotes.
Good catch! I failed to see that in my testing due to using the
GUIX_RELEASE_FILE_NAME trick, which shortcuts that procedure.
I've fixed it with an array:
--8<---------------cut here---------------start------------->8---
1 file changed, 4 insertions(+), 3 deletions(-)
etc/guix-install.sh | 7 ++++---
modified etc/guix-install.sh
@@ -266,15 +266,16 @@ guix_get_bin()
local url="$1"
local bin_ver="$2"
local dl_path="$3"
+ local wget_args=()
_debug "--- [ ${FUNCNAME[0]} ] ---"
_msg "${INF}Downloading Guix release archive"
- wget --help | grep -q '\--show-progress' && \
- _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
+ wget --help | grep -q '\--show-progress' \
+ && wget_args=("-q" "--show-progress")
- if wget "$_PROGRESS_OPT" -P "$dl_path" \
+ if wget "${wget_args[@]}" -P "$dl_path" \
"${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig"; then
_msg "${PAS}download completed."
else
--8<---------------cut here---------------end--------------->8---
And in another VM (RHEL8) with up-to-date certs to be able to fetch from
the alpha.gnu.org :-). The install went fine.
Pushed, thank you!
Maxim
prev parent reply other threads:[~2021-05-05 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 4:10 [bug#48233] [PATCH 0/3] Modest improvements to the guix-install.sh script Maxim Cournoyer
2021-05-05 4:32 ` [bug#48233] [PATCH 1/3] guix-install.sh: Please the shellcheck linter Maxim Cournoyer
2021-05-05 4:32 ` [bug#48233] [PATCH 2/3] guix-install.sh: Propose automatically fetching OpenPGP keys Maxim Cournoyer
2021-05-05 4:32 ` [bug#48233] [PATCH 3/3] guix-install.sh: Exit early if Guix is already installed Maxim Cournoyer
2021-05-05 10:50 ` [bug#48233] [PATCH 1/3] guix-install.sh: Please the shellcheck linter Julien Lepiller
2021-05-05 15:00 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8dpjkdh.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=48233-done@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.