From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UFENHUYBB2FhmAAAgWs5BA (envelope-from ) for ; Sun, 01 Aug 2021 22:17:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +FIQGEYBB2GaIwAAbx9fmQ (envelope-from ) for ; Sun, 01 Aug 2021 20:17:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2DD018308 for ; Sun, 1 Aug 2021 22:17:09 +0200 (CEST) Received: from localhost ([::1]:37926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAHtU-0007Nv-P9 for larch@yhetil.org; Sun, 01 Aug 2021 16:17:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAHtO-0007NO-SB for guix-patches@gnu.org; Sun, 01 Aug 2021 16:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAHtO-0007BD-K7 for guix-patches@gnu.org; Sun, 01 Aug 2021 16:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mAHtO-0004NT-8r for guix-patches@gnu.org; Sun, 01 Aug 2021 16:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49494] [PATCH 0/7] Add nncp Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 01 Aug 2021 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49494@debbugs.gnu.org Received: via spool by 49494-submit@debbugs.gnu.org id=B49494.162784899316781 (code B ref 49494); Sun, 01 Aug 2021 20:17:02 +0000 Received: (at 49494) by debbugs.gnu.org; 1 Aug 2021 20:16:33 +0000 Received: from localhost ([127.0.0.1]:36985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAHsv-0004Ma-2e for submit@debbugs.gnu.org; Sun, 01 Aug 2021 16:16:33 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAHsr-0004MP-PS for 49494@debbugs.gnu.org; Sun, 01 Aug 2021 16:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h2nx4wBi1tGrmhvrZKRR/eTkwony8lOmhL7DVZwTjCE=; b=STupT88yGYglutT8MLlxlyZ93G kl1WjUhepOe2BwoyPbu7uaKpFXpGln2ko99I9MM0Asyvi1V+lLDXxW0TD75mZr3dA+J76G6mAizw/ LnBzxFVWeZS/Zso8Euvlbq8fCYkmUJQYWVWZMV4QafuNSyGVByXwa5PWFT7oxckVN5+wb+KlCtazM 7WhDoHDB/tCZ3VdmKATCCZBi2/+hZoeYePo0D/lwe+t1T/QvJkOsVaMqD+zfwdxQi02CzZGEw6Md/ xC1/K5n1y9LoGMvCHHB+AI3P18uTtS4x+vduFT6F5fdml07PFOuluQMbG4nPOabTaJRZG0QI2OlZO rCaGTPJQ==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAHso-0003CD-Cf; Mon, 02 Aug 2021 01:46:26 +0530 From: Arun Isaac In-Reply-To: <86wnphrfhr.fsf_-_@mgsn.dev> References: <20210709161940.12759-1-arunisaac@systemreboot.net> <20210709161940.12759-7-arunisaac@systemreboot.net> <86wnphrfhr.fsf_-_@mgsn.dev> Date: Mon, 02 Aug 2021 01:46:10 +0530 Message-ID: <87o8agapkl.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627849029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=h2nx4wBi1tGrmhvrZKRR/eTkwony8lOmhL7DVZwTjCE=; b=J+Mnkt1czof4/dZLmL24BEjcx0Hq3/UAhxm5GsOgJRaJK3NbPk5AqU4a8LhUGlZu0467uq yhVSJMuwBKhPtpHr/NxLg+7+bLtOFNa7CcUSVWvJnmbH6klg1kFZkrMp591Q3Z7lhF0R9A ykXCIkop9rJ08JA+o3RdyzhbmrsOSr/FvdjLjc/VrsRuofvGDX1qGF2I35R0dKali4TK2o 66d8LzyACj2qACKr+596blTafWp1BnxElp3O8FCRXYZgEoEZY6USd0efMKL+HH2h9XuNlT bCJmEmxDaZkHKsiUX73iPwRctVkGBwn4nQZ1giLgz9bgmxDAnga3cWfVVSl3Lw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627849029; a=rsa-sha256; cv=none; b=qoEjnNhxyUv9vZOkqbB3qrg01nqsCBBTVvOhPk/NUg75fhthkbGqBfc7dUgl7HFYX/yUIL nTzchvstqucxbYcuqVfF0dQwnLeBjU97ItQ+ump87s3PRubCkrqrKuHkAF8F41H+Bpm5ES mCn9b4cafMdZUeVsoo1WyPcDtMsITAUTPbPKIXAaWLvNLHodMU0ZQh/Epvwz3am8w5Qa4Q zQl9nU6FYrJvbphPhBVTk3C4zHC80FEU0ij3jrsKCUxNT7TVrIat0hcH9+Ut5NoXxgyUmY 0AL57dlKXYuYzFfsWtjzTXFbHHh97VbWy9FDG3HAlmd9gIOSiopGQDX5lc86yQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=STupT88y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=STupT88y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B2DD018308 X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: sGSgBsqrgrwO --=-=-= Content-Type: text/plain Hi Sarah, I have pushed patches 1-6 to master after implementing your suggestion for patch 6 (klauspost-compress). I'm sending a WIP v2 of patch 7 (nncp) in a following email. The tests are failing despite implementing your suggestion. Any help in that regard would be much appreciated. >> +(define-public nncp >> + (package >> + (name "nncp") >> + (version "7.2.0") In patch v2, I have updated to the latest version 7.5.0. >> + (build-system gnu-build-system) >> + (arguments >> + `(#:tests? #f ; tests fail > > It is not a good idea to just disable tests without knowing why they > fail (and leaving a comment explaining why). True, I agree. >> + #:modules ((guix build gnu-build-system) >> + ((guix build go-build-system) #:prefix go:) >> + (guix build union) > ^ this module isn't necessary > [...] >> + (guix build utils)) >> + #:imported-modules (,@%gnu-build-system-modules >> + (guix build union) >> + (guix build go-build-system)) > > This can probably just be > #:imported-modules ,%go-build-system-modules Good catch! Implemented both suggestions. >> + (setenv "BINDIR" (string-append out "/bin")) >> + (setenv "INFODIR" (string-append out "/share/info")) >> + (setenv "DOCDIR" (string-append out "/share/doc/nncp"))) > > Consider perhaps: > (setenv "DOCDIR" (string-append out "/share/doc/nncp" > ,(package-version this-package))) I've removed the version number from DOCDIR since that's what most packages are doing. Even the configure phase of the gnu-build-system does not put the version number in docdir. Only the install-license-files of the gnu-build-system puts the version number in, and that's probably a bug. > Does CFGPATH need to be set? I have now set CFGPATH TO /etc/nncp.hjson. > I took a quick look at the source and it looks like you'll also need: > > (substitute* '("src/toss_test.go" "src/pipe.go") > (("/bin/sh") (which "sh"))) > (substitute* "src/toss_test.go" > (("; cat") (string-append "; " (which "cat")))) > > Which also makes the tests succeed. Good catch, but tests still don't succeed (at least on my machine). >> + (inputs >> + `(("go" ,go))) I have moved go to native-inputs. >> + (native-inputs >> + `(("texinfo" ,texinfo))) >> + (propagated-inputs >> + `(("go-github-com-davecgh-go-xdr" ,go-github-com-davecgh-go-xdr) >> + ("go-github-com-dustin-go-humanize" ,go-github-com-dustin-go-humanize) >> + ("go-github-com-flynn-noise" ,go-github-com-flynn-noise) >> + ("go-github-com-gorhill-cronexpr" ,go-github-com-gorhill-cronexpr) >> + ("go-github-com-hjson-hjson-go" ,go-github-com-hjson-hjson-go) >> + ("go-github-com-klauspost-compress" ,go-github-com-klauspost-compress) >> + ("go-golang-org-x-crypto" ,go-golang-org-x-crypto) >> + ("go-golang-org-x-net" ,go-golang-org-x-net) >> + ("go-golang-org-x-term" ,go-golang-org-x-term) >> + ("go-lukechampine-com-blake3" ,go-lukechampine-com-blake3))) > > Since this is an end-user package, these can be regular inputs. Done! > I also notice that nncp can use `sendmail`; should `sendmail` be an > input as well? I think sendmail need not be an input. There are many sendmail compatible implementations and we can leave it up to the user to install one in their profile and configure nncp accordingly. > This package is also retaining references to the Go compiler package; > re-adding this phase from go-build-system fixes that: > > (add-after 'install 'remove-go-references > (assoc-ref go:%standard-phases 'remove-go-references)) Done! Thanks, Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmEHAQobHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuz5K8H/1/gJaj9LHz+a8Zvf4rC oen7t8tFp+ov1kPn0BibeGYrXGihhRR7x3q2QPQUx05k41pvtCo4fsNCRN1RyNnT 2iSvlcZh8EUBJSBG25IHJAPoutf2/yg6AQzIkQeVR9giOcsaSaX3pxEYac7bysOe 8g8C0kMQiReFONA0RqsrYGX21VuSQIuCXASnspJlaBJWFTM1LbCh3BA0xd3QCfrc aREgqsVlcOz01jW1JG63q7+B/lw4w/e9EXgoLEMlW0rSTJvkgXYS1jl6ZoJywv+p 3H57CFCYp0o8F4fKXnJ0zDXMlhq0aogHdKnYLBLsZM3lAtaysamVbPfls2eW4HUA 9Vs= =0gk9 -----END PGP SIGNATURE----- --=-=-=--