From: "Adolfo De Unánue" <adolfo@unanue.mx>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 50333@debbugs.gnu.org
Subject: [bug#50333] [PATCH] Fixed missing files in org-roam 2.1.0
Date: Tue, 14 Sep 2021 17:10:49 -0500 [thread overview]
Message-ID: <87o88ureh9.fsf@unanue.mx> (raw)
In-Reply-To: <86ilz3tkai.fsf@gmail.com>
Thank you for your comments and advices.
zimoun <zimon.toutoune@gmail.com> writes:
> Hi,
>
> You are asking in <http://issues.guix.gnu.org/issue/50374> about
> this
> one. Well, I am not an expert and I am not an Emacs Roam user.
>
> On Thu, 02 Sep 2021 at 22:57, Adolfo De Unánue
> <adolfo@unanue.mx> wrote:
>
>>>From a99fa75c0f5d3025827d99c3ef6a2c71c85e0be5 Mon Sep 17
>>>00:00:00 2001
>> From: =?UTF-8?q?Adolfo=20De=20Un=C3=A1nue?=
>> <adolfo+git@unanue.mx>
>> Date: Thu, 2 Sep 2021 22:23:58 -0500
>> Subject: [PATCH] Fixed missing files in org-roam v2.1.0
>
> The commit message should be:
>
> --8<---------------cut
> here---------------start------------->8---
> gnu: emacs-org-roam: Adding extensions.
>
> * guix/emacs-xyz.scm (emacs-org-roam)[arguments]: Add phases to
> install
> extensions.
> --8<---------------cut
> here---------------end--------------->8---
>
> Or something along these lines.
>
Should I apply your suggested changes, commit them, use this
commit
message, create the patch and send them again?
>> ---
>> gnu/packages/emacs-xyz.scm | 94
>> +++++++++++++++++++++-----------------
>> 1 file changed, 53 insertions(+), 41 deletions(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm
>> b/gnu/packages/emacs-xyz.scm
>> index 030809f5ac..431444c255 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -103,6 +103,7 @@
>> ;;; Copyright © 2021 Matthew James Kraai <kraai@ftbfs.org>
>> ;;; Copyright © 2021 Noisytoot <noisytoot@disroot.org>
>> ;;; Copyright © 2021 Simon South <simon@simonsouth.net>
>> +;;; Copyright © 2021 Nanounanue <adolfo@unanue.mx>
>
> Since you submit with this name “Adolfo De Unánue“, the
> Copyright should
> be the same instead of a nick name. From my point of view,
> nickname as
> copyright holder should be avoided; if possible, obviously. :-)
I will do, makes complete sense
>
>> + (let ((commit "f819720c510185af713522c592833ec9f2934251")
>
> Usually, the package uses tagged version instead of random
> commit. When
> it is not possible because upstream do not tag, it seems good to
> provide
> an explanation why the lasted tagged version cannot be used;
> explanations as a comment or in the cover letter.
>
As you guessed, org-roam has not tagged this new (breaking)
change,
that's why I am using the commit
> Another reason is because for instance it changes all the
> indentation
> and makes ‘git log/blame’ harder to investigate.
>
>> + (add-after 'install 'install-extensions
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (copy-recursively
>> + "extensions"
>> + (string-append (assoc-ref outputs "out")
>> + (string-append
>> + "/share/emacs/site-lisp/org-roam-"
>> + ,version)))
>> + #t))
>
> Patch#50333 will install the extensions with “guix install
> emacs-org-roam”. Instead the attempt of patch#50374 is to
> install with
> “guix install emacs-org-roam-extensions”. Well, I do not know
> if
> patch#50374 is correct, though.
>
> Because I am not an Org-Roam user, I do not have an opinion
> about this
> extensions. Maybe it is better to distribute them along the
> package
> emacs-org-roam or in a separate package, I do not know. WDYT?
>
I mean, structurally the upstream owner just moved some files to a
new
folder, my guess is that it shouldn't be a different packages
since it
is still part of org-roam.
> All the best,
> simon
Again thank you, it was super helpful!
--
- A
next prev parent reply other threads:[~2021-09-14 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 6:28 [bug#50333] [PATCH] Fixed missing files in org-roam 2.1.0 Adolfo De Unánue
2021-09-03 3:30 ` Adolfo De Unánue
2021-09-03 3:57 ` Adolfo De Unánue
2021-09-14 12:26 ` zimoun
2021-09-14 22:10 ` Adolfo De Unánue [this message]
2021-09-15 5:03 ` zimoun
2021-09-25 6:16 ` [bug#50333] [PATCH v4] gnu: emacs-org-roam: Adding extensions Adolfo De Unánue
2022-01-16 23:30 ` bug#50333: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o88ureh9.fsf@unanue.mx \
--to=adolfo@unanue.mx \
--cc=50333@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.