From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uLUGHe9VmWHIRwEAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 21:09:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WAeXGO9VmWFTJQAA1q6Kng (envelope-from ) for ; Sat, 20 Nov 2021 20:09:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 031F9F0E8 for ; Sat, 20 Nov 2021 21:09:19 +0100 (CET) Received: from localhost ([::1]:53660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moWfm-00073g-3g for larch@yhetil.org; Sat, 20 Nov 2021 15:09:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moWfX-00073R-7e for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moWfW-0001Rf-Hx for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moWfW-0005L5-D9 for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. In-Reply-To: <20211114124151.36743-1-philip@philipmcgrath.com> Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163743892920483 (code B ref 51838); Sat, 20 Nov 2021 20:09:02 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:08:49 +0000 Received: from localhost ([127.0.0.1]:43719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWfJ-0005KH-GR for submit@debbugs.gnu.org; Sat, 20 Nov 2021 15:08:49 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWfH-0005Jn-OL for 51838@debbugs.gnu.org; Sat, 20 Nov 2021 15:08:48 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B400C5C00CD; Sat, 20 Nov 2021 15:08:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 20 Nov 2021 15:08:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=swpPuVGvY/xlFAj3O5KVz6DKvUWtSER2V2nbE1xvCrQ=; b=Zi168FYe WAH1yYXAIXM7C9QW31Y/l91IRgonG/rXHXJqVII+aPF2hiaHCqzLFipQjao3/+tm ESu9EVp2N2zmDmtWXxf4GA8EjeCPR7bXWX0e4nHfy0zfn+eAwMskBctxX0DrMW6B lWegEgfC3IrEupeg7jZK5PhXhI+Zt8lXxxh7w4x7t9V8Zc9UXn2fjBRY6QES+cbN wWmRfzwgexDGMmry32bryDY02Pq5vGHTctrV22goACFIYOehZSVvCQKtuP1v8XNx G00MvCETFDtKoC3rXokFDTCeEB+WsoKptA0mFuWi4Cox0hYnGRWzBkq04Sofoq3d h/BM4lxAPrlo0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvuffffhfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpeefieeufffhuedujedttdekvdetffevudeigeefvdekkefhkeetgfehtdeu gfffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 20 Nov 2021 15:08:42 -0500 (EST) From: Timothy Sample Date: Sat, 20 Nov 2021 15:04:51 -0500 References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-5-philip@philipmcgrath.com> <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@gmail.com> <37768a63-5a4a-b604-2542-e8890fd68a16@philipmcgrath.com> Message-ID: <87o86ebnee.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637438959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=swpPuVGvY/xlFAj3O5KVz6DKvUWtSER2V2nbE1xvCrQ=; b=cj6u0NybXamGeyR2YtV7YnT86ZuQ8TGlmgqdBqLdvAsDJVMzhPz/jMZ8u6hi86EDUdzSzN 13XifaYbHjovuOEVMILTi/0MlcfmQFyT3cOIQA0xFrZmbndq1dE9QvePH5wUzl4Bvu40D5 0PGKGWKoklI8koe7X2l9EM/vOV+6RiCrCJdTqYJD0mnuLq6FNrzp7xgSipZEYazmIWkmrn c9tVmXLHPnlMhcwHls5K+8r/KqRIAYqyPoMq9Hpo9KTJ2AKjC5Mj+o1sxWvomHchhS8BTD d8wOtiTPED5Hc7EUAS2FjK8MFL6cig2Pwwfn0ForZ4Sopx4+E8JYzdarhYIH9Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637438959; a=rsa-sha256; cv=none; b=fJeEfCWjlErw8EMfe4KZ76d6QfohuPn3m5xvZIjuzNkX29k26J3pDsFNqZ9A2IdYAZf9a9 JahA/8KnJR7XgINZSTJjrU1NC5XhqEuyBEKWV6zkWM8xMAOG6l1u9CdrTckKcbqQ317Fgg V6VhWGmaRcu/iVZYD/2dE3HeoGYSDQWEUcgb8wKIwxncEYDy1NwdCfYtU8kSwzVY6FS9y3 gBlkKrdDLW4PtH5IwECbHstcbi7PzSQMeKlwoOVd/cZxdCqXGckkqWeggVvnD4YFkDGFbe 59v3LK2pBRNWmtAD6TuMPApFAGP+RPeqijpR+uinxKo1O9hgs9iva8hkRpmOBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Zi168FYe; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Zi168FYe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 031F9F0E8 X-Spam-Score: -1.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: wNNaAxc88jTs Hello, Philip McGrath writes: > On 11/20/21 02:41, Liliana Marie Prikler wrote: > >> In the resolve-dependencies subprocedure, we could check whether we >> have a matching input somewhere and only include the dependency if we >> do. WDYT? > > [...] > > The other issue is that deleting packages with no matching input by > default would replicate some of the drawbacks of the current `(delete=20 > 'configure)` approach. I think it's better to have an explicit list of > dependencies that Guix is deleting. If eventually we package all of > the missing dependencies for Guix, it would be much easier to find the=20 > packages that ought to use it. And, in the highly dynamic JavaScript > world, I'm reluctant to give up one of the few static checks we > have. If a missing package that really was required were automatically > deleted from "package.json", it seems the failure mode would by a > mysterious runtime error, potentially many steps down a dependency > chain. This is well put. I actually experimented with a similar approach when we updated the Node.js build system. This is a big improvement over deleting the configure phase, which would never scale to more than a handful of packages. Having a build-time check that ensures all the developer-declared dependencies are available (save the =E2=80=9Cabsent=E2= =80=9D ones) will be very helpful when we are maintaining hundreds of JavaScript packages. :) For the patch itself, it would be better to move a lot of your commit message into a comment somewhere in the build system code. If we had a section in the manual for Node packages, it would go there, but alas.... I think most people would be happy to see a comment in the build system code and be saved from having to poke around with =E2=80=98git blame=E2=80= =99. -- Tim