From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iFegG6xJvGHPWgAAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 09:26:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wPhrF6xJvGHbfgAAB5/wlQ (envelope-from ) for ; Fri, 17 Dec 2021 08:26:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 348823B565 for ; Fri, 17 Dec 2021 09:26:20 +0100 (CET) Received: from localhost ([::1]:33418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1my8ZH-0000ju-85 for larch@yhetil.org; Fri, 17 Dec 2021 03:26:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1my8ZA-0000hF-IX for guix-patches@gnu.org; Fri, 17 Dec 2021 03:26:12 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1my8Z0-0003NC-I5 for guix-patches@gnu.org; Fri, 17 Dec 2021 03:26:12 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1my8Z0-0001K0-F9 for guix-patches@gnu.org; Fri, 17 Dec 2021 03:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52437] Add lifeograph Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Dec 2021 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52437 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 52437@debbugs.gnu.org Cc: paumars@courrier.dev X-Debbugs-Original-To: Pradana Adrinusa AUMARS via Guix-patches via X-Debbugs-Original-Cc: Pradana Adrinusa AUMARS , 52437@debbugs.gnu.org Received: via spool by 52437-submit@debbugs.gnu.org id=B52437.16397295174991 (code B ref 52437); Fri, 17 Dec 2021 08:26:02 +0000 Received: (at 52437) by debbugs.gnu.org; 17 Dec 2021 08:25:17 +0000 Received: from localhost ([127.0.0.1]:37844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my8YH-0001IP-8C for submit@debbugs.gnu.org; Fri, 17 Dec 2021 03:25:17 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:42179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my8YF-0001I8-Ad for 52437@debbugs.gnu.org; Fri, 17 Dec 2021 03:25:15 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id ACA9FE0011; Fri, 17 Dec 2021 08:25:08 +0000 (UTC) From: Nicolas Goaziou References: <8f43f4093a94b958fe8d65ae731e4b0405e9a01f.camel@courrier.dev> Date: Fri, 17 Dec 2021 09:25:07 +0100 In-Reply-To: <8f43f4093a94b958fe8d65ae731e4b0405e9a01f.camel@courrier.dev> (Pradana Adrinusa AUMARS via Guix-patches via's message of "Sat, 11 Dec 2021 19:02:03 +0100") Message-ID: <87o85f63ks.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639729580; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=kpH/igHiuZWN5ZGGuKxxO0ZUEPcU7+50XOwNzEjAdnI=; b=als3Q6wXfxwrwHpD2EM82XC2dWWb6NVS9fkodBdkFMxKncVJD88hF30E0yUItfPW1YjnX8 Jv6s5gdceg/MZrrcdaS8hBqRz85YxOMtILpwvgUShnB81ZZP3hoPMS87olFZO224TCwmOD ckFvVOG39Vsazn14QbCDfRtuL+yD0JtZGxpamaee9OhgGvfyedmsjAcbXAiGbwCtrX0aXR otAo53yTFtyNv368YW44Z6lr96w5BvWSLXQ/bi0/OJIwrGpMUAXlXC8GQtpS7zlKTM7EZX JXqGrkMe9LcPVDEifotthuu+Kq9IddS7qPsCY0aydRSdpdRCa2NwgJ5edzYDFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639729580; a=rsa-sha256; cv=none; b=umkFH52nFscNLufcb5lj6FvPq1zkQK8waN7QKe6IXsjM6OvVVqgTAJ9+sf0ZijJPr8Oo7R tAMNBaAr49zKpgdSy2ZCIcRenAVt+yauRpclrCArDLMRz14q9/aGmp4lDgiroMv2jdIoqK UJCkq1RNTXFmvrpEYhPVRCuCCL4RnRYeqkJSYoaplRt4PaAtwuYOylUN4TiTc1Pup7A0RX fWFnnQcJJGZZ1Y/SPMN0NtDc3rXPRBYIYdvlOKWGkCwrep3zx8U6M4ep16Q30wIXc+YK3T vYGnZtNnUhzaV9buMO16PhWFTYI4XY2zKbaLEBdHt7ok2mo6caPa9paskCKlVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 348823B565 X-Spam-Score: -4.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: slVpa2uRd+bx Hello, Pradana Adrinusa AUMARS via Guix-patches via writes: > From 324b8cd3c801ad7c106725aff59fa65d00b50341 Mon Sep 17 00:00:00 2001 > From: Pradana AUMARS > Date: Sat, 11 Dec 2021 18:58:51 +0100 > Subject: [PATCH] gnu: Add lifeograph. Thank you. Some comments follow. > * gnu/packages/lifeograph.scm (lifeograph): New file. If you create a new file (is in necessary?), you need to also register it in local.mk file. > +(define-public rednotebook > + (package > + (name "lifeograph") There's a mismatch between the name of the variable and the package. > + (version "2.0.2") > + (source (origin Could you move origin below source? > + (method url-fetch) > + (uri (string-append "https://launchpad.net/" name "/trunk/" version > + "/+download/" name "-" version ".tar.xz")) You can hard-code "name" above. > + (sha256 > + (base32 > + "1sfr3fd07x995makdp5wx3lxf7kl156hilliw77d0vnjp8ri49xl")))) Hash string should go on the same line as base32. > + (build-system meson-build-system) > + (arguments `(#:build-type "release")) Could you explain in a comment why "release" is needed? > + (inputs > + `(("gtkmm" ,gtkmm) > + ("gtk+", gtk+ "bin") > + ("enchant" ,enchant) > + ("libgcrypt" ,libgcrypt) > + ("libchamplain" ,libchamplain))) Could you sort inputs alphabetically? Also could you use new inputs style: (inputs (list enchant `(,gtk+ "bin") gtkmm ...)) > + (native-inputs > + `(("pkg-config" ,pkg-config))) Ditto: (native-inputs (list pkg-config)) > + (synopsis "Off-line and private journal and note taking application") > + (description "Lifeograph is a diary program to take personal notes on life. > +It has all the essential functionality expected in a diary program and strives > +to have a clean and streamlined user interface.") > + (home-page "http://lifeograph.sourceforge.net/") > + (license license:gpl3+))) Could you send an updated patch? Regards, -- Nicolas Goaziou