From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 54783@debbugs.gnu.org, Stefan Baums <baums@stefanbaums.com>
Subject: bug#54783: ZRAM default priority wrong
Date: Tue, 24 May 2022 11:42:08 -0400 [thread overview]
Message-ID: <87o7zn3pkf.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220421134921.1505-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Thu, 21 Apr 2022 15:49:20 +0200")
Hi,
Josselin Poiret <dev@jpoiret.xyz> writes:
> * gnu/services/linux.scm
> (zram-device-configuration) [priority]: Adapt to use #f or an integer
> from 0 to 32767. Add sanitizer to warn for the change and delay the
> field.
> (zram-device-configuration->udev-string): Adapt as above.
> * doc/guix.texi (Zram Device Service): Change priority description to
> refer to the Swap Space one, and suggest not leaving the default #f on
> to properly use zram.
> ---
> doc/guix.texi | 10 +++++-----
> gnu/services/linux.scm | 26 +++++++++++++++++++++++---
> 2 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index b7005f0ef1..31f391357d 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -96,7 +96,7 @@ Copyright @copyright{} 2021 Domagoj Stolfa@*
> Copyright @copyright{} 2021 Hui Lu@*
> Copyright @copyright{} 2021 pukkamustard@*
> Copyright @copyright{} 2021 Alice Brenon@*
> -Copyright @copyright{} 2021 Josselin Poiret@*
> +Copyright @copyright{} 2021, 2022 Josselin Poiret@*
> Copyright @copyright{} 2021 Andrew Tropin@*
> Copyright @copyright{} 2021 Sarah Morgensen@*
> Copyright @copyright{} 2021 Josselin Poiret@*
> @@ -34650,11 +34650,11 @@ that compression will be 2:1, it is possible that uncompressable data
> can be written to swap and this is a method to limit how much memory can
> be used. It accepts a string and can be a number of bytes or use a
> suffix, eg.: @code{"2G"}.
> -@item @code{priority} (default @code{-1})
> +@item @code{priority} (default @code{#f})
> This is the priority of the swap device created from the zram device.
> -@code{swapon} accepts values between -1 and 32767, with higher values
> -indicating higher priority. Higher priority swap will generally be used
> -first.
> +@xref{Swap Space} for a description of swap priorities. You might want
> +to set a specific priority for the zram device, otherwise it could end
> +up not being used much for the reasons described there.
> @end table
>
> @end deftp
> diff --git a/gnu/services/linux.scm b/gnu/services/linux.scm
> index 2eb02ac5a3..9f598b2826 100644
> --- a/gnu/services/linux.scm
> +++ b/gnu/services/linux.scm
> @@ -4,6 +4,7 @@
> ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2021 raid5atemyhomework <raid5atemyhomework@protonmail.com>
> ;;; Copyright © 2021 B. Wilson <elaexuotee@wilsonb.com>
> +;;; Copyright © 2022 Josselin Poiret <dev@jpoiret.xyz>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -21,9 +22,11 @@
> ;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>
> (define-module (gnu services linux)
> + #:use-module (guix diagnostics)
> #:use-module (guix gexp)
> #:use-module (guix records)
> #:use-module (guix modules)
> + #:use-module (guix i18n)
> #:use-module (gnu services)
> #:use-module (gnu services base)
> #:use-module (gnu services shepherd)
> @@ -252,7 +255,19 @@ (define-record-type* <zram-device-configuration>
> (memory-limit zram-device-configuration-memory-limit
> (default 0)) ; string or integer
> (priority zram-device-configuration-priority
> - (default -1))) ; integer
> + (default #f) ; integer | #f
> + (delayed)
I'm curious, what does delaying the field buys us here? Is it to avoid
printing the warning multiple times when the record is evaluated?
> + (sanitize warn-zram-priority-change)))
> +
> +(define-with-syntax-properties
> + (warn-zram-priority-change (priority properties))
> + (if (eqv? priority -1)
> + (begin
> + (warning (source-properties->location properties)
> + (G_ "Using -1 for zram priority is deprecated to align with \
> +the corresponding swap-space field, please use #f from now on.~%"))
> + #f)
> + priority))
By convention, a warning message should not be a complete sentence (no
capitalized first letter nor last period) and be short. To provide a
human friendly hint/message, you could use 'display-hint' (combined with
a more succinct warning).
The rest LGTM.
Maxim
next prev parent reply other threads:[~2022-05-24 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 2:27 bug#54783: ZRAM default priority wrong Stefan Baums
2022-04-21 7:57 ` Josselin Poiret via Bug reports for GNU Guix
2022-04-21 8:06 ` Stefan Baums
2022-04-21 13:49 ` bug#54783: [PATCH 1/2] system: Align zram priority with swap-space spec to clarify Josselin Poiret via Bug reports for GNU Guix
2022-05-24 15:42 ` Maxim Cournoyer [this message]
2022-05-24 17:16 ` bug#54783: [v2 0/2] Clarify zram priority Josselin Poiret via Bug reports for GNU Guix
2022-05-24 17:16 ` bug#54783: [PATCH v2 1/2] system: Align zram priority with swap-space spec to clarify Josselin Poiret via Bug reports for GNU Guix
2022-05-24 17:16 ` bug#54783: [PATCH v2 2/2] doc: Remove double copyright Josselin Poiret via Bug reports for GNU Guix
2022-04-21 13:49 ` bug#54783: [PATCH " Josselin Poiret via Bug reports for GNU Guix
2022-06-11 5:56 ` bug#54783: ZRAM default priority wrong Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7zn3pkf.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=54783@debbugs.gnu.org \
--cc=baums@stefanbaums.com \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.