From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wKpbB0eFrGLOiQAAbAwnHQ (envelope-from ) for ; Fri, 17 Jun 2022 15:44:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2NxSB0eFrGLD3gAA9RJhRA (envelope-from ) for ; Fri, 17 Jun 2022 15:44:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8335A14B21 for ; Fri, 17 Jun 2022 15:44:38 +0200 (CEST) Received: from localhost ([::1]:41398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2CH7-00080Z-Oj for larch@yhetil.org; Fri, 17 Jun 2022 09:44:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2CGY-0007y7-3Q for guix-patches@gnu.org; Fri, 17 Jun 2022 09:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2CGX-0002sZ-P6 for guix-patches@gnu.org; Fri, 17 Jun 2022 09:44:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2CGX-0005Ww-NO for guix-patches@gnu.org; Fri, 17 Jun 2022 09:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55424] [PATCH 4/4] gnu: renpy: Update to 7.99.99-0-3e854bc. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Jun 2022 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55424 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 55424@debbugs.gnu.org Received: via spool by 55424-submit@debbugs.gnu.org id=B55424.165547341521215 (code B ref 55424); Fri, 17 Jun 2022 13:44:01 +0000 Received: (at 55424) by debbugs.gnu.org; 17 Jun 2022 13:43:35 +0000 Received: from localhost ([127.0.0.1]:44471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2CG6-0005W7-KR for submit@debbugs.gnu.org; Fri, 17 Jun 2022 09:43:35 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:40887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2CG1-0005Vq-KL for 55424@debbugs.gnu.org; Fri, 17 Jun 2022 09:43:33 -0400 Received: by mail-qk1-f172.google.com with SMTP id o73so3158378qke.7 for <55424@debbugs.gnu.org>; Fri, 17 Jun 2022 06:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=BqJvZCBZ/eGjPWix7NXOeovF8cQ7o8Ss7DQLG4a0HOo=; b=Wi9Mf2X+VBDHTQbyIyPTdJ37VJGeUsw4z1RzAVYc7/yXvZxtpqhFmjaCZJulclwB0z wt8xGBf1jD1PN88TFODAIF6fu2Pl23ggpjYAkqTWYRjYrUVoogxB5LmKzU4Oh32J027f 9oTkyWWOV1d+Mr0xN1L9k3dqnwip63MMtZ9R4FSyuTotxbY1+PrbaeDfh11YkdM4MJSb aSpN+LK7z1Qr1EF7ctf6Rm+O4WqvY8wVI/aamF8CaRGRM99RC5CwAxINTknvKKKCHTIj uaI31pbKclbayHz44rpOB1OX8Uz4SzfMN9hnIqIPpLrT2RhkgG7EHs+u7VMvQlA9t6Z+ FOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=BqJvZCBZ/eGjPWix7NXOeovF8cQ7o8Ss7DQLG4a0HOo=; b=oT7OiM3647+diI5Eoygkf8b5ZWNGOCaHS/9OmwKiefgVKVcVRk/gSUSG6e2q6HO7zK L6Pr9dhVrhYzPCh2mVrKHRq+5d1j2uvFqOKwZ7vigJaW5gKH3b3kIyPTHQHPN3kGvD83 bgXNbkyTjkLHJBjQ/6NCi5tLV0KlleEKzLxGCRI2I0vBZw/r+Wvqq8mIzYSQlFAwG7pG czkcD76Rnqv+BMUVqUH3C8KrE1rS2A+e7megoXYHmk8K/gZBLJbATnRuoi+CUV0LdM+C QoaEKbe3Dc0MtWHWmCTj/Qq4J7c29VTtVCxmVD3rejWTA5L7BxF8sTULpkUMEkYPNiO6 jEDg== X-Gm-Message-State: AJIora+yD+W5sdDVhUR7cgL031GnjUEk2kCfnrzfCtJFs4uqkmpe/mjD QZCrtzZzocpcjYuIQCJQBLGSMYrQ46+C9Q== X-Google-Smtp-Source: AGRyM1tfTr1KJvFAKoiChYGgTJhvW/cVBZPogOjSrm89tTxSRalUlkNl27v9vzAyS04ikiXCjzMwEQ== X-Received: by 2002:a05:620a:4624:b0:6a7:155e:44db with SMTP id br36-20020a05620a462400b006a7155e44dbmr6984480qkb.261.1655473403769; Fri, 17 Jun 2022 06:43:23 -0700 (PDT) Received: from hurd (dsl-205-233-124-10.b2b2c.ca. [205.233.124.10]) by smtp.gmail.com with ESMTPSA id u25-20020a37ab19000000b006a6b0be0cfesm4399459qke.10.2022.06.17.06.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 06:43:23 -0700 (PDT) From: Maxim Cournoyer References: <1c81a93681347259140a364e9d2330f93fcb89be.camel@gmail.com> Date: Fri, 17 Jun 2022 09:43:22 -0400 In-Reply-To: <1c81a93681347259140a364e9d2330f93fcb89be.camel@gmail.com> (Liliana Marie Prikler's message of "Fri, 17 Jun 2022 10:27:59 +0200") Message-ID: <87o7yr9zid.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655473478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BqJvZCBZ/eGjPWix7NXOeovF8cQ7o8Ss7DQLG4a0HOo=; b=t6JGxqBzf1IeOdqXxD8E6zr3lBz+0FB6ev0ycWxfVypK4qQmn36if0J5wk2sXzYBV3Sl/W rraTwxBcl75qVhlJ/0aLeRCNkkkRH6vkZUmWR7jsLHyO+ysfS1QB9OG6PnOvvAeRxhxX4R Ki3BVqrm5zt4tAE2D/EVVQia4ZVHShdglQUMm8vGGVGClWLZNZUbRdSUTKxK7cO3VdGF5a JaJnVy25YOKSFhCA0kX0APm5EQTmZVbXwxYInl3usFfixot6jcPwBn7E4Cl22PCzUPWLfz B2Lk4vIz2gESpQxNWTu9C4/7hY0hpxo9LpC2+fmoAPCFmMd57recBrXfIWI3ag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655473478; a=rsa-sha256; cv=none; b=Ite39vbFKEbYkP66aIjvD/suevjuoUii/Ueecx/mXMoMuuOGf+YQRiCSRv3Z3ZXQCJytrm ah0SmboyeAFJlvU8nQJDccyNqydPYJHUbQKsLRMxIsi1Uy2Sk4BEDzEBpcBjq/Y4gX3BTv 8C5pHKUeyXA0sYRph4LFkluYrTa1h74aQM7CZw5p9o5dNf+ZiMZFAkdSPLokWvmwHHSdex CYSGWJ4CT+Uvm2Qo/jCDrPjqC44jVYTwS/6btL8bURwWKzT1u6lMRnHRNR1R5WnzI7q2ZR 8giU78kPyhv13ZuAiOm1Nc4nUve6JivGCplMJcoMj90aFe/1JvYVk+pBIod7ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Wi9Mf2X+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Wi9Mf2X+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8335A14B21 X-Spam-Score: 6.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: UeIN7coIfuaV Hi, Liliana Marie Prikler writes: [...] > +;; Using nightly from 2022-06-16. > +;; Revert back to URLs once renpy 8 is released! > +(define %renpy-commit "3e854bc7cb1642ca18b061a0c6e349f168965c43") > (define-public python-renpy > (package > (name "python-renpy") > - (version "7.4.11") > + (version (git-version "7.99.99" "0" %renpy-commit)) I think it might be easy to overlook the "revision" field, since the more common convention is to define the "revision" and "commit" variables in a let; but perhaps that's just me. > (source > (origin > - (method url-fetch) > - (uri (string-append "https://www.renpy.org/dl/" version > - "/renpy-" version "-source.tar.bz2")) > - (sha256 (base32 "0zkhg2sd2hglm9dkansf4h8sq7lm7iqslzl763ambp4kyfdv= d07q")) > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/renpy/renpy") > + (commit %renpy-commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "11g7hqhw4gbkx5ib2wsawrznmjbn8r9zkgf2sg39z56h96y8= wfbn")) > (modules '((guix build utils))) > (patches > (search-patches > @@ -1486,8 +1492,11 @@ (define* (install-renpy-game #:key output game nam= e (renpy renpy) > #t)))))) > (inputs > `(("renpy.in" ,(search-auxiliary-file "renpy/renpy.in")) > + ("python-pefile" ,python-pefile) > + ("python-requests" ,python-requests) > ("python-renpy" ,python-renpy) > ("python-tkinter" ,python "tk") > + ("python-six" ,python-six) > ("python" ,python) ; for =E2=80=98fix-commands=E2=80=99 and =E2= =80=98wrap=E2=80=99 > ("xdg-utils" ,xdg-utils))) > (propagated-inputs '()) It'd be nicer to use new style inputs here, that'd take care of one out of 2 lint warnings: --8<---------------cut here---------------start------------->8--- gnu/packages/game-development.scm:1494:5: renpy@7.99.99-0.3e854bc: label 'p= ython-tkinter' does not match package name 'python:tk' gnu/packages/game-development.scm:1348:2: renpy@7.99.99-0.3e854bc: "bash-mi= nimal" should be in 'inputs' when 'wrap-program' is used --8<---------------cut here---------------end--------------->8--- Please take care of the 2nd lint suggestion as well. Other than that, it LGTM. I've built and linted all the packages in this series. Feel free to push with adjustments along my comments. Thanks again for picking that up. Maxim