From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GMgTDNx3TGSQvgAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 03:50:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QC70C9x3TGQxowAA9RJhRA (envelope-from ) for ; Sat, 29 Apr 2023 03:50:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0FC1828744 for ; Sat, 29 Apr 2023 03:50:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psZiv-00050m-Os; Fri, 28 Apr 2023 21:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psZit-00050U-FR for bug-guix@gnu.org; Fri, 28 Apr 2023 21:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1psZis-00067x-Sl for bug-guix@gnu.org; Fri, 28 Apr 2023 21:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1psZis-00017T-9K for bug-guix@gnu.org; Fri, 28 Apr 2023 21:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 06/17] services: mympd: Fix log file name. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 01:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bruno Victal Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.16827329694255 (code B ref 63082); Sat, 29 Apr 2023 01:50:02 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 01:49:29 +0000 Received: from localhost ([127.0.0.1]:34781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psZiK-00016Z-QB for submit@debbugs.gnu.org; Fri, 28 Apr 2023 21:49:29 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:49173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psZiI-00016L-Kv for 63082@debbugs.gnu.org; Fri, 28 Apr 2023 21:49:27 -0400 Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-5ef6b757a60so3332146d6.2 for <63082@debbugs.gnu.org>; Fri, 28 Apr 2023 18:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682732960; x=1685324960; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/iRgSIOHde6EiC7tINtDoGVtN3Kg49u9FK8mzCye5G8=; b=f1hAAE7jjysHqK7I7ZxDXW7W6Pc6w8//6XPurPlde3B2yg5WyXWx58nKGUsH6/J1U8 5eekP3Mnx/L7iZi7NZGEtUe9ZFTZi7EqDsZV0554EwKY+K2OrkTuQkgtG7BWeOzjgMDi qtYhjAuGNPLCD/g6li5fbgGwOLbznOxq9RklLtd2tn214on2EA7IqiirGcIxZL3xC8hU fDffKZenLKR/khIqOS6XgRlut/FukYm2q8qHn/qXsjo2enTC/D1QkBo2J7CXmbAK/6Mu RTsZAoubw0RtJu3bOhu7TbdXLn9KdWWXIt3ovmlWKtNUOrCBNUEk4u36ChZ7Eyel21xP KqoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682732960; x=1685324960; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/iRgSIOHde6EiC7tINtDoGVtN3Kg49u9FK8mzCye5G8=; b=BdHKILwvqehjGMSVeR4utZ06BoSLvKn6SUFW7DaAb/Yz2GgInXnk7q7grsME2KJ0M1 P7iWW9Dq3FjpZ+V/Hg5yr44wnZsp7i1acimKezGtAQ5aF/f8tAJMsLDpfyZlRpEEQgqS MFKmermpCbp+kjdHXU2zLc+nczDgZvRZWRv5El304VkoTy/ISYLXZivhnFsJIGPNWiGN RRjgonEtdul+ljXe1baXICGEZYHG9ejrJvVq5XJ+tX/dapP3se4lWemmcjeayibfD7BK JbI7mZlj2C1fhvkaPMh8RIC4t6x2MUCWEpUTH+EFCeCCwEYxzpqKGq/QvlVgsM07OhNy YZmQ== X-Gm-Message-State: AC+VfDz+XPvGuLppvJxb4bTo9mzoUcRhVx0gvYT1+kOr1J1rVgIimaXq t0njyBrtJbUTixryZJzdVuSOHOEsptGiFA== X-Google-Smtp-Source: ACHHUZ6ZE6oWMfxh8LM597W+6U++mSsXySW6/xMN/EgYdg10lj0ITOFsBdD+DAUpOeaw3XzfuLg3QQ== X-Received: by 2002:ad4:5be8:0:b0:5e8:e6ac:594e with SMTP id k8-20020ad45be8000000b005e8e6ac594emr11064995qvc.29.1682732960113; Fri, 28 Apr 2023 18:49:20 -0700 (PDT) Received: from hurd (dsl-157-4.b2b2c.ca. [66.158.157.4]) by smtp.gmail.com with ESMTPSA id r7-20020a0ce287000000b00606750abaf9sm6005902qvl.136.2023.04.28.18.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 18:49:19 -0700 (PDT) From: Maxim Cournoyer References: <878098810429d25922de0be323fae83b5a92e616.1682690696.git.maxim.cournoyer@gmail.com> <987f5bb4-88e0-6f3f-e941-0cbdfd8775a5@makinata.eu> Date: Fri, 28 Apr 2023 21:49:18 -0400 In-Reply-To: <987f5bb4-88e0-6f3f-e941-0cbdfd8775a5@makinata.eu> (Bruno Victal's message of "Fri, 28 Apr 2023 22:53:36 +0100") Message-ID: <87o7n7a25d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682733020; a=rsa-sha256; cv=none; b=iyE0RWXKMMPjdxzKwMblnqnXA4/sX7haozSJy+s+kCrKllAi/i6jRPY5dHUv/YWDT657HJ AJ5U3AUaUccWj8gFc98xXDbSIzsa/gS6tZG682vxKCLJb/L6VB5D+LQNX/bGIHrTrfDojf 8lRL0ZFdeBzEtDAcWJbadVC0+xwnRoVpZ8vscCWE8nIUXq5G49KgvkUuOj86X3Rsaz0bbA uuowPIqEPlbDs008Ie12F/DQ/WP6BZsXDzCwluZsSQeRWXWvx82eqifIxEnwzQXcH29g8+ 32bDmjuJ087vSK3hpmjKiRcnMjn6j/kTX75Zh8RU9hYAbwj1g6GLzLwDIqjfug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=f1hAAE7j; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682733020; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/iRgSIOHde6EiC7tINtDoGVtN3Kg49u9FK8mzCye5G8=; b=Nr8WWq0jZgNhKnztwtglCA95c8bLBPqYCEtTW76q2Kc5UjjBpm/7xbLmYfa6D7mDa9bZiW Ffg6LRVB+iIbD2f3tIA2YUdFqIaxEv1/h9a16sM5W0kCgl5HBJocS4dKiTUEnTG3xk7wk8 kCs7aCF651ZQvOZfXTfI+4BhQaJH/QfbHFKhcisv6+Nh3vKe0F+G5d09pP/fqTrFiRNiYR GJUX4xQA5Qj3HInD/Ija603y+d21wHB5qHLjDhQ8hsXAGrQd2tzhheCPaXwt799HG+LjKU x4FVIuqifsZDk7Zf0BIvGUgWk/DqUWiq6uGB9GjoFPrZrCvDGaIrMuvyZumDYw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=f1hAAE7j; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.80 X-Spam-Score: 5.80 X-Migadu-Queue-Id: 0FC1828744 X-TUID: v4fx7BDvmJf5 Hi, Bruno Victal writes: > On 2023-04-28 15:26, Maxim Cournoyer wrote: >> * gnu/services/audio.scm (mympd-configuration): Adjust log file name to match >> documentation. >> --- >> gnu/services/audio.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm >> index 1dc3204fc0..0b7a25d9ef 100644 >> --- a/gnu/services/audio.scm >> +++ b/gnu/services/audio.scm >> @@ -744,7 +744,7 @@ (define-configuration/no-serialization mympd-configuration >> "How much detail to include in logs, possible values: @code{0} to @code{7}.") >> >> (log-to >> - (string-or-symbol "/var/log/mympd/log") >> + (string-or-symbol "/var/log/mympd.log") >> "Where to send logs. By default, the service logs to >> @file{/var/log/mympd.log}. The alternative is @code{'syslog}, which >> sends output to the running syslog service under the @samp{daemon} facility." > > No, this is correct although perhaps /var/log/mympd/mympd.log would have been less error prone? > IIRC mympd is supposed to write to a subdirectory within /var/log and > this change would break the service. The only consumer of a 'log-to' is Shepherd, as far as I can see; so mympd doesn't get to know where the log is going (its output goes to stdout/stderr, captured by Shepherd), so shouldn't be writing anything under /var/log/mympd. Looking at upstream, they ship a fancy systemd service which wouldn't log to text files but to the journal, closer in spirit to syslog. For symmetry with mpd, I've now adjusted logging of mympd to default to syslog (and found it had an erroneous requirement on 'syslog rather than syslogd with the test :-)). -- Thanks, Maxim