From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, 63499@debbugs.gnu.org
Subject: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.
Date: Mon, 15 May 2023 09:49:25 -0400 [thread overview]
Message-ID: <87o7mlvh5m.fsf@gmail.com> (raw)
In-Reply-To: <3e89f7f30708b5702e1283534348cfc486ec0c61.1684060546.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 13 May 2023 22:27:57 +0200")
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set “GDK_BACKEND”
> and “GTK_A11Y”.
> ---
> gnu/packages/gtk.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index de45eb3870..7d76610293 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -616,6 +616,9 @@ (define-public gtksourceview
> ;; Tests require a running X server.
> (system (string-append Xvfb " :1 &"))
> (setenv "DISPLAY" ":1")
> + ;; For GTK
Nitpick: Add a full stop (period) for standalone comments. Perhaps
expound how these environment variables are useful to set ('For GTK'
leaves me wondering, as 'gtksourceview' already seems GTK-focused).
> + (setenv "GDK_BACKEND" "x11")
> + (setenv "GTK_A11Y" "none")
> ;; For the missing /etc/machine-id.
> (setenv "DBUS_FATAL_WARNINGS" "0")))))))
> (native-inputs
Otherwise, LGTM.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-05-15 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 10:35 [bug#63499] [PATCH gnome-team 0/3] To GTK and beyond Liliana Marie Prikler
2023-04-16 5:47 ` [bug#63499] [PATCH gnome-team 1/3] gnu: gst-plugins-base: Fix build Liliana Marie Prikler
2023-05-15 13:46 ` Maxim Cournoyer
2023-05-15 19:32 ` Liliana Marie Prikler
2023-05-13 18:50 ` [bug#63499] [PATCH gnome-team 2/3] gnu: gtk: Update to 4.10.3 Liliana Marie Prikler
2023-05-15 13:47 ` Maxim Cournoyer
2023-05-13 20:27 ` [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build Liliana Marie Prikler
2023-05-15 13:49 ` Maxim Cournoyer [this message]
2023-05-15 18:27 ` Liliana Marie Prikler
2023-05-15 19:44 ` Maxim Cournoyer
2023-05-27 14:25 ` bug#63499: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7mlvh5m.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=63499@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.