From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iGLABMsD3WQRcgAASxT56A (envelope-from ) for ; Wed, 16 Aug 2023 19:13:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6FOrBMsD3WR7hwAAauVa8A (envelope-from ) for ; Wed, 16 Aug 2023 19:13:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CCC2A472CF for ; Wed, 16 Aug 2023 19:13:46 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="IXDZ/sfh"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692206026; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=U0zH9soTWPgeG2airfdl97cFHDSWL13O0JQbEnvJTUc=; b=eR3Yd2YHGiQFuHRVMDHeKYQcyUzJZocLi1UUB79whCvbfFXJC9SeqVGlIiSy7OKnJYVZ3s Wt2ICsYl5rqXMWDGekhiwwYQLlbkgv7pMKMTi9oevcw1b2wFgO5CjVjuIh8Yva5LT2Vm9S dqGrmIjUlvBDe+hESxsvrZUqOt2IWGKGeaCgjIxxPvwS8yDTRgfzPMl5NfbsyITiLxBZfX 8fvnzu9CQNrWUWRWXsENNUyuSmJNA1uFByoSyEU3ORxN/R4MooBtMKqEsJbIBpSGzJFce6 uxIsZiJV5FjOjIwHF6MVuoKwxptVWPn13eQV/xF1CYiZAD7MLWfgWAtFDRAjWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="IXDZ/sfh"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692206026; a=rsa-sha256; cv=none; b=lzApx3xiUi7ThuXIRaTNY3en+6aia/xLOLwLmh2ZVqHh50E3pMy48SLDJ55RI0X6c85kFT SyxV+22H6cdAR8QEmRiYvei74nZYBzwR7GQBWFO4lS+msxEI7JpRqckZEkxxE6DT4o4t2E rfrcZ8t2MG8T7/6QCdMbTjHAqE5w+tZgju6u2EqPeVxxNkPA2nPMaRRpSRo8rql4OG/WWO DqHOQRMTW1fR4GGJ2qz4QHEYoC68NtwdmmLztcYGZE5VP67KEz95yRZt4y3wWJHh45+lxs zY668HpzBG6cibnQrNSNHy51tHmT+rLmipOYOf3pTxnf1n3i2fMkU42MfA+A7w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWK4I-0001NP-Gg; Wed, 16 Aug 2023 13:12:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWK3y-00018R-No for guix-patches@gnu.org; Wed, 16 Aug 2023 13:12:11 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWK3y-0006TS-7x for guix-patches@gnu.org; Wed, 16 Aug 2023 13:12:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWK3y-0005S9-3N for guix-patches@gnu.org; Wed, 16 Aug 2023 13:12:06 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Aug 2023 17:12:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64746 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , 64746@debbugs.gnu.org Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 64746-submit@debbugs.gnu.org id=B64746.169220591620786 (code B ref 64746); Wed, 16 Aug 2023 17:12:06 +0000 Received: (at 64746) by debbugs.gnu.org; 16 Aug 2023 17:11:56 +0000 Received: from localhost ([127.0.0.1]:41944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWK3n-0005P6-Fc for submit@debbugs.gnu.org; Wed, 16 Aug 2023 13:11:55 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:41435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWK3e-0005Ms-4n for 64746@debbugs.gnu.org; Wed, 16 Aug 2023 13:11:46 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3174ca258bbso1431626f8f.1 for <64746@debbugs.gnu.org>; Wed, 16 Aug 2023 10:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692205900; x=1692810700; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=U0zH9soTWPgeG2airfdl97cFHDSWL13O0JQbEnvJTUc=; b=IXDZ/sfhciky1iVH+YvJ1gJCdDmT9TFvfT8vRyuO+lv0iKIlsyqKfPCJ3xcNlO1jOs If8cy77VDJJP/zEmtQiIU4mCpWKAWOoR1khjz1Qh5AMMyPr/T7fJ+DmPKT6yPMlKOG6Y rSl1J9C2/VfAgSoRBb3E49nu3i98BJu52F7+/68RmOSwPysJqqKpwUwXz24cE1EY0n/J UABn/EZzh9ry/HlOheXM+B9sM1NU0CB+UBlo+pQenHd2mTrUI4uASvu/PmojC+3aEmDw zWvW4JhB5Gv9Xz0piiz+oNllCYQ3ng8TxQt0EaqDPQSREKWbQE2R72Uz475YioJrTmHE 0m1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692205900; x=1692810700; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U0zH9soTWPgeG2airfdl97cFHDSWL13O0JQbEnvJTUc=; b=g3sHK1yI3T5deHPXs550ctkjU1KmhAV5DrCQxCrcWWih27qCyvCvdvXf3INiNaItrr D9qi/PHBduRajEQIR0j2J3X7znF0GjjlE+O642xVdAvj5lvsTvXw+TSL+ITD7J3rur0I Y5dM+Fb07omocOQq1qhislmj5+YIsLVpos0X5No+KwS39AKIgp1XeTelrhKz7cs+7bQ4 ORUJ3o6PETujJCoWSYef/WKzKpVsRu3ZQIpDJf/sjOkY4XZD0EKexrq8LcAfgZyo2OsJ xo/L9NjkUD8v3pcPvPjvJb5Ho7QkkAygO+HnToMkrHT6Pa4ltW6wqlhrwQz29h7Obd67 hYkg== X-Gm-Message-State: AOJu0YzEd6lgBr9uTvpoE8WTQfNAEUECBt4xC3fOHqJ3CJhFc5rGn5UV wzhjlxqG8daXdVp2qINcczZOyawN758= X-Google-Smtp-Source: AGHT+IEq0ZMEa+JudWM+1qJbjSXllPzGWmFiX48lfEWggTYZV6onbUC0TOK+rBFyDVNdtbrTExVgaA== X-Received: by 2002:adf:e9c9:0:b0:317:3a23:4855 with SMTP id l9-20020adfe9c9000000b003173a234855mr2254174wrn.2.1692205900472; Wed, 16 Aug 2023 10:11:40 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id z2-20020adfec82000000b003141a3c4353sm1574426wrn.30.2023.08.16.10.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 10:11:40 -0700 (PDT) From: Simon Tournier In-Reply-To: References: <340786ccd3d40c0c8906028dc20af5ae9b0aa6b9.1692128648.git.maxim.cournoyer@gmail.com> Date: Wed, 16 Aug 2023 17:02:24 +0200 Message-ID: <87o7j7f2tb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: CCC2A472CF X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: 4.31 X-Migadu-Spam-Score: 4.31 X-TUID: QF5Jl3iGDaUc Hi Maxim, On Tue, 15 Aug 2023 at 15:44, Maxim Cournoyer w= rote: > For compatibility with (guix git) procedures. > > * guix/scripts/pull.scm (channel-list): Also accept tag-or-commit tagged > refspec. > --- I am not sure to understand these both changes. > > guix/scripts/pull.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm > index ecd264d3fa..9b78d4b5ca 100644 > --- a/guix/scripts/pull.scm > +++ b/guix/scripts/pull.scm > @@ -166,7 +166,7 @@ (define %options > (alist-delete 'repository-url result)))) > (option '("commit") #t #f > (lambda (opt name arg result) > - (alist-cons 'ref `(commit . ,arg) result))) > + (alist-cons 'ref `(tag-or-commit . ,arg) result))) Well, why not. :-) > (option '("branch") #t #f > (lambda (opt name arg result) > (alist-cons 'ref `(branch . ,arg) result))) > @@ -774,7 +774,8 @@ (define (channel-list opts) > (if (guix-channel? c) > (let ((url (or url (channel-url c)))) > (match ref > - (('commit . commit) > + ((or ('commit . commit) > + ('tag-or-commit . commit)) Here, why not also add 'tag?. Hum, I am missing why this =E2=80=99tag-or-c= ommit would be required. Cheers, simon