From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Munyoki Kilyungi <me@bonfacemunyoki.com>
Cc: jgart <jgart@dismail.de>, guix-devel@gnu.org
Subject: Re: IDEA: missing-tests-pypi-error? condition
Date: Fri, 06 Oct 2023 09:03:18 -0400 [thread overview]
Message-ID: <87o7hbkind.fsf@gmail.com> (raw)
In-Reply-To: <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> (Munyoki Kilyungi's message of "Fri, 06 Oct 2023 12:09:28 +0300")
Hi,
Munyoki Kilyungi <me@bonfacemunyoki.com> writes:
> "jgart" <jgart@dismail.de> aliandika:
>
>> Hi Guixers,
>>
>> I was recently reviewing a patch by a contributor and was discussing the notion of preferring upstream to PyPI when tests are missing on PyPI.
>>
> What's the policy on this. Shouldn't we prefer
> upstream over PyPI? Sometimes, PyPI versions lag
> behind upstream versions.
There's no written policy about it at this time, but I think it's common
knowledge in Guix that we try hard to:
1. Unbundle dependencies (that one is documented)
2. Run test suites (that one isn't)
We could hint at this globally in the contributing section, and perhaps
expound with more specific details in the Python Modules contributing
section, mentioning that when the PyPI source archive lacks tests,
fetching from the git repository should be preferred.
Another thing we could do is default to fetch from git for the Python
importer.
>> WDYT if we also signalled a special condition when there are missing tests in PyPI?
>>
> I posit that this should be the responsibility of
> the contributor. Adding extra glue can add
> unnecessary complexity.
I think an error would help catching this situation; the
gnu-build-system would fail running 'make check' when there is no check
target for example, but in the Python world, running 'python setup.py
test' often succeeds even 0 tests were run, which is easy to overlook.
I'm not sure how easy it'd be to check for missing tests though.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-06 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:08 IDEA: missing-tests-pypi-error? condition jgart
2023-10-06 9:09 ` Munyoki Kilyungi
2023-10-06 13:03 ` Maxim Cournoyer [this message]
2023-10-06 15:00 ` Munyoki Kilyungi
2023-10-07 16:07 ` Maxim Cournoyer
2023-10-08 13:11 ` jgart
2023-10-08 16:17 ` Luis Felipe
2023-10-09 0:52 ` Maxim Cournoyer
2023-10-09 13:36 ` Josselin Poiret
2023-10-09 13:57 ` jgart
2023-10-09 17:17 ` Maxim Cournoyer
2023-10-12 5:49 ` Efraim Flashner
2023-10-06 11:10 ` jgart
2023-10-06 12:50 ` Munyoki Kilyungi
2023-10-07 16:05 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7hbkind.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jgart@dismail.de \
--cc=me@bonfacemunyoki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.