From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mPWWCBndM2WxFAAAauVa8A:P1 (envelope-from ) for ; Sat, 21 Oct 2023 16:15:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mPWWCBndM2WxFAAAauVa8A (envelope-from ) for ; Sat, 21 Oct 2023 16:15:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B8D1B6A1CC for ; Sat, 21 Oct 2023 16:15:52 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HizdbjYz; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697897752; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GkTniW5zMismmbxuqZiTtkkYGF5IxY9l/hA1x59ZKRo=; b=sINrvYKyTWLSj1hQ0HWMNAUuCj2zbegZ0nkrXQqANG+igD+y5o26lPb499RW5obTzWrPEf OTrqi8fzke0cfVMaGOGpjFa1gHJdZg4ryMdoqZxsGMmzsSVCg/214DdBqUZ4jJkABGYUg+ RJ1V6D4vJGyqhaLrwaxDhXwArie9NFmDXD18eJboclC4H8JyqM1HatuOe7TWFgow/nc2bL CMYKf9sVcUQv6wvw8O/WII3ks3KNK1cvjkkgs0mYj42yURFpQ5ROvyuVOmI5IHJ/hJUvCg aGsCAUnizujSd9gMv1e5ANO85qnHvKa8QDzZhI8R37VPlSNC+kF2JKt38IQTdA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697897752; a=rsa-sha256; cv=none; b=kw4ybSlQvxXJZruxT6A1c1+cG9jkoK1EjAwFp5j8b+KGBaiaL0eNF6GFOOZMtQrQmIaVTn Y5YTySin9788C51JPXQTpYbgp0an2Vq1Z1ngv5R3a7mFMZQeJkT2TRbeFkFaiWVRwFYPCp qWffvIxpQIFWoLPkjR+Jumz2jptlaoZ1qFgIePG7arR66ckaz3AtfXBb6jT0hzZgNh5a/t wJZH8MVsArI141U0YRsfdHfB2UaONtbkeQXfWP+OBQz0KaIBpzsnwj8XXq6ns95FWvdgNa Lvk00RtkoQmWcZJWT0vyMdi082GcmPvTjOvH3MfGrSSeliB65I2bk+ZIy686ow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HizdbjYz; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quClX-0007hO-4a; Sat, 21 Oct 2023 10:15:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quClK-0007ga-No for bug-guix@gnu.org; Sat, 21 Oct 2023 10:15:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quClK-00087d-CH for bug-guix@gnu.org; Sat, 21 Oct 2023 10:15:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quClm-00054p-5W for bug-guix@gnu.org; Sat, 21 Oct 2023 10:16:02 -0400 Subject: bug#66659: (home-)on-first-login script broken when no gexps are added Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sat, 21 Oct 2023 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66659 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Carlo Zancanaro Cc: 66659-done@debbugs.gnu.org, Nils Landt Mail-Followup-To: 66659@debbugs.gnu.org, ludo@gnu.org, nils@landt.email Received: via spool by 66659-done@debbugs.gnu.org id=D66659.169789774918233 (code D ref 66659); Sat, 21 Oct 2023 14:16:02 +0000 Received: (at 66659-done) by debbugs.gnu.org; 21 Oct 2023 14:15:49 +0000 Received: from localhost ([127.0.0.1]:44784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quClY-0004jV-Ps for submit@debbugs.gnu.org; Sat, 21 Oct 2023 10:15:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quClX-0004VT-Iu for 66659-done@debbugs.gnu.org; Sat, 21 Oct 2023 10:15:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quCkx-000834-MA; Sat, 21 Oct 2023 10:15:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GkTniW5zMismmbxuqZiTtkkYGF5IxY9l/hA1x59ZKRo=; b=HizdbjYzupopBD7UF/Fl c2PBEq79KZzAWPtQCNRSwgLET2u/927f6C9cspMIj/zI9rmJ5Wnu/SaopuVRGci/eGBBOyZ6veZMx jm4+uZHDpRcR28Ign1Z1+/O/oH8gKH4r7cbP4H4LQQHn2Vl7VWOs74n7acHIGkJ7PG8GbSQ2s/AmC mWJWUVCtXKfm7FDKuGVN9uhDLe58UiBE/0HuUbRvuc4FcXCVa4gBKf2UoedHB2ZSOFTTJB3oYWBuU h1NP+1CdrY5gGUe96jnGXEO5YepurwvPolNfI7J0uBtZxGxLogzyJ3IjhwhK89rWwWQNsJzbaE3Kq rwFUa6iiwOr3ag==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87pm18codq.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Sat, 21 Oct 2023 20:27:12 +1100") References: <1084731920.55297.1697868845432@office.mailbox.org> <87pm18codq.fsf@zancanaro.id.au> Date: Sat, 21 Oct 2023 16:15:07 +0200 Message-ID: <87o7gsqcyc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.71 X-Migadu-Queue-Id: B8D1B6A1CC X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.71 X-TUID: hYWL3o0ZGtMY Hi Carlo & Nils, Carlo Zancanaro skribis: > On Sat, Oct 21 2023, Nils Landt wrote: >> ... >> As you can see, there is no body in the "when" expression. >> >> Code in gnu/home/services.scm:438 : >> >> (if (file-exists? xdg-runtime-dir) >> (when (claim-first-run flag-file-path) >> #$@gexps) >> >> In my case, it appears that gexps is empty, resulting in the invalid syn= tax. > > Ah, yep, that's an issue. That issue was introduced in 6b0a32196982a0a2f4= dbb59d35e55833a5545ac6. > > I guess this raises a question about how to resolve this: if we have no g= exps, do we still want to claim the first run? > > If yes: we can add #t (or whatever) to the end of the "when" form to make= sure it's never empty. > > If no: we can generate an empty on-first-login script that does nothing. > > The previous behaviour was to still claim the first run, so I'll send thr= ough a patch that does that. I=E2=80=99ve just pushed something similar to what you provided, Carlo, in commit e098ba2f499bbddfea50c85058e4077e39b85513. We should be good now. Thank you! Ludo=E2=80=99.