From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6DLJNJq6X2Uw6gAAauVa8A:P1 (envelope-from ) for ; Thu, 23 Nov 2023 21:48:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6DLJNJq6X2Uw6gAAauVa8A (envelope-from ) for ; Thu, 23 Nov 2023 21:48:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B4C6B52C9A for ; Thu, 23 Nov 2023 21:48:26 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=A43XoeWj; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700772506; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IHXNV+QfA9Rgma9rz8PzYsGrFiCl5R3kHZEOaNSbQ+E=; b=EgON1a/v4jDynt8cIdWt35QJEje+m2pUIWX8xw7xqLZikQU+EofCEAm32XgaRV6huUn0Ic 91vGw4P5I//NktzeoiYF6qL+utLmk5uyTrhLgYdMqu/EBKaTZ/CM+LClKZDMx2tgpurg+X GKTOBAe+bx24poeeKi/Rzqmr0x6n8yq37XPaItx+FIEsV/LjkuV2YVWm2b9vibLDRJAZsq EaiBmgZcalT/gZm9354WLI23K09wpqO2ReeO5sQBsz9YY+pwN08wQmjGhnQpXli4SJXzcg tu53RgZ0Ag3p9TUroo7k2eeK/L7+2Yn6oXkqer0/GWpSS6EVSSKYjkK034na2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=A43XoeWj; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700772506; a=rsa-sha256; cv=none; b=uRNWlXqg5/WXZAXqluuD5teZ88nX0pfuvmcH2j4XZ/WvTgBhQ2f3/FslJ9ItNXtCD7PeeS e0R+WKLoGvdi5ypCC0OfVMfuy4UcRp0Kw2QPV4Y8TEq1yA68oXJdFT9KhuLrszgy4I2Tf5 WZFeWMutqzbCEWQ5ySOvw+9fHYzV0jn7x0y9jt/UpeEuE4nH8qoFyO3WT8dFo7BhlvDlBd dTtmjZKDbPeUANbrRGsPXdIiZ3zYhHeFkDy/beAeudivVEc6z9/qQkmcJg+G2QWw3in8qO 2pT1/rkU5AtmgjpYRF4b1jhfOY3sTfHeUEOH6OjB9RT4XGQWz4NNXuupvT0f2g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6GcC-0002n1-3C; Thu, 23 Nov 2023 15:48:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6GcA-0002mf-OF for bug-guix@gnu.org; Thu, 23 Nov 2023 15:47:58 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6GcA-0004kp-GB for bug-guix@gnu.org; Thu, 23 Nov 2023 15:47:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6GcE-000871-Gk for bug-guix@gnu.org; Thu, 23 Nov 2023 15:48:02 -0500 Subject: bug#63736: [Shepherd] Loss of SIGCHLD notifications Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 23 Nov 2023 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63736 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 63736-done@debbugs.gnu.org Mail-Followup-To: 63736@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 63736-done@debbugs.gnu.org id=D63736.170077242330981 (code D ref 63736); Thu, 23 Nov 2023 20:48:02 +0000 Received: (at 63736-done) by debbugs.gnu.org; 23 Nov 2023 20:47:03 +0000 Received: from localhost ([127.0.0.1]:35196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6GbH-00083d-8C for submit@debbugs.gnu.org; Thu, 23 Nov 2023 15:47:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6GbF-000839-5H for 63736-done@debbugs.gnu.org; Thu, 23 Nov 2023 15:47:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6Gb5-0003ik-QT for 63736-done@debbugs.gnu.org; Thu, 23 Nov 2023 15:46:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IHXNV+QfA9Rgma9rz8PzYsGrFiCl5R3kHZEOaNSbQ+E=; b=A43XoeWjZUre5AN7tjvj nNpZtjbyHDXs65buh9OW4ZUsCHmU8T3PAsfTvytbBZ72JGIYfMAxxI7b8Uk0F63vt333v0v4p8ech R6lSPSAUm1J1TkagWx8q+slj/fynEM48c8QtHq1BCOUMDgGNkDDcxUdvcFjdfurm0z3Cn+XWM8m3L 5ilYbNRipcaCseZaibszMqmjoOibL5oss8YQvvfHSF0bF9poORVjLnuQpug/1VST/lC/Wdxu5PrlJ KnwypQ8WNrTnDnzpcj+dE5I1lwLMflz/RslvvBwZkrjUAOB/HqOk0c36AVbOq/sPbzgEiUjWvITgL n1QcRPgjQqHWFQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87wn0thfp4.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 27 May 2023 19:00:55 +0200") References: <87353jb88e.fsf@inria.fr> <87wn0thfp4.fsf@gnu.org> Date: Thu, 23 Nov 2023 21:46:49 +0100 Message-ID: <87o7fk8afa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.82 X-Spam-Score: -3.82 X-Migadu-Queue-Id: B4C6B52C9A X-Migadu-Scanner: mx13.migadu.com X-TUID: NQm43mYWlXbZ Ludovic Court=C3=A8s skribis: > Another possibility is lockup: one of the relevant fibers is either gone > or stuck in =E2=80=98put-message=E2=80=99 or =E2=80=98get-message=E2=80= =99. > > I did two things: > > b9a37f3 shepherd: Make signal handling fiber an essential task. > 8ae2780 service: Do not attempt to restart transient services. > > Commit 8ae2780 fixes a bug whereby =E2=80=98herd restart=E2=80=99 could e= nd up > attempting to restart a transient service, which would lock up the > calling fiber because the service=E2=80=99s controlling fiber would first > receive the 'terminate message, so it would return and nobody would be > reading further messages send on its channel. > > Commit b9a37f3 will allows us to ensure that the signal-handling fiber > never exits (and we=E2=80=99ll get a trace in the log if it tries to). Apparently these commits, which made it in 0.10.1 months ago, fixed this particular bug. Closing! Ludo=E2=80=99.