From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yAktCxEmu2WwNQEA62LTzQ:P1 (envelope-from ) for ; Thu, 01 Feb 2024 06:03:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yAktCxEmu2WwNQEA62LTzQ (envelope-from ) for ; Thu, 01 Feb 2024 06:03:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=JNIF7ZmZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706763793; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=T+BzIjNeW9FmrhCZSTbMi2f1dFGknkzjIshGsrtHo7U=; b=GkS/vjRJXFCRhhe+k2qrhYgNJGZWa3rIdpJnn1stEgoDs++oEa3IyjKxX1HStPi0/k+w1a Pr03vb0hiZkWJAWui0AdmN31NGrs4f0C/B0tG+URnOctqMVMkB9/XuVMLt7VMHXrpgPhx8 8qcO9V3AKB39Ikxvw+xYwlYW2WyQfkbBRYdzngzKUvQDbFmqvwTV0A8KuB4ChIsLpT2SSd 5HhaYt7zv2uRVz0uqRDl2StWIK6COplr8tmUgPnD7VI8bTLZ6LnzfoUwcU99iWXk2ziFWx Ofw+lBKq4AK7SALpMp2C5VII2340Q//aYa8pgPkpwpkrjPfoRdlX15kC0eqIbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=JNIF7ZmZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706763793; a=rsa-sha256; cv=none; b=MXk54ar1ATCYPmM99ohjGRAqofBfBLbKhfv3/1VRifn9pxI7s6pk51jWa0masXJ7uUcZb0 BLQ1SYAIDjU0awJpDGk7CPKal+lGLE4DjCBeNsw5O2h+14UF/lvoLLigcXGajJLNSxlXiq LezTJ9J0rwccbBGkVkAgeU94ESiQYXfExrrEyED/92MScZh+I6D4Bb5pFs1IqCfHbfunP6 4ayWSK+uEYaORSiwvRE73Xljhphqrf7BIPJEsVaTQD4rs/zrwa0B070kMqrT1HXYV3o+5+ DNCV1wnfQpg6baCG1lZPeQ8frZVp9nEK5AI3lqIja75z7Zn/i/4y0Jsd2VIGTA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90F2816B13 for ; Thu, 1 Feb 2024 06:03:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVPDz-0001sB-AQ; Thu, 01 Feb 2024 00:02:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVPDx-0001ru-0B for guix-patches@gnu.org; Thu, 01 Feb 2024 00:02:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVPDw-0007zq-Og for guix-patches@gnu.org; Thu, 01 Feb 2024 00:02:52 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVPE6-0002aV-CF for guix-patches@gnu.org; Thu, 01 Feb 2024 00:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Feb 2024 05:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68250 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke Received: via spool by 68250-submit@debbugs.gnu.org id=B68250.17067637479891 (code B ref 68250); Thu, 01 Feb 2024 05:03:02 +0000 Received: (at 68250) by debbugs.gnu.org; 1 Feb 2024 05:02:27 +0000 Received: from localhost ([127.0.0.1]:39502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVPDW-0002ZT-H2 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 00:02:26 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:47334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVPDR-0002ZH-Rw for 68250@debbugs.gnu.org; Thu, 01 Feb 2024 00:02:24 -0500 Date: Thu, 01 Feb 2024 13:01:59 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1706763680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T+BzIjNeW9FmrhCZSTbMi2f1dFGknkzjIshGsrtHo7U=; b=JNIF7ZmZ8J8NzJw0InCuDly7k81GOMj9l3rzG+OwJ8ydnOX2Sor74OwqAteKbKOcYPZnES S54IQpmzwlp8q/TttRCFhmIoTRHNFydpep8/wyntJBpeAGJ9rl2ilexKTGvHoMlf8O9/F6 8+ke/4w0tP6iEgubCgLdkjf7B/qpqyrd/neQlq1dgprGZHMKAIJ67E5QFSpxCh8ThMZ3wK 4wAikdkoycOo+XdXaDiCMZgsvQGbAqlObuzv1oSpH3btAK/maVpGgzOdVFDl0T97FX53fK ndMBAlt3nSie8vcfPtO4bygdXTMMZ5+0ejdcZDF9oY908irpzvFXBm3fcj99Ag== Message-ID: <87o7d04w1k.wl-hako@ultrarare.space> In-Reply-To: <8734uukrgq.fsf_-_@gmail.com> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP X-Spamd-Bar: ++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.67 X-Spam-Score: -5.67 X-Migadu-Queue-Id: 90F2816B13 X-Migadu-Scanner: mx12.migadu.com X-TUID: eLwCkANMGrJV Hi Maxim, On Fri, 19 Jan 2024 10:05:41 +0800, Maxim Cournoyer wrote: > > Hi, > > Hilton Chain writes: > > > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. > > > > Suggested-by: 宋文武 > > Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc > > --- > > gnu/packages/video.scm | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > > index e70aa5352e..10d46db38b 100644 > > --- a/gnu/packages/video.scm > > +++ b/gnu/packages/video.scm > > @@ -2365,7 +2365,13 @@ (define-public mpv > > ;; and passed as linker flags, but the order in which they are added > > ;; varies. See . > > ;; Set PYTHONHASHSEED as a workaround for deterministic results. > > - (setenv "PYTHONHASHSEED" "1")))) > > + (setenv "PYTHONHASHSEED" "1"))) > > + ;; mpv.pc is generated by meson. libmpv's headers don't actually > > + ;; require these dependencies so it's safe to remove these two fields. > > + (add-after 'install 'fix-mpv.pc > > + (lambda _ > > + (substitute* (string-append #$output "/lib/pkgconfig/mpv.pc") > > + (("^(Requires|Libs)\\.private:.*") ""))))) > > #:configure-flags > > #~(list "-Dlibmpv=true" > > "-Dcdda=enabled" > > I've just seen this, after pushing a hot fix as > f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed > libraries in Requires.private. > > I suppose that someone wanting to build something statically from mpv > would benefit from having the original mpv.pc file without > modifications. > > Perhaps we can try it out for a bit, and if the propagation causes > problems, we can fall-back to this change here? Then we should follow the approach in v1 to add libmpv as a separate package. I'll send v3 later. Thanks