From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id MLdlF+clFGaLwwAA62LTzQ:P1 (envelope-from ) for ; Mon, 08 Apr 2024 19:14:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MLdlF+clFGaLwwAA62LTzQ (envelope-from ) for ; Mon, 08 Apr 2024 19:14:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pHcRyTyZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712596455; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rVwDiRmNvS6Uouk04dWp334Abc0GkpuIaJtMfoAUW0Q=; b=JQVbUGuA9JO06hWDokiSvHJO4v3DY5FnSGZRxxN4XiV7nvo24+caor01hrBds22aZ5hqOn ZwbV6nPQpcACUTEerzYdCx27b1f8mweMHnE3E2r7kIRH4/J1Op63ZoXTWSm4K/TCuBKBtO H1yaFAHlcxjfO8A5t4Z9UQpIoYv7wrJQ+ktm+KGp5cpM7APnutgfKfeeBNB1/BsCladbuC yiC3Ld0VhcdD2jPmC7hnp9AqlAN1yJweHMMR+4mA5YnpAc4QP8G0X9pZva1q1pQUAEzEzS uYdQJDwQrw618NmGSktPLLy6Q1ehQrOkXc15KpY5zkdXOcEi/tCW9uM6qT+YpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712596455; a=rsa-sha256; cv=none; b=PzouFNUkc3ai0H1OlTcNxP+yneY/02xNeoq1+b6NC6ygGCt1TrFv9L0NXLi3iVVAdQh9Rl PZJ1bpy1Gn81zrVcEVlKw5zGLO9VVEy6IZ7fzASqN8Kez2jMB2N/1JJUg3kCIqA9yYdnoT rQCPST+XUdiXbl8fo7xtM8hT1ptvBRupksHbebSqpzQNbkWZ8Pex7jqUkti+zj5pdzLymY ljYH5bUMlYUOPpFUgXqMiXrAwwHHhdWvY/svn8UhNfY5I2gUEdJeQ6L7K1UYsjG7Z0m1Dh OWrU140GhiT4oX9oaw5g2Q6YjyF30dR8vEp4mKoASqi9/Us8nNtG2q8vZgPs4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pHcRyTyZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 004896095D for ; Mon, 8 Apr 2024 19:14:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtsZA-00023q-F8; Mon, 08 Apr 2024 13:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtsZ9-00023i-6G for guix-patches@gnu.org; Mon, 08 Apr 2024 13:13:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtsZ8-0006cg-U2 for guix-patches@gnu.org; Mon, 08 Apr 2024 13:13:54 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtsZG-0006HR-Da for guix-patches@gnu.org; Mon, 08 Apr 2024 13:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70169] [PATCH v2 09/12] maint: Remove %%CreationDate from generated EPS files Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Apr 2024 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70169@debbugs.gnu.org Received: via spool by 70169-submit@debbugs.gnu.org id=B70169.171259638323851 (code B ref 70169); Mon, 08 Apr 2024 17:14:02 +0000 Received: (at 70169) by debbugs.gnu.org; 8 Apr 2024 17:13:03 +0000 Received: from localhost ([127.0.0.1]:47532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsYJ-0006Cd-Bm for submit@debbugs.gnu.org; Mon, 08 Apr 2024 13:13:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsYE-0006Bm-Po for 70169@debbugs.gnu.org; Mon, 08 Apr 2024 13:13:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtsY0-0006RW-An; Mon, 08 Apr 2024 13:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rVwDiRmNvS6Uouk04dWp334Abc0GkpuIaJtMfoAUW0Q=; b=pHcRyTyZ09RUebOjbKXI tgf+WP/gC8gmDN8A9cI+IIhr/3SzQ66R2k43pfGqv+8MtUhLJ4ZtFLemyOmgHBGNKE+I1i3jFTKa9 I/mtvaIvXnyrj+DW81lAFj7Yh7c0Xxm/YOwZc/Ldqnl+bCQaiJNmUqzkq/D+bx24WeQAeG13E9hP1 g92Fk64HOJ0KBABCVjQceGNmW+VvJ2jZcmDfTVwKLo6hh0qOwFLXbntmP5zJggoYa+QfFpdlOJDBT bncVkxNGKvUquSXeF13+6vfPLDoRaIF9EHSXeh1eZGQc+khp901n0AJW3de7YC5hVLx3/AWxmoYpt DfSaIGI0QTQw5w==; From: Janneke Nieuwenhuizen In-Reply-To: <871q7gry2w.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 08 Apr 2024 11:41:11 +0200") Organization: AvatarAcademy.nl References: <109c05ead54c3e48a8df27794c8df56149343a37.1712437365.git.janneke@gnu.org> <871q7gry2w.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Mon, 08 Apr 2024 19:12:24 +0200 Message-ID: <87o7ajdbif.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.07 X-Spam-Score: -7.07 X-Migadu-Queue-Id: 004896095D X-Migadu-Scanner: mx12.migadu.com X-TUID: I1w3B3on2/nz Ludovic Court=C3=A8s writes: > Janneke Nieuwenhuizen skribis: > >> * doc/local.mk (.dot.eps, png.eps): Remove %%CreationDate. Split single= shell >> command into separate recipe lines, prefixed by $(AM_V_at). >> >> Change-Id: I5a03485c19c72f0c46411815c51290e52a8e5399 >> --- >> doc/local.mk | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/doc/local.mk b/doc/local.mk >> index c355bec8d7..60e36091ce 100644 >> --- a/doc/local.mk >> +++ b/doc/local.mk >> @@ -152,12 +152,16 @@ DOT_OPTIONS =3D \ >> mv "$(srcdir)/$@.tmp" "$(srcdir)/$@" >>=20=20 >> .dot.eps: >> - $(AM_V_DOT)$(DOT) -Teps $(DOT_OPTIONS) < "$<" > "$(srcdir)/$@.tmp"; \ >> - mv "$(srcdir)/$@.tmp" "$(srcdir)/$@" >> + $(AM_V_DOT)$(DOT) -Teps $(DOT_OPTIONS) < "$<" > "$(srcdir)/$@.tmp" >> + $(AM_V_at)grep -v ^%%CreationDate: "$(srcdir)/$@.tmp" > "$(srcdir)/$@.= tmp2" >> + $(AM_V_at)rm -f "$(srcdir)/$@.tmp" >> + $(AM_V_at)mv "$(srcdir)/$@.tmp2" "$@" > > Apparently =E2=80=98dot=E2=80=99 (GraphViz) does not emit a =E2=80=98Crea= tionDate=E2=80=99 header. Ah, good catch. > Should we drop this change and add a line like this above the =E2=80=98mv= =E2=80=99 line: Probably I just copied the grep to remove it without much looking or thinking :) > @if grep -q CreationDate "$@.tmp"; then false; else true; fi > > to be on the safe side? Let's do that, I'm adding it as $(AM_V_at)! grep -q %%CreationDate "$(srcdir)/$@.tmp" in v3. >> .png.eps: >> - $(AM_V_GEN)convert "$<" "$@-tmp.eps"; \ >> - mv "$@-tmp.eps" "$@" >> + $(AM_V_GEN)convert "$<" "$@-tmp.eps" >> + $(AM_V_at)grep -v ^%%CreationDate: "$@-tmp.eps" > "$@-tmp2.eps" >> + $(AM_V_at)rm -f "$@-tmp.eps" >> + $(AM_V_at)mv "$@-tmp2.eps" "$@" > > Looking into the code of ImageMagick, I see: > > timer=3DGetMagickTime(); > (void) FormatMagickTime(timer,MaxTextExtent,date); > (void) FormatLocaleString(buffer,MaxTextExtent, > "%%%%CreationDate: %s\n",date); > > where =E2=80=98GetMagickTime=E2=80=99 honors =E2=80=98SOURCE_DATE_EPOCH= =E2=80=99. Should we set > =E2=80=98SOURCE_DATE_EPOCH=E2=80=99 and avoid the =E2=80=98grep=E2=80=99 = trick? Good catch; and it already works. > OTOH, an argument to keep this patch as-is is that it=E2=80=99ll resist to > changes in ImageMagick/GraphViz. So maybe the comments above aren=E2=80= =99t > that relevant. Well, I like what we have now better; it's a bit sharper/cleaner anyway. Thanks! Janneke