all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>, 70892@debbugs.gnu.org
Cc: Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#70892] [PATCH 4/6] gnu: Add u-boot-starfive-visionfive2.
Date: Wed, 15 May 2024 10:59:01 -0700	[thread overview]
Message-ID: <87o797rm6y.fsf@wireframe> (raw)
In-Reply-To: <7c3b72a45a1c5d6adfb6ccd586ab68d587cfc420.1715508730.git.zhengjunjie@iscas.ac.cn>

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On 2024-05-12, Zheng Junjie wrote:
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index cfe8046731..1d52e961fd 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
...
> @@ -1343,6 +1344,36 @@ (define-public u-boot-sifive-unmatched
>         (modify-inputs (package-inputs base)
>           (append opensbi-generic))))))
>  
> +(define-public u-boot-starfive-visionfive2
> +  (let ((opensbi (package
> +                   (inherit opensbi-generic)
> +                   (arguments
> +                    (substitute-keyword-arguments
> +                        (package-arguments opensbi-generic)
> +                      ((#:make-flags flags)
> +                       `(cons* "FW_TEXT_START=0x40000000"
> +                               "FW_OPTIONS=0"
> +                               ,flags))))))
> +        (base (make-u-boot-package "starfive_visionfive2" "riscv64-linux-gnu")))

I would not want to block this patch on this, but...

Curious about the advantages and disadvantages of making this an
on-the-fly opensbi package variant... as so far I think most u-boot
packages just pull in inputs of other packages
(e.g. arm-trusted-firmware-*) rather than modifying them as part of the
u-boot-* package.

If this seems to be a good approach overall, maybe we should switch more
packages to use this approach ... or if there are significant downsides,
perhaps this patch series should just create another opensbi variant and
add it to inputs or whatever?

Thoughts?


That aside, looks good to me. :)

Thanks!

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2024-05-15 18:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-12 11:00 [bug#70892] [PATCH 0/6] Add visionfive2 support Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 1/6] gnu: linux-libre-6.8: add riscv config Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 2/6] image: raise error when use both grub-efi* bootloader and not gpt image Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 3/6] gnu: shepherd-0.10: When target riscv64, use guile-fibers-1.1 Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 4/6] gnu: Add u-boot-starfive-visionfive2 Zheng Junjie
2024-05-15 17:59   ` Vagrant Cascadian [this message]
2024-05-18 17:58     ` Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 5/6] bootloader: Add u-boot-starfive-visionfive2-bootloader Zheng Junjie
2024-05-12 11:09 ` [bug#70892] [PATCH 6/6] system: images: Add visionfive2 module Zheng Junjie
2024-05-15 18:02 ` [bug#70892] [PATCH 0/6] Add visionfive2 support Vagrant Cascadian
2024-05-18 17:42 ` [bug#70892] [PATCH v2 0/7] " Zheng Junjie
2024-05-18 17:42   ` [bug#70892] [PATCH v2 1/7] gnu: linux-libre-6.8: add riscv config Zheng Junjie
2024-05-19 10:42     ` 宋文武 via Guix-patches via
2024-05-18 17:42   ` [bug#70892] [PATCH v2 2/7] image: raise error when use both grub-efi* bootloader and not gpt image Zheng Junjie
2024-05-18 17:43   ` [bug#70892] [PATCH v2 3/7] gnu: shepherd-0.10: When target riscv64, use guile-fibers-1.1 Zheng Junjie
2024-05-18 17:43   ` [bug#70892] [PATCH v2 4/7] gnu: Add opensbi-for-visionfive2 Zheng Junjie
2024-05-19 10:38     ` 宋文武 via Guix-patches via
2024-05-18 17:43   ` [bug#70892] [PATCH v2 5/7] gnu: Add u-boot-starfive-visionfive2 Zheng Junjie
2024-05-18 17:43   ` [bug#70892] [PATCH v2 6/7] bootloader: Add u-boot-starfive-visionfive2-bootloader Zheng Junjie
2024-05-18 17:43   ` [bug#70892] [PATCH v2 7/7] system: images: Add visionfive2 module Zheng Junjie
2024-05-19  9:33     ` 宋文武 via Guix-patches via
2024-05-19 14:15 ` [bug#70892] [PATCH v3 0/7] Add visionfive2 support Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 1/7] gnu: linux-libre-6.8: Add riscv config Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 2/7] image: Raise error when use both grub-efi* bootloader and not gpt image Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 3/7] gnu: shepherd-0.10: When target riscv64, use guile-fibers-1.1 Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 4/7] gnu: Add opensbi-for-visionfive2 Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 5/7] gnu: Add u-boot-starfive-visionfive2 Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 6/7] bootloader: Add u-boot-starfive-visionfive2-bootloader Zheng Junjie
2024-05-19 14:15   ` [bug#70892] [PATCH v3 7/7] system: images: Add visionfive2 module Zheng Junjie
2024-05-22  3:22   ` bug#70892: [PATCH v3 0/7] Add visionfive2 support Z572

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o797rm6y.fsf@wireframe \
    --to=vagrant@debian.org \
    --cc=70892@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.