From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QMTaINdmkWaTQgEAe85BDQ:P1 (envelope-from ) for ; Fri, 12 Jul 2024 17:24:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QMTaINdmkWaTQgEAe85BDQ (envelope-from ) for ; Fri, 12 Jul 2024 19:24:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hOsP3oYE; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720805079; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6G8Gl3xDVEpIo8ssRUtaMYUszS5c2rsynyihTLXuuSk=; b=CniYiDBXpyIcUA9kHSO3NjcZKPKb+Y6TtKJyORotb+CgJMpYmBkVn1I8VwJDcBUCiaPdX+ LJi8Q3TJscMIt7xBB17Ca9ApTvGeZQeWotpXaoiNgXEQnbyzGc3r6CsppAmBndOBtr8ZC8 XgeJGgtl9oUaMXboDbc7tzBYN0GztU5DGZuuZKvtfF1eB8D6CBreBamXRX8yIT/5IlFbIA 8cIgqLOG5sUKE0Z3hs4DedNy+AU+vvU3bHompoMU3alwJu4HZnL/PUxqyOqgxfp03wWb6k cVTQheqGEqQcpVb6KIyOaoEnxZBtbIrDFzZ3ngAi+mGEMsOu0MDdDMPNv5hVUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hOsP3oYE; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720805079; a=rsa-sha256; cv=none; b=C60XrMLl4ffAa5Udefp1t1zGOe1zctNHr0KZX1TJN987i1w+2GOLaAyTSHkvKSkA18M0XL U60zReuqD9cgEvOCzUYlqNp5yV/VOLgAmfWOon3v8TUtMU8ilH508DSmjnFk1lzG9nkh6F GD/Wyj2TbgT5o7puJnHRQGzixghlWVvyIV5s7Vk6TpON6v1DiCP+UI4rhd73kUkFToxaf1 SlND+KiONiPSXCUsNPWP6h4Nwk9ynD4dsob6F0pAT8L9Jq/m81WxdnhYZT3iwJhyVqSIQQ SdXKChE/L29N/RJMGFuxUtiLrPQbx0Q+EZVlkr76xmNQajf1bb6hJ0RkN1ODTw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53D0B6FAE6 for ; Fri, 12 Jul 2024 19:24:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSK0E-0007QL-4A; Fri, 12 Jul 2024 13:24:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSK04-0007F7-6L for guix-patches@gnu.org; Fri, 12 Jul 2024 13:24:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSK03-0004TC-Tw for guix-patches@gnu.org; Fri, 12 Jul 2024 13:24:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSK04-0007Z9-7k for guix-patches@gnu.org; Fri, 12 Jul 2024 13:24:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jul 2024 17:24:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71697 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Greg Hogan Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , 71697@debbugs.gnu.org, Christopher Baines , Matthew Trzcinski Received: via spool by 71697-submit@debbugs.gnu.org id=B71697.172080502329023 (code B ref 71697); Fri, 12 Jul 2024 17:24:04 +0000 Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:43 +0000 Received: from localhost ([127.0.0.1]:54722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSJzi-0007Y1-Uo for submit@debbugs.gnu.org; Fri, 12 Jul 2024 13:23:43 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:39254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSJzf-0007XP-J3 for 71697@debbugs.gnu.org; Fri, 12 Jul 2024 13:23:40 -0400 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4266eae16b0so1341705e9.1 for <71697@debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720804953; x=1721409753; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6G8Gl3xDVEpIo8ssRUtaMYUszS5c2rsynyihTLXuuSk=; b=hOsP3oYEPH9WyIUY2zl9uH8p5RQyHUqeOlQtksamQqXVBG+OE20PNNlRET/Mb0qoBs AYD6DKtpK6xFwOGxvu7BMzFf5R7uQXRe/I93lJVazN7wuhMsHpma5fXcFIhzW7wNKX3F LTQooJyqd3JuM+mQKqcl1fsZKriJtLN47xeL76GJbf8/HvW5Z9ytglrzpZBGsyGf7TUF kHth383KJikXLlES81tx1hQkPxt28tfjSfPDur5CXKRC9tWDbbsMMp/beoBfr8qpEx4M DTRSz1p5yU3QtIenbLKT5hHzF/kIJaj4r34Qev3Mm27xGrJl94oXhwFzEco7L/4FOS1Y Ot3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720804953; x=1721409753; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6G8Gl3xDVEpIo8ssRUtaMYUszS5c2rsynyihTLXuuSk=; b=kuAazQTVVb/G4MotSMxVotrZ6oiJ4edGR3pMzJeeXHv8UXVfQNKeFCwaUPjJHi+Z1W 0zZtyg1cHH3X1pkOAUkhh8rYADUA+DbL049rRW5ionBXUj1h1LIMaBR6NY5krbdnEK8a +OkMs0TF5tEvOjzFq8uSXfAlPY8TQknjFttYodATQOfD1IpIjVjFSlfRje9I4ZhwiMOE myz5xUQVBlLUtSQ6CdejM4Mv7pwNjPES5L0+0LbCHXy9miibUwtPKpNXg07PDvUF/hYq ooDOtmKz9rwwjfqLq4kTVPkL6VqUnq8yQjEd+c+WNIBl3dXtloGMctsJKMWKkXtI0Fw+ 5kkg== X-Forwarded-Encrypted: i=1; AJvYcCU3v7RMV26r4XZVmXQ197rsgaAOjyKON76VnDnBpmxNk64kloujhqEhkLMsyAru2FNV4PN6CIzcvxPvAGW2j0VxKckPc68= X-Gm-Message-State: AOJu0Yw4UmXSHwfNaju0jcw1Fe03yHzRwcax4uL4ufUrrrQwc/tD9YRO gIgI/hpC59YuLdlM1cDrZOT/vT1V2jVyEESWUwLlRfvJUrUXuUTR X-Google-Smtp-Source: AGHT+IG+RC8N2o7p6VZikU/FXs1eJkt7Cnxq/TvwJ6uqMAhRtl1aw80kjuq/Z37X+Wrzgxfslm04GA== X-Received: by 2002:a05:600c:5125:b0:427:9f6c:e4bd with SMTP id 5b1f17b1804b1-427a1c61036mr8012685e9.6.1720804953525; Fri, 12 Jul 2024 10:22:33 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr. [194.254.61.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f2c1640sm29354145e9.43.2024.07.12.10.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 10:22:33 -0700 (PDT) From: Simon Tournier In-Reply-To: <87h6dfbj1w.fsf@gmail.com> References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@gmail.com> <871q4ldpgv.fsf@gnu.org> <87h6dfbj1w.fsf@gmail.com> Date: Fri, 12 Jul 2024 19:20:08 +0200 Message-ID: <87o772eddj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 53D0B6FAE6 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.80 X-Spam-Score: -3.80 X-TUID: XvtTf/iAw7fp Hi, On Wed, 26 Jun 2024 at 15:28, Maxim Cournoyer w= rote: >> Could we not instead create a GUIX_LINT_OPTIONS, similar to >> GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain >> checkers (or disable network checks) on their own system would be free >> to do so. > > That would be a good option to have too, on top of the other one. Well, I am not convinced it would be helpful. Because if you have: GUIX_LINT_EXCLUDE=3Darchival,home-page guix lint -L . foobar is as complicated as: guix lint -L . -x archival,home-page foobar And if ones does: export GUIX_LINT_EXCLUDE=3Darchival then the checker =E2=80=99archival=E2=80=99 would be always excluded, i.e.,= for the third-party custom packages =E2=80=93 that=E2=80=99s what the aim :-) =E2= =80=93 but also when the person would contribute to Guix proper =E2=80=93 and that=E2=80=99s aga= inst our quality assurance, IMHO. Somehow, from my point of view, the idea of the patch set is only to provide a complementary mechanism of =E2=80=9C--exclude=E2=80=9D. Consider= that I am packaging something for Guix proper and I am bored by some checker because it takes time, or because the warning annoys me or because it sends again and again the exact same request to SWH or because whatever other reasons, then I can just temporarily turn off that checker when developing and looping over =E2=80=9Cguix lint=E2=80=9D, either via --exclu= de or either via the package property. Once the package is ready, I submit it with all checkers turned on. Obviously, a third-party channel could use this mechanism to turn off the checkers. It=E2=80=99s up to them. :-) Well, maybe the wording of the manual could be tweaked if it does not capture this idea. Cheers, simon